Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 90672d74fdcfce996cf0507374791e15811b5e75
https://github.com/WebKit/WebKit/commit/90672d74fdcfce996cf0507374791e15811b5e75
Author: Richard Robinson <[email protected]>
Date: 2026-10-04 (Sun, 04 Oct 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/AppKitGestures/WKAppKitGestureController.mm
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] Bing.com: Unable to invoke context menu on image results
https://bugs.webkit.org/show_bug.cgi?id=326300
rdar://188642528
Reviewed by Tim Horton.
Currently, starting a secondary click only opens a context menu over selectable
content, video,
the image in a standalone image document, or content matched by a quirk. Bing
makes each of its
image results `user-select: none`, including the result's link and image, so
the secondary click
never begins over them and the context menu cannot be opened.
Context menus are always available for images and should always be shown, so
fix this by letting
the secondary click begin over any image. This subsumes the special case for
standalone image
documents, whose image is also `user-select: none`, so remove it.
Test: Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
* Source/WebKit/UIProcess/mac/AppKitGestures/WKAppKitGestureController.mm:
(representsSecondaryClickableElement):
(-[WKAppKitGestureController _secondaryClickShouldBeginAtLocation:]):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
(AppKitGesturesTests.clickAndHoldOnUnselectableImageOpensContextMenu(_:)):
(AppKitGesturesTests.clickAndHoldOnUnselectableContentDoesNotOpenContextMenu(_:)):
(AppKitGesturesTests.clickAndHoldOnUnselectableContentDoesNotOpenContextMenu):
Deleted.
Canonical link: https://commits.webkit.org/322658@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
