Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 118667ff82815cdb36417b7f3adc5baaba576d46
https://github.com/WebKit/WebKit/commit/118667ff82815cdb36417b7f3adc5baaba576d46
Author: Chris Dumez <[email protected]>
Date: 2026-10-04 (Sun, 04 Oct 2026)
Changed paths:
M Source/WTF/wtf/cf/CFTypeTraits.h
M Source/WebKitLegacy/PlatformCocoa.cmake
M Source/WebKitLegacy/SaferCPPExpectations/ForwardDeclCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
M Source/WebKitLegacy/Storage/InProcessIDBServer.cpp
M Source/WebKitLegacy/Storage/StorageNamespaceImpl.h
M Source/WebKitLegacy/Storage/StorageSyncManager.cpp
M Source/WebKitLegacy/Storage/StorageThread.cpp
M Source/WebKitLegacy/Storage/StorageThread.h
M Source/WebKitLegacy/Storage/StorageTracker.h
M Source/WebKitLegacy/Storage/WebStorageNamespaceProvider.cpp
M Source/WebKitLegacy/Storage/WebStorageNamespaceProvider.h
M Source/WebKitLegacy/WebCoreSupport/SocketStreamHandle.h
M Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImpl.cpp
M Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImpl.h
M Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImplCFNet.cpp
M Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp
M Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h
M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
R Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultFormDelegate.m
A Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultFormDelegate.mm
R Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m
A Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.mm
R Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultResourceLoadDelegate.m
A Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultResourceLoadDelegate.mm
R Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultUIKitDelegate.m
A Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultUIKitDelegate.mm
M Source/WebKitLegacy/ios/Misc/WebGeolocationCoreLocationProvider.mm
M Source/WebKitLegacy/ios/Misc/WebGeolocationProviderIOS.mm
M Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm
M Source/WebKitLegacy/ios/WebView/WebPDFViewIOS.mm
M Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm
M Source/WebKitLegacy/ios/WebView/WebPlainWhiteView.mm
R Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultEditingDelegate.m
A Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultEditingDelegate.mm
M Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultPolicyDelegate.mm
M Source/WebKitLegacy/mac/History/WebBackForwardList.mm
M Source/WebKitLegacy/mac/History/WebHistory.h
M Source/WebKitLegacy/mac/History/WebHistory.mm
M Source/WebKitLegacy/mac/History/WebHistoryItem.h
M Source/WebKitLegacy/mac/History/WebHistoryItem.mm
M Source/WebKitLegacy/mac/History/WebHistoryItemPrivate.h
M Source/WebKitLegacy/mac/History/WebHistoryPrivate.h
M Source/WebKitLegacy/mac/Misc/WebLocalizableStringsInternal.h
M Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.h
R Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.m
A Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.mm
R Source/WebKitLegacy/mac/Panels/WebPanelAuthenticationHandler.m
A Source/WebKitLegacy/mac/Panels/WebPanelAuthenticationHandler.mm
M Source/WebKitLegacy/mac/Plugins/WebPluginController.mm
M Source/WebKitLegacy/mac/Storage/WebDatabaseManager.mm
M Source/WebKitLegacy/mac/Storage/WebDatabaseManagerClient.mm
M Source/WebKitLegacy/mac/Storage/WebDatabaseManagerPrivate.h
M Source/WebKitLegacy/mac/Storage/WebStorageManager.mm
R Source/WebKitLegacy/mac/WebCoreSupport/WebJavaScriptTextInputPanel.m
A Source/WebKitLegacy/mac/WebCoreSupport/WebJavaScriptTextInputPanel.mm
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.h
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.mm
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlightView.h
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlightView.mm
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlighter.h
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlighter.mm
M Source/WebKitLegacy/mac/WebView/WebView.mm
Log Message:
-----------
Address Safer C++ static analysis warnings in various WebKitLegacy folders
https://bugs.webkit.org/show_bug.cgi?id=326034
Reviewed by Anne van Kesteren.
Fix Safer C++ warnings in WebKitLegacy's Storage, WebCoreSupport, mac/Panels,
mac/Plugins, mac/Storage, mac/History, mac/WebInspector, mac/DefaultDelegates,
ios/DefaultDelegates, ios/Misc and ios/WebView, and update the expectations
accordingly. Several Objective-C files are renamed to Objective-C++ so that
they can use smart pointers.
* Source/WTF/wtf/cf/CFTypeTraits.h:
Add a CF type trait for CFNotificationCenterRef.
* Source/WebKitLegacy/PlatformCocoa.cmake:
* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultFormDelegate.mm: Renamed
from Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultFormDelegate.m.
* Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.mm:
Renamed from
Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m.
* Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultResourceLoadDelegate.mm:
Renamed from
Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultResourceLoadDelegate.m.
* Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultUIKitDelegate.mm: Renamed
from Source/WebKitLegacy/ios/DefaultDelegates/WebDefaultUIKitDelegate.m.
* Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultEditingDelegate.mm:
Renamed from
Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultEditingDelegate.m.
* Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultPolicyDelegate.mm:
* Source/WebKitLegacy/mac/Storage/WebDatabaseManager.mm:
* Source/WebKitLegacy/mac/Storage/WebStorageManager.mm:
Hold the shared instances in a NeverDestroyed<RetainPtr<>>.
* Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.h:
* Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.mm: Renamed from
Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.m.
* Source/WebKitLegacy/mac/Panels/WebPanelAuthenticationHandler.mm: Renamed from
Source/WebKitLegacy/mac/Panels/WebPanelAuthenticationHandler.m.
* Source/WebKitLegacy/mac/WebCoreSupport/WebJavaScriptTextInputPanel.mm:
Renamed from
Source/WebKitLegacy/mac/WebCoreSupport/WebJavaScriptTextInputPanel.m.
Use RetainPtr for owned instance variables and __weak for non-owning outlets.
* Source/WebKitLegacy/mac/History/WebHistory.h:
* Source/WebKitLegacy/mac/History/WebHistory.mm:
* Source/WebKitLegacy/mac/History/WebHistoryItem.h:
* Source/WebKitLegacy/mac/History/WebHistoryItem.mm:
* Source/WebKitLegacy/mac/History/WebHistoryItemPrivate.h:
* Source/WebKitLegacy/mac/History/WebHistoryPrivate.h:
* Source/WebKitLegacy/mac/Storage/WebDatabaseManagerPrivate.h:
Declare NSString globals as NSString * const.
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.h:
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.mm:
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlightView.h:
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlightView.mm:
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlighter.h:
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlighter.mm:
* Source/WebKitLegacy/ios/WebView/WebPDFViewIOS.mm:
* Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm:
Use RetainPtr for owned instance variables.
* Source/WebKitLegacy/ios/Misc/WebGeolocationProviderIOS.mm:
Use a WeakObjCPtr for the provider back pointer.
* Source/WebKitLegacy/Storage/StorageThread.cpp:
* Source/WebKitLegacy/Storage/StorageThread.h:
Make StorageThread CanMakeThreadSafeCheckedPtr and capture a CheckedPtr in the
thread lambdas.
* Source/WebKitLegacy/Storage/StorageNamespaceImpl.h:
* Source/WebKitLegacy/Storage/WebStorageNamespaceProvider.cpp:
* Source/WebKitLegacy/Storage/WebStorageNamespaceProvider.h:
* Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp:
* Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h:
Add type traits and use downcast<>.
* Source/WebKitLegacy/Storage/StorageTracker.h:
* Source/WebKitLegacy/WebCoreSupport/SocketStreamHandle.h:
Include the client headers instead of forward declaring them.
* Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImpl.h:
(WebCore::SocketStreamHandleImpl::copyCFStreamDescription): Mark
CF_RETURNS_RETAINED.
* Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImplCFNet.cpp:
Remove unused MainThreadPACCallbackInfo and suppress RetainPtrCtorAdopt false
positives for the streams returned by CFStreamCreatePairWithSocketToHost.
* Source/WebKitLegacy/Storage/InProcessIDBServer.cpp:
* Source/WebKitLegacy/Storage/StorageSyncManager.cpp:
* Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImpl.cpp:
* Source/WebKitLegacy/ios/Misc/WebGeolocationCoreLocationProvider.mm:
* Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm:
* Source/WebKitLegacy/ios/WebView/WebPlainWhiteView.mm:
* Source/WebKitLegacy/mac/History/WebBackForwardList.mm:
* Source/WebKitLegacy/mac/Plugins/WebPluginController.mm:
* Source/WebKitLegacy/mac/Storage/WebDatabaseManagerClient.mm:
Use protect() and smart pointer locals at call sites.
* Source/WebKitLegacy/SaferCPPExpectations/ForwardDeclCheckerExpectations:
* Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations:
* Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
Canonical link: https://commits.webkit.org/322659@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
