Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e2e0869eaaad6b5a15d8f858b38af7d34055c940
https://github.com/WebKit/WebKit/commit/e2e0869eaaad6b5a15d8f858b38af7d34055c940
Author: Chris Dumez <[email protected]>
Date: 2026-10-06 (Tue, 06 Oct 2026)
Changed paths:
M Source/JavaScriptCore/b3/B3AbstractHeapRepository.cpp
M Source/JavaScriptCore/b3/B3LowerToAir.cpp
M Source/JavaScriptCore/bytecode/InlineCacheHandler.cpp
M Source/JavaScriptCore/interpreter/MicrotaskCall.cpp
M Source/JavaScriptCore/jit/ExecutableMemoryHandle.h
M Source/JavaScriptCore/runtime/ISO8601.cpp
M Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp
M Source/JavaScriptCore/runtime/IntlDurationFormat.cpp
M Source/JavaScriptCore/runtime/temporal/core/CalendarICUBridge.cpp
M Source/JavaScriptCore/runtime/temporal/core/TimeZoneICUBridge.cpp
M Source/JavaScriptCore/wasm/WasmFormat.cpp
M Source/WTF/SaferCPPExpectations/ForwardDeclCheckerExpectations
M Source/WTF/SaferCPPExpectations/NoDeleteCheckerExpectations
M Source/WTF/wtf/Assertions.cpp
M Source/WTF/wtf/CompactRefPtrTuple.h
M Source/WTF/wtf/ConcurrentBuffer.h
M Source/WTF/wtf/DataRef.h
M Source/WTF/wtf/NativePromise.h
M Source/WTF/wtf/RefCounter.h
M Source/WTF/wtf/SentinelLinkedList.h
M Source/WTF/wtf/StdLibExtras.h
M Source/WTF/wtf/WeakHashMap.h
M Source/WTF/wtf/cocoa/TypeCastsCocoa.h
M Source/WTF/wtf/darwin/TypeCastsOSObject.h
M Source/WebCore/WebCorePrefix.h
M Source/WebCore/style/CustomFunctionRegistry.cpp
Log Message:
-----------
Address Safer C++ warnings in WTF headers
https://bugs.webkit.org/show_bug.cgi?id=326309
Reviewed by Anne van Kesteren.
Fix the WTF header warnings that account for most of the Safer C++
warning instances in the macOS and iOS static analysis logs. Use
suppressions, with a comment, only where there is no cleaner option.
* Source/JavaScriptCore/jit/ExecutableMemoryHandle.h:
Define ENABLE_LIBPAS_JIT_HEAP before the conditional include that checks
it, so MetaAllocatorHandle.h is no longer included when the libpas JIT heap
is used. MetaAllocatorHandle.h has a member whose type is only
forward-declared there, so every file that included it got a warning.
* Source/WebCore/WebCorePrefix.h:
Remove the unused MetaAllocatorHandle.h include.
* Source/WTF/wtf/CompactRefPtrTuple.h:
Release the old pointer through an adopted RefPtr instead of a raw pointer
and a manual derefIfNotNull().
* Source/WTF/wtf/ConcurrentBuffer.h:
Force Array to be instantiated with the class so the analyzer does not
treat it as forward declared.
* Source/WTF/wtf/DataRef.h:
Protect m_data before calling copy().
* Source/WTF/wtf/RefCounter.h:
Hold m_count in a std::unique_ptr with a deleter that calls
refCounterWasDeleted(), instead of a raw pointer.
* Source/WTF/wtf/SentinelLinkedList.h:
Do the CRTP downcast through a single derived() helper that casts from
this.
* Source/WTF/wtf/StdLibExtras.h:
Suppress the NoDelete warnings in memcpySpan(), memmoveSpan() and
secureZeroSpan(). The functions they call run no destructors but are not
annotated NODELETE.
* Source/WTF/wtf/WeakHashMap.h:
Suppress the member warnings on PeekType::key. PeekType is a short-lived
view that is never stored.
* Source/WTF/wtf/cocoa/TypeCastsCocoa.h:
Suppress the cast warnings in checked_objc_cast() and dynamic_objc_cast(),
which check the type before casting.
* Source/WTF/wtf/darwin/TypeCastsOSObject.h:
Retain the result of objc_getProtocol() before passing it to
class_conformsToProtocol().
Canonical link: https://commits.webkit.org/322839@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
