Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a441a3749a6818edabba72def3c0a6d7d2f92fe7
https://github.com/WebKit/WebKit/commit/a441a3749a6818edabba72def3c0a6d7d2f92fe7
Author: Adrian Taylor <[email protected]>
Date: 2026-10-06 (Tue, 06 Oct 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/Badging.mm
Log Message:
-----------
Badging tests are order-dependent
https://bugs.webkit.org/show_bug.cgi?id=326501
rdar://189286040
Reviewed by Zak Ridouh.
Badging.SameOrigin failed when run after Badging.CrossOrigin, and
Badging.ServiceWorkerOverride hung when run after Badging.ServiceWorker.
runOriginTest kept its result in function-local statics, initialized only once
per
process, so SameOrigin saw CrossOrigin's message. Reset them on each call.
ServiceWorkerOverride reused the service worker context ServiceWorker left in
the
default data store, because both serve from 127.0.0.1 and Site ignores the port.
Override preferences are only applied when a context is established, so the
worker
lacked setAppBadge and never replied. Give the test its own non-persistent
store.
Canonical link: https://commits.webkit.org/322868@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
