Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 15b217c7262096e6845f7b89f377c5e5f20017c4
https://github.com/WebKit/WebKit/commit/15b217c7262096e6845f7b89f377c5e5f20017c4
Author: Roy Reapor <[email protected]>
Date: 2026-10-06 (Tue, 06 Oct 2026)
Changed paths:
M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/upload_context.py
M
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/upload_context_unittest.py
Log Message:
-----------
[resultsdbpy] `UploadContext` a job could be processed before its data is
written to redis.
rdar://189338437
Reviewed by Jonathan Bedard.
Reordered the redis writes so the job's data is written before the job is added
to the queue. A job can no longer start whose data
has not been written yet. A crash between the two writes can still orphan the
data until it expires. Atomic writes is the longterm fix.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/upload_context.py:
(UploadContext.process_test_results):
*
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/upload_context_unittest.py:
(UploadContextTest.test_async_callback):
(UploadContextTest):
(UploadContextTest.test_async_processing_when_worker_runs_between_queue_writes):
(RunWorkerAfterFirstWrite):
(RunWorkerAfterFirstWrite.__init__):
(RunWorkerAfterFirstWrite.__call__):
Canonical link: https://commits.webkit.org/322900@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
