Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e2682658e4e2d1d3c6866d735c8ee0fc96155666
https://github.com/WebKit/WebKit/commit/e2682658e4e2d1d3c6866d735c8ee0fc96155666
Author: Jetzel Espinal <[email protected]>
Date: 2026-10-07 (Wed, 07 Oct 2026)
Changed paths:
M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js
M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/search.js
Log Message:
-----------
[results.webkit.org] ⌘F should not override system find-in-page when the
sidebar is expanded
https://bugs.webkit.org/show_bug.cgi?id=324905
rdar://188133425
Reviewed by Jonathan Bedard.
Stop overriding ⌘F to focus the commit search field. 280092@main skipped the
override only while
the sidebar is collapsed, but the sidebar starts expanded, so on a normal page
load ⌘F still never
reaches the browser's find-in-page. Move the commit search shortcut to "/",
show it in the field's
label, and let Escape return focus to the page in both search fields.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js:
(isTextEntryFocused):
(CommitSearchBar):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/search.js:
Canonical link: https://commits.webkit.org/322997@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
