Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 780083a665128ebe2584532e35bef59d8351e00e
https://github.com/WebKit/WebKit/commit/780083a665128ebe2584532e35bef59d8351e00e
Author: Kiet Ho <[email protected]>
Date: 2026-10-07 (Wed, 07 Oct 2026)
Changed paths:
A LayoutTests/css3/color-filters/color-filter-accent-color-expected.html
A LayoutTests/css3/color-filters/color-filter-accent-color.html
A LayoutTests/css3/color-filters/color-filter-scrollbar-color-expected.txt
A
LayoutTests/css3/color-filters/color-filter-scrollbar-color-of-composited-box-expected.txt
A
LayoutTests/css3/color-filters/color-filter-scrollbar-color-of-composited-box.html
A LayoutTests/css3/color-filters/color-filter-scrollbar-color.html
A
LayoutTests/css3/color-filters/color-filter-solid-color-image-expected.html
A LayoutTests/css3/color-filters/color-filter-solid-color-image.html
A
LayoutTests/css3/color-filters/ios/color-filter-scrollbar-color-expected.txt
A
LayoutTests/css3/color-filters/ios/color-filter-scrollbar-color-of-composited-box-expected.txt
A
LayoutTests/css3/color-filters/ios/color-filter-scrollbar-color-of-composited-box.html
A LayoutTests/css3/color-filters/ios/color-filter-scrollbar-color.html
M LayoutTests/platform/ios-18/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-sequoia/TestExpectations
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
M Source/WebCore/style/computed/StyleComputedStyle.cpp
M Source/WebCore/style/values/images/kinds/StyleColorImage.cpp
Log Message:
-----------
Some rendering code don't apply apple-color-filter to colors
rdar://188752427
https://bugs.webkit.org/show_bug.cgi?id=325705
Reviewed by Simon Fraser.
Colors from scrollbar-color and image(<color>) doesn't get applied with
-apple-color-filter before rendering. Fix them and added tests for those case.
Additionally, if accent-color is not opaque, it's blended with Canvas color
before
getting applied with -apple-color-filter, which seems wrong. Fix it by applying
-apple-color-filter first before blending with Canvas color.
Tests: css3/color-filters/color-filter-accent-color.html
css3/color-filters/color-filter-scrollbar-color-of-composited-box.html
css3/color-filters/color-filter-scrollbar-color.html
css3/color-filters/color-filter-solid-color-image.html
css3/color-filters/ios/color-filter-scrollbar-color-of-composited-box.html
css3/color-filters/ios/color-filter-scrollbar-color.html
* LayoutTests/css3/color-filters/color-filter-accent-color-expected.html: Added.
* LayoutTests/css3/color-filters/color-filter-accent-color.html: Added.
* LayoutTests/css3/color-filters/color-filter-scrollbar-color-expected.txt:
Added.
*
LayoutTests/css3/color-filters/color-filter-scrollbar-color-of-composited-box-expected.txt:
Added.
*
LayoutTests/css3/color-filters/color-filter-scrollbar-color-of-composited-box.html:
Added.
* LayoutTests/css3/color-filters/color-filter-scrollbar-color.html: Added.
* LayoutTests/css3/color-filters/color-filter-solid-color-image-expected.html:
Added.
* LayoutTests/css3/color-filters/color-filter-solid-color-image.html: Added.
* LayoutTests/css3/color-filters/ios/color-filter-scrollbar-color-expected.txt:
Added.
*
LayoutTests/css3/color-filters/ios/color-filter-scrollbar-color-of-composited-box-expected.txt:
Added.
*
LayoutTests/css3/color-filters/ios/color-filter-scrollbar-color-of-composited-box.html:
Added.
* LayoutTests/css3/color-filters/ios/color-filter-scrollbar-color.html: Added.
* LayoutTests/platform/ios-18/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-sequoia/TestExpectations:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::scrollbarColorStyle const):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::scrollbarColorStyle const):
* Source/WebCore/style/computed/StyleComputedStyle.cpp:
(WebCore::Style::ComputedStyle::usedAccentColor const):
* Source/WebCore/style/values/images/kinds/StyleColorImage.cpp:
(WebCore::Style::ColorImage::resolvedColor const):
Canonical link: https://commits.webkit.org/323028@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
