Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b5eae0ac0c347413d50e20df49aececf7a7fab3
      
https://github.com/WebKit/WebKit/commit/8b5eae0ac0c347413d50e20df49aececf7a7fab3
  Author: Elliott Williams <[email protected]>
  Date:   2026-10-08 (Thu, 08 Oct 2026)

  Changed paths:
    M Source/cmake/OptionsCocoa.cmake
    M Tools/DumpRenderTree/PlatformCocoa.cmake
    M Tools/DumpRenderTree/mac/Info.plist
    M Tools/PlatformCocoa.cmake

  Log Message:
  -----------
  [CMake] Build DumpRenderTree on macOS
https://bugs.webkit.org/show_bug.cgi?id=326825

Reviewed by Zak Ridouh.

Make the definition of ENABLE_LAYOUT_TESTS more coherent -- it now
behaves the same for all Cocoa platforms and controls both DRT and WKTR.
Remove the separate ENABLE_WEBKIT_TEST_RUNNER option.

Modernize DumpRenderTree's CMake description and make it match its Xcode
target.

* Source/cmake/OptionsCocoa.cmake: Move DumpRenderTree's derived sources
  into DerivedSources/, since the executable is written to the top of
  the build directory.
* Tools/PlatformCocoa.cmake: Let Tools/CMakeLists.txt add the layout test tools.
* Tools/DumpRenderTree/PlatformCocoa.cmake: Fix TestRunnerShared paths,
  add the shared Cocoa sources Xcode compiles, embed Info.plist, link
  WebKit.framework and match Xcode's deprecation warning setting.
* Tools/DumpRenderTree/mac/Info.plist: Spell PRODUCT_BUNDLE_IDENTIFIER
  as ${}, like PRODUCT_NAME, so configure_file substitutes it. Xcode
  accepts both spellings.

Canonical link: https://commits.webkit.org/323169@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to