Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: eecdbd5bc77cd2e6578c5fb796d039c9f6ddfc74
https://github.com/WebKit/WebKit/commit/eecdbd5bc77cd2e6578c5fb796d039c9f6ddfc74
Author: Elliott Williams <[email protected]>
Date: 2026-10-08 (Thu, 08 Oct 2026)
Changed paths:
M Source/WebKitLegacy/CMakeLists.txt
M Source/WebKitLegacy/PlatformCocoa.cmake
M Source/WebKitLegacy/SourcesCMakeCocoa.txt
M Source/WebKitLegacy/WebCoreSupport/LegacySocketProvider.cpp
Log Message:
-----------
[CMake] Compile WebKitLegacy's Sources.txt on Cocoa
https://bugs.webkit.org/show_bug.cgi?id=326826
Reviewed by Zak Ridouh.
Add (C++) Sources.txt to the CMake build, which provides
WebSocketChannel and SocketStreamHandleImpl. Remove the
BUILDING_WITH_CMAKE stub in WKL code that existed in place of these
sources. Drop duplicated source files from the listings.
Fixes WebSocket tests in DumpRenderTree which were hitting
RELEASE_ASSERT(m_channel) in WebSocket::connect.
* Source/WebKitLegacy/CMakeLists.txt:
* Source/WebKitLegacy/PlatformCocoa.cmake:
* Source/WebKitLegacy/SourcesCMakeCocoa.txt:
* Source/WebKitLegacy/WebCoreSupport/LegacySocketProvider.cpp:
(LegacySocketProvider::createWebSocketChannel): Remove the CMake-only stub.
Canonical link: https://commits.webkit.org/323170@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
