Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ffcbaa1934fce0c676b5267042712895c984df03
https://github.com/WebKit/WebKit/commit/ffcbaa1934fce0c676b5267042712895c984df03
Author: Alan Baradlay <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
M LayoutTests/imported/blink/fast/canvas/bidi-multi-run-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-ltr-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-ltr.html
A
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-rtl-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-rtl.html
A
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/reference/fillText-bidi-ltr-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/reference/fillText-bidi-rtl-ref.html
M Source/WebCore/platform/graphics/GraphicsContext.cpp
Log Message:
-----------
Switch GraphicsContext::drawBidiText from BidiResolver to ubidi
https://bugs.webkit.org/show_bug.cgi?id=326861
<rdar://problem/189548623>
Reviewed by Antti Koivisto.
This is in preparation for removing BidiResolver.
drawBidiText splits a single TextRun into bidi runs and draws them in visual
order.
It did this with the legacy line layout's BidiResolver, whose line breaking,
render tree and isolate bookkeeping a plain string never needs.
ICU's ubidi (already used by IFC) now resolves the runs instead, so this caller
no longer depends on BidiResolver.
Tests:
imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-ltr.html
imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-rtl.html
*
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-ltr-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-ltr.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-rtl-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fillText-bidi-rtl.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/reference/fillText-bidi-ltr-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/reference/fillText-bidi-rtl-ref.html:
Added.
* Source/WebCore/platform/graphics/GraphicsContext.cpp:
(WebCore::visuallyOrderedSubruns):
(WebCore::GraphicsContext::drawBidiText):
* LayoutTests/imported/blink/fast/canvas/bidi-multi-run-expected.html:
Progression. WebKit matches Chrome and Firefox now.
Canonical link: https://commits.webkit.org/323224@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
