Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ff80e7cfdbf739ee145105d297f705f49129305
https://github.com/WebKit/WebKit/commit/5ff80e7cfdbf739ee145105d297f705f49129305
Author: Sam Weinig <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/support/green-viewbox-25x25.svg
A
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/support/red-viewbox-25x25.svg
A
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/support/view-invalid-viewbox.svg
A
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-invalid-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-invalid.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-zero-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-zero.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/view-viewbox-invalid-fallback-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/view-viewbox-invalid-fallback.html
M LayoutTests/platform/glib/svg/custom/viewbox-syntax-expected.txt
M LayoutTests/platform/ios/svg/custom/viewbox-syntax-expected.txt
M LayoutTests/platform/ios/svg/hixie/error/010-expected.txt
M LayoutTests/platform/ios/svg/hixie/error/011-expected.txt
M
LayoutTests/platform/mac-tahoe-wk2-lbse-text/svg/custom/viewbox-syntax-expected.txt
M
LayoutTests/platform/mac-tahoe-wk2-lbse-text/svg/hixie/error/010-expected.txt
M
LayoutTests/platform/mac-tahoe-wk2-lbse-text/svg/hixie/error/011-expected.txt
M LayoutTests/platform/mac/svg/custom/viewbox-syntax-expected.txt
M LayoutTests/platform/mac/svg/hixie/error/010-expected.txt
M LayoutTests/platform/mac/svg/hixie/error/011-expected.txt
M LayoutTests/platform/win/svg/custom/viewbox-syntax-expected.txt
M LayoutTests/svg/hixie/error/010-expected.txt
M LayoutTests/svg/hixie/error/011-expected.txt
M Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.cpp
M Source/WebCore/svg/SVGFitToViewBox.cpp
M Source/WebCore/svg/SVGFitToViewBox.h
M Source/WebCore/svg/SVGSVGElement.cpp
M Source/WebCore/svg/SVGSVGElement.h
M Source/WebCore/svg/SVGViewSpec.cpp
Log Message:
-----------
svgView() fragment with an invalid or zero-size viewBox draws the SVG unscaled
https://bugs.webkit.org/show_bug.cgi?id=326824
Reviewed by Nikolas Zimmermann.
An svgView() fragment's viewBox was previously parsed without validation, so
missing numbers became 0 and a negative
width or height was accepted.
Additionally we now check whichever viewBox is in effect in
viewBoxDisablesPainting() to ensure fragments can disable
the painting when they are active.
While in the area, I update the warning and error text to include the invalid
string being parsed as well as the issue
at hand.
Tests:
imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-invalid.html
imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-zero.html
imported/w3c/web-platform-tests/svg/linking/reftests/view-viewbox-invalid-fallback.html
*
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/support/green-viewbox-25x25.svg:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/support/red-viewbox-25x25.svg:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/support/view-invalid-viewbox.svg:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-invalid-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-invalid.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-zero-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/svgview-viewbox-zero.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/view-viewbox-invalid-fallback-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/linking/reftests/view-viewbox-invalid-fallback.html:
Added.
* LayoutTests/platform/glib/svg/custom/viewbox-syntax-expected.txt:
* LayoutTests/platform/ios/svg/custom/viewbox-syntax-expected.txt:
* LayoutTests/platform/ios/svg/hixie/error/010-expected.txt:
* LayoutTests/platform/ios/svg/hixie/error/011-expected.txt:
*
LayoutTests/platform/mac-tahoe-wk2-lbse-text/svg/custom/viewbox-syntax-expected.txt:
* LayoutTests/platform/mac-tahoe-wk2-lbse-text/svg/hixie/error/010-expected.txt:
* LayoutTests/platform/mac-tahoe-wk2-lbse-text/svg/hixie/error/011-expected.txt:
* LayoutTests/platform/mac/svg/custom/viewbox-syntax-expected.txt:
* LayoutTests/platform/mac/svg/hixie/error/010-expected.txt:
* LayoutTests/platform/mac/svg/hixie/error/011-expected.txt:
* LayoutTests/platform/win/svg/custom/viewbox-syntax-expected.txt:
* LayoutTests/svg/hixie/error/010-expected.txt:
* LayoutTests/svg/hixie/error/011-expected.txt:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.cpp:
* Source/WebCore/svg/SVGFitToViewBox.cpp:
* Source/WebCore/svg/SVGFitToViewBox.h:
* Source/WebCore/svg/SVGSVGElement.cpp:
* Source/WebCore/svg/SVGSVGElement.h:
* Source/WebCore/svg/SVGViewSpec.cpp:
Canonical link: https://commits.webkit.org/323217@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
