Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 437139e30888c5e1b4c35f889f32e1d0c39d018e
https://github.com/WebKit/WebKit/commit/437139e30888c5e1b4c35f889f32e1d0c39d018e
Author: Jintian Wang <[email protected]>
Date: 2026-10-09 (Fri, 09 Oct 2026)
Changed paths:
A
LayoutTests/interaction-region/guard-container-consolidated-into-ancestor-expected.txt
A
LayoutTests/interaction-region/guard-container-consolidated-into-ancestor.html
M Source/WebCore/rendering/EventRegion.cpp
M Source/WebCore/rendering/EventRegion.h
Log Message:
-----------
Support person button has no gaze glow
https://bugs.webkit.org/show_bug.cgi?id=326098
rdar://188336942
Reviewed by Etienne Segonzac.
The button is a transparent <button> whose only child is an <img>, inside a
clickable circle. As a guard container, the button gets a Guard region that
extends its image's region. The image's region is then consolidated into the
circle's region, so the guard has nothing in its group to light and catches the
gaze.
This change keeps track of the elements whose regions get consolidated. Remove
the Guard of an element whose regions were all consolidated away, so the
circle's region glows.
Test: interaction-region/guard-container-consolidated-into-ancestor.html
*
LayoutTests/interaction-region/guard-container-consolidated-into-ancestor-expected.txt:
Added.
*
LayoutTests/interaction-region/guard-container-consolidated-into-ancestor.html:
Added.
* Source/WebCore/rendering/EventRegion.cpp:
(WebCore::EventRegionContext::uniteInteractionRegions):
(WebCore::EventRegionContext::convertGuardContainersToInteractionIfNeeded):
* Source/WebCore/rendering/EventRegion.h:
Canonical link: https://commits.webkit.org/323284@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
