Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1ded72f138508451e7d054b546ed82e237e040c7
https://github.com/WebKit/WebKit/commit/1ded72f138508451e7d054b546ed82e237e040c7
Author: Ryosuke Niwa <[email protected]>
Date: 2026-10-10 (Sat, 10 Oct 2026)
Changed paths:
M Source/WebCore/Modules/cache/DOMCache.cpp
M Source/WebCore/Modules/filesystem/WorkerFileSystemStorageConnection.cpp
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
M Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
M Source/WebCore/Modules/permissions/Permissions.cpp
M Source/WebCore/Modules/push-api/PushManager.cpp
M Source/WebCore/Modules/storage/WorkerStorageConnection.cpp
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCacheInlines.h
M Source/WebCore/accessibility/AXTableHelpers.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/bindings/js/InternalReadableStreamDefaultReader.cpp
M Source/WebCore/bindings/js/InternalWritableStreamWriter.cpp
M Source/WebCore/bindings/js/JSDOMConvertUnion.h
M Source/WebCore/bindings/js/JSDOMWrapperCache.h
M Source/WebCore/bindings/js/JSDeprecatedCSSOMValueCustom.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmX25519.cpp
M Source/WebCore/css/CSSCursorImageValue.cpp
M Source/WebCore/css/CSSFontFace.cpp
M Source/WebCore/css/CSSPropertyInitialValues.cpp
M Source/WebCore/css/CSSStyleProperties.cpp
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/MutableStyleProperties.cpp
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/StyleSheetContents.cpp
M Source/WebCore/css/query/MediaQueryFeatures.cpp
M Source/WebCore/css/typedom/CSSNumericValue.cpp
M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
M Source/WebCore/css/typedom/DeclaredStylePropertyMap.cpp
M Source/WebCore/css/typedom/InlineStylePropertyMap.cpp
M Source/WebCore/css/values/CSSValueAggregates.h
M Source/WebCore/dom/DataTransfer.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Range.cpp
M Source/WebCore/dom/WindowEventLoop.cpp
M Source/WebCore/editing/ApplyStyleCommand.cpp
M Source/WebCore/editing/CompositeEditCommand.cpp
M Source/WebCore/editing/Editing.cpp
M Source/WebCore/editing/Editing.h
M Source/WebCore/html/HTMLFormElement.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLSelectedContentElement.cpp
M Source/WebCore/html/HTMLSummaryElement.cpp
M Source/WebCore/html/HTMLTextFormControlElement.cpp
M Source/WebCore/html/MediaElementSession.cpp
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/html/canvas/WebGLTransformFeedback.cpp
M Source/WebCore/html/canvas/WebGLTransformFeedback.h
M Source/WebCore/html/track/TextTrackList.cpp
M Source/WebCore/html/track/VTTCue.cpp
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
M Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp
M Source/WebCore/inspector/agents/InspectorDOMStorageAgent.h
M Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp
M Source/WebCore/inspector/agents/frame/FrameCSSAgent.cpp
M Source/WebCore/inspector/agents/page/PageDOMDebuggerAgent.cpp
M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
M Source/WebCore/mathml/MathMLSelectElement.cpp
M Source/WebCore/mathml/MathMLSelectElement.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/ScreenOrientation.cpp
M Source/WebCore/page/scrolling/ScrollLatchingController.cpp
M Source/WebCore/page/scrolling/ScrollingTree.cpp
M Source/WebCore/platform/audio/HRTFPanner.cpp
M Source/WebCore/platform/graphics/GraphicsLayer.cpp
M Source/WebCore/platform/graphics/Path.cpp
M Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/storage/StorageEventDispatcher.cpp
M Source/WebCore/style/StyleInterpolation.cpp
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/computed/data/StyleCustomPropertyData.cpp
M Source/WebCore/style/values/anchor-position/StylePositionTryFallback.cpp
M Source/WebCore/style/values/backgrounds/StyleFillLayers.h
M Source/WebCore/style/values/images/StyleImageWrapper.cpp
M Source/WebCore/style/values/scroll-animations/StyleScrollFunction.cpp
M Source/WebCore/style/values/will-change/StyleWillChange.cpp
M Source/WebCore/workers/service/SWClientConnection.cpp
M Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp
M Source/WebCore/workers/service/context/SWContextManager.cpp
Log Message:
-----------
Fix uncounted local variable warnings in Source/WebCore after 2026-10-06
rollout
https://bugs.webkit.org/show_bug.cgi?id=327125
Reviewed by Anne van Kesteren.
Deployed more smart pointers to fix safer C++ counted local variable warnings.
No new tests since there should be no observable behavior changes.
* Source/WebCore/Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::addAll):
(WebCore::DOMCache::put):
* Source/WebCore/Modules/filesystem/WorkerFileSystemStorageConnection.cpp:
(WebCore::WorkerFileSystemStorageConnection::isSameEntry):
(WebCore::WorkerFileSystemStorageConnection::getFileHandle):
(WebCore::WorkerFileSystemStorageConnection::getDirectoryHandle):
(WebCore::WorkerFileSystemStorageConnection::removeEntry):
(WebCore::WorkerFileSystemStorageConnection::resolve):
(WebCore::WorkerFileSystemStorageConnection::getFile):
(WebCore::WorkerFileSystemStorageConnection::createSyncAccessHandle):
(WebCore::WorkerFileSystemStorageConnection::getHandleNames):
(WebCore::WorkerFileSystemStorageConnection::getHandle):
(WebCore::WorkerFileSystemStorageConnection::move):
(WebCore::WorkerFileSystemStorageConnection::resolveGlobalIdentifier):
* Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperationAfterSpaceCheck):
* Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::allow):
* Source/WebCore/Modules/permissions/Permissions.cpp:
(WebCore::Permissions::query):
* Source/WebCore/Modules/push-api/PushManager.cpp:
(WebCore::PushManager::subscribe):
* Source/WebCore/Modules/storage/WorkerStorageConnection.cpp:
(WebCore::WorkerStorageConnection::getPersisted):
(WebCore::WorkerStorageConnection::getEstimate):
(WebCore::WorkerStorageConnection::fileSystemGetDirectory):
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleChildrenChanged):
(WebCore::AXObjectCache::updateRelationsForTree):
* Source/WebCore/accessibility/AXObjectCacheInlines.h:
(WebCore::AXObjectCache::objectsForIDs const):
* Source/WebCore/accessibility/AXTableHelpers.cpp:
(WebCore::AXTableHelpers::isDataTableWithTraversal):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::createIsolatedObjectData):
* Source/WebCore/bindings/js/InternalReadableStreamDefaultReader.cpp:
(WebCore::InternalReadableStreamDefaultReader::onClosedPromiseRejection):
(WebCore::InternalReadableStreamDefaultReader::onClosedPromiseResolution):
* Source/WebCore/bindings/js/InternalWritableStreamWriter.cpp:
(WebCore::InternalWritableStreamWriter::onClosedPromiseRejection):
(WebCore::InternalWritableStreamWriter::onClosedPromiseResolution):
(WebCore::InternalWritableStreamWriter::whenReady):
* Source/WebCore/bindings/js/JSDOMConvertUnion.h:
* Source/WebCore/bindings/js/JSDOMWrapperCache.h:
(WebCore::createWrapper):
* Source/WebCore/bindings/js/JSDeprecatedCSSOMValueCustom.cpp:
(WebCore::toJSNewlyCreated):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp:
(WebCore::CryptoAlgorithmECDH::deriveBits):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmX25519.cpp:
(WebCore::CryptoAlgorithmX25519::deriveBits):
* Source/WebCore/css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::create):
* Source/WebCore/css/CSSFontFace.cpp:
(WebCore::calculateFontFaceStyleInfo):
* Source/WebCore/css/CSSPropertyInitialValues.cpp:
(WebCore::isInitialValueForLonghand):
* Source/WebCore/css/CSSStyleProperties.cpp:
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::equals const):
* Source/WebCore/css/MutableStyleProperties.cpp:
(WebCore::MutableStyleProperties::MutableStyleProperties):
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serializeBorderRadius const):
(WebCore::ShorthandSerializer::serializeBorderRadiusSide const):
* Source/WebCore/css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::StyleSheetContents::wrapperInsertRule):
* Source/WebCore/css/query/MediaQueryFeatures.cpp:
(WebCore::MQ::Features::aspectRatioFeatureSchema):
* Source/WebCore/css/typedom/CSSNumericValue.cpp:
(WebCore::negate):
(WebCore::invert):
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::reifyValue):
* Source/WebCore/css/typedom/DeclaredStylePropertyMap.cpp:
(WebCore::DeclaredStylePropertyMap::entries const):
* Source/WebCore/css/typedom/InlineStylePropertyMap.cpp:
(WebCore::InlineStylePropertyMap::entries const):
* Source/WebCore/css/values/CSSValueAggregates.h:
(WebCore::SpaceSeparatedEnumSet::map):
* Source/WebCore/dom/DataTransfer.cpp:
(WebCore::DataTransfer::setDragImage):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::matchingAnimations):
* Source/WebCore/dom/Range.cpp:
(WebCore::processContentsBetweenOffsets):
* Source/WebCore/dom/WindowEventLoop.cpp:
(WebCore::WindowEventLoop::removeMutationObserversForContext):
* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeConflictingInlineStyleFromRun):
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::applyCommandToComposite):
* Source/WebCore/editing/Editing.cpp:
(WebCore::enclosingElementWithTag):
* Source/WebCore/editing/Editing.h:
* Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::copyListedElementsVector const):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::playbackControlsManagerBehaviorRestrictionsTimerFired):
* Source/WebCore/html/HTMLSelectedContentElement.cpp:
(WebCore::HTMLSelectedContentElement::recalculateDisabledness):
* Source/WebCore/html/HTMLSummaryElement.cpp:
(WebCore::isInSummaryInteractiveContent):
* Source/WebCore/html/HTMLTextFormControlElement.cpp:
(WebCore::positionForIndex):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks const):
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const):
* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getIndexedParameter):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::readPixels):
* Source/WebCore/html/canvas/WebGLTransformFeedback.cpp:
(WebCore::WebGLTransformFeedback::getBoundIndexedTransformFeedbackBuffer):
* Source/WebCore/html/canvas/WebGLTransformFeedback.h:
* Source/WebCore/html/track/TextTrackList.cpp:
(WebCore::TextTrackList::append):
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::markFutureAndPastNodes):
* Source/WebCore/inspector/InspectorOverlay.cpp:
(WebCore::authoredGridTrackSizes):
* Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::createInspectorStyleSheetForDocument):
* Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::clearDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::findStorageArea):
* Source/WebCore/inspector/agents/InspectorDOMStorageAgent.h:
* Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:
(WebCore::getDocumentAndIDBFactoryFromFrameOrSendFailure):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
(WebCore::InspectorIndexedDBAgent::clearObjectStore):
* Source/WebCore/inspector/agents/frame/FrameCSSAgent.cpp:
(WebCore::FrameCSSAgent::createInspectorStyleSheetForDocument):
* Source/WebCore/inspector/agents/page/PageDOMDebuggerAgent.cpp:
(WebCore::PageDOMDebuggerAgent::willInsertDOMNode):
(WebCore::PageDOMDebuggerAgent::willRemoveDOMNode):
* Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* Source/WebCore/mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedActionChildAndIndex):
(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::toggle):
* Source/WebCore/mathml/MathMLSelectElement.h:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::getElementOrAncestorElementForNode):
* Source/WebCore/page/ScreenOrientation.cpp:
(WebCore::ScreenOrientation::lock):
* Source/WebCore/page/scrolling/ScrollLatchingController.cpp:
(WebCore::ScrollLatchingController::removeLatchingStateForTarget):
* Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::removeFromActiveNodes):
* Source/WebCore/platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::pan):
* Source/WebCore/platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::replaceChild):
* Source/WebCore/platform/graphics/Path.cpp:
(WebCore::Path::setImpl):
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
(WebCore::PlatformCAFilters::setFiltersOnLayer):
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateChildrenTransformAndAnchorPoint):
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::scrollTo):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteTextRects):
(WebCore::borderAndTextRects):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::capitalize):
* Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRebuildRoots):
* Source/WebCore/storage/StorageEventDispatcher.cpp:
(WebCore::dispatchStorageEvents):
* Source/WebCore/style/StyleInterpolation.cpp:
(WebCore::Style::Interpolation::customPropertyValuesForInterpolation):
(): Deleted.
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::generatePositionOption):
* Source/WebCore/style/computed/data/StyleCustomPropertyData.cpp:
(WebCore::Style::CustomPropertyData::operator== const):
* Source/WebCore/style/values/anchor-position/StylePositionTryFallback.cpp:
(WebCore::Style::computedPositionAreaValue):
* Source/WebCore/style/values/backgrounds/StyleFillLayers.h:
(WebCore::Style::hasHDRContent):
* Source/WebCore/style/values/images/StyleImageWrapper.cpp:
(WebCore::Style::Blending<ImageWrapper>::blend):
* Source/WebCore/style/values/scroll-animations/StyleScrollFunction.cpp:
(WebCore::Style::CSSValueConversion<ScrollFunction>::operator):
* Source/WebCore/style/values/will-change/StyleWillChange.cpp:
(WebCore::Style::CSSValueConversion<WillChange>::operator):
* Source/WebCore/workers/service/SWClientConnection.cpp:
(WebCore::SWClientConnection::clearPendingJobs):
* Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp:
(WebCore::ServiceWorkerWindowClient::focus):
(WebCore::ServiceWorkerWindowClient::navigate):
* Source/WebCore/workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::registerServiceWorkerThreadForInstall):
(WebCore::SWContextManager::updateRegistrationState):
(WebCore::SWContextManager::updateWorkerState):
(WebCore::SWContextManager::fireUpdateFoundEvent):
(WebCore::SWContextManager::setRegistrationLastUpdateTime):
(WebCore::SWContextManager::setRegistrationUpdateViaCache):
Canonical link: https://commits.webkit.org/323374@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
