Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0067ec3e7b9bdd8a2e4b5ae2eb288ac1e3b9c1b0
https://github.com/WebKit/WebKit/commit/0067ec3e7b9bdd8a2e4b5ae2eb288ac1e3b9c1b0
Author: Chris Dumez <[email protected]>
Date: 2026-10-11 (Sun, 11 Oct 2026)
Changed paths:
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCObservers.h
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M Source/WebCore/bridge/objc/WebScriptObject.h
M Source/WebCore/bridge/objc/WebScriptObject.mm
M Source/WebCore/bridge/objc/WebScriptObjectPrivate.h
M Source/WebCore/page/IntersectionObserver.cpp
M Source/WebCore/workers/WorkerOrWorkletScriptController.h
M Source/WebCore/workers/WorkerOrWorkletThread.cpp
M Source/WebGPU/SaferCPPExpectations/ForwardDeclCheckerExpectations
M Source/WebGPU/SaferCPPExpectations/NoDeleteCheckerExpectations
M Source/WebGPU/WGSL/AST/ASTBinaryExpression.cpp
M Source/WebGPU/WGSL/AST/ASTDecrementIncrementStatement.cpp
M Source/WebGPU/WGSL/AST/ASTStringDumper.h
M Source/WebGPU/WGSL/AST/ASTUnaryExpression.cpp
M Source/WebGPU/WGSL/CallGraph.h
M Source/WebGPU/WGSL/ConstantValue.cpp
M Source/WebGPU/WGSL/ConstantValue.h
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/Types.h
M Source/WebGPU/WGSL/WGSL.h
M Source/WebKitLegacy/WebKitLegacy-iOS.exp
M Source/WebKitLegacy/mac/DOM/DOMInternal.mm
M Source/WebKitLegacy/mac/WebKit.mac.exp
Log Message:
-----------
Address Safer C++ static analysis warnings in WebCore/bridge, WebCore/page,
WebCore/workers, WebCore/Modules/mediastream and WGSL
https://bugs.webkit.org/show_bug.cgi?id=326775
Reviewed by Ryosuke Niwa.
Fix Safer C++ warnings in WebCore/bridge, WebCore/page, WebCore/workers,
WebCore/Modules/mediastream and WebGPU/WGSL, and update the expectations
accordingly.
LibWebRTCMediaEndpoint can now make thread-safe CheckedPtrs, so the session
description observers hold their owning endpoint via a const CheckedRef.
WorkerOrWorkletScriptController now uses CanMakeThreadSafeCheckedPtr since
WorkerOrWorkletThread::stop() accesses it from the main thread.
WebScriptObject's _private ivar moves out of the public header into a class
extension as a RetainPtr. It stays @public because WebKitLegacy accesses it.
In WGSL, convertValueImpl() moves to ConstantValue.cpp so ConstantValue.h no
longer includes Types.h. This breaks an include cycle, letting Types.h and
WGSL.h include the AST headers they need instead of forward declaring.
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCObservers.h:
* Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* Source/WebCore/Scripts/QuirkBehaviorsTemplates/QuirksAccessors.h.erb:
* Source/WebCore/bridge/objc/WebScriptObject.h:
* Source/WebCore/bridge/objc/WebScriptObject.mm:
(-[WebScriptObject _initWithJSObject:originRootObject:rootObject:]):
(-[WebScriptObject dealloc]):
* Source/WebCore/bridge/objc/WebScriptObjectPrivate.h:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::isElementAnAncestorOfLastElementUnderMouse const):
* Source/WebCore/page/EventHandler.h:
* Source/WebCore/page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::isReachableFromOpaqueRoots const):
* Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
* Source/WebCore/workers/WorkerOrWorkletScriptController.h:
* Source/WebCore/workers/WorkerOrWorkletThread.cpp:
(WebCore::WorkerOrWorkletThread::stop):
* Source/WebGPU/SaferCPPExpectations/ForwardDeclCheckerExpectations:
* Source/WebGPU/SaferCPPExpectations/NoDeleteCheckerExpectations:
* Source/WebGPU/WGSL/AST/ASTBinaryExpression.cpp:
* Source/WebGPU/WGSL/AST/ASTDecrementIncrementStatement.cpp:
* Source/WebGPU/WGSL/AST/ASTStringDumper.h:
* Source/WebGPU/WGSL/AST/ASTUnaryExpression.cpp:
* Source/WebGPU/WGSL/CallGraph.h:
* Source/WebGPU/WGSL/ConstantValue.cpp:
(WGSL::convertValueImpl):
* Source/WebGPU/WGSL/ConstantValue.h:
(WGSL::convertValueImpl): Deleted.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::declareForwardProgress const):
(WGSL::Metal::FunctionDefinitionWriter::checkForwardProgress const):
* Source/WebGPU/WGSL/Types.h:
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebPage::didStartDrag):
* Source/WebKitLegacy/mac/DOM/DOMInternal.mm:
(-[WebScriptObject _init]):
Canonical link: https://commits.webkit.org/323379@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
