Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ef3315171cbf73c0ff5db0b7cf10f166bd915230
https://github.com/WebKit/WebKit/commit/ef3315171cbf73c0ff5db0b7cf10f166bd915230
Author: Etienne Segonzac <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
A
LayoutTests/model-element/volumetric/volumetric-scene-portal-bfcache-expected.txt
A LayoutTests/model-element/volumetric/volumetric-scene-portal-bfcache.html
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
[visionOS] While CVS is opened, going through the bfcache can leave a portal
empty
https://bugs.webkit.org/show_bug.cgi?id=327250
<rdar://188346652>
Reviewed by Mike Wyrzykowski.
When navigating away while a Connected Volumetric Scene was opened,
`dismissVolumetricScenesForDetachedElements` never signaled the element,
causing it to be "stuck" in a volumetric state (without a window) once
restored from the bfcache.
This method now goes through `volumetricSceneDidClose`, which properly
checks the weak pointer when using `m_volumetricSceneElements` already.
So when the element is kept alive by the bfcache its state is properly
updated.
Test: model-element/volumetric/volumetric-scene-portal-bfcache.html
*
LayoutTests/model-element/volumetric/volumetric-scene-portal-bfcache-expected.txt:
Added.
* LayoutTests/model-element/volumetric/volumetric-scene-portal-bfcache.html:
Added.
Add a new bfcache test modeled after the existing Spatial Portal one.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dismissVolumetricScenesForDetachedElements):
Continue sending the IPC message but tentatively go through
`volumetricSceneDidClose` to update the element's state.
Canonical link: https://commits.webkit.org/323493@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
