Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 44dcf77e60b21c017e1be0a9e4a1e52e7b44b0d0
https://github.com/WebKit/WebKit/commit/44dcf77e60b21c017e1be0a9e4a1e52e7b44b0d0
Author: Zak Ridouh <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/breakpoints-in-new-cross-origin-iframe-expected.txt
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/breakpoints-in-new-cross-origin-iframe.html
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/dom-debugger-frame-target-expected.txt
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/dom-debugger-frame-target.html
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/event-breakpoints-cross-origin-iframe-expected.txt
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/event-breakpoints-cross-origin-iframe.html
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/resources/dom-debugger-data.json
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/resources/dom-debugger-frame.html
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/resources/dom-debugger-test-utilities.js
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/same-process-single-pause-expected.txt
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/same-process-single-pause.html
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/timer-and-animation-frame-breakpoints-cross-origin-iframe-expected.txt
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/timer-and-animation-frame-breakpoints-cross-origin-iframe.html
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/url-breakpoints-cross-origin-iframe-expected.txt
A
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/url-breakpoints-cross-origin-iframe.html
M Source/JavaScriptCore/inspector/protocol/DOMDebugger.json
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/inspector/FrameInspectorController.cpp
A Source/WebCore/inspector/agents/frame/FrameDOMDebuggerAgent.cpp
A Source/WebCore/inspector/agents/frame/FrameDOMDebuggerAgent.h
M Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js
Log Message:
-----------
[Site Isolation] Web Inspector: Support event and URL breakpoints in
cross-origin iframes
https://bugs.webkit.org/show_bug.cgi?id=316795
rdar://143597151
Reviewed by Qianlang Chen.
Frame targets had no DOMDebugger agent, so event listener, timer, animation
frame, and URL
breakpoints never paused in cross-origin iframes.
Add FrameDOMDebuggerAgent, created alongside the frame's FrameDebuggerAgent. It
fills the DOMDebugger
slot of the frame's InstrumentingAgents, which these hooks already read, so it
takes over from the
page agent and each breakpoint pauses once. DOM breakpoints stay on the page
target for now.
Tests:
http/tests/site-isolation/inspector/dom-debugger/breakpoints-in-new-cross-origin-iframe.html
http/tests/site-isolation/inspector/dom-debugger/dom-debugger-frame-target.html
http/tests/site-isolation/inspector/dom-debugger/event-breakpoints-cross-origin-iframe.html
http/tests/site-isolation/inspector/dom-debugger/same-process-single-pause.html
http/tests/site-isolation/inspector/dom-debugger/timer-and-animation-frame-breakpoints-cross-origin-iframe.html
http/tests/site-isolation/inspector/dom-debugger/url-breakpoints-cross-origin-iframe.html
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/breakpoints-in-new-cross-origin-iframe-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/breakpoints-in-new-cross-origin-iframe.html:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/dom-debugger-frame-target-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/dom-debugger-frame-target.html:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/event-breakpoints-cross-origin-iframe-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/event-breakpoints-cross-origin-iframe.html:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/resources/dom-debugger-data.json:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/resources/dom-debugger-frame.html:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/resources/dom-debugger-test-utilities.js:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/same-process-single-pause-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/same-process-single-pause.html:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/timer-and-animation-frame-breakpoints-cross-origin-iframe-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/timer-and-animation-frame-breakpoints-cross-origin-iframe.html:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/url-breakpoints-cross-origin-iframe-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom-debugger/url-breakpoints-cross-origin-iframe.html:
Added.
* Source/JavaScriptCore/inspector/protocol/DOMDebugger.json:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/inspector/FrameInspectorController.cpp:
(WebCore::FrameInspectorController::createLazyAgents):
* Source/WebCore/inspector/agents/frame/FrameDOMDebuggerAgent.cpp: Added.
* Source/WebCore/inspector/agents/frame/FrameDOMDebuggerAgent.h: Added.
* Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:
(WI.DOMDebuggerManager.prototype._setDOMBreakpoint):
(WI.DOMDebuggerManager.prototype._removeDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.*#allSupportedTargets):
Canonical link: https://commits.webkit.org/323499@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
