Title: [116415] trunk/Tools
Revision
116415
Author
[email protected]
Date
2012-05-08 06:39:50 -0700 (Tue, 08 May 2012)

Log Message

[webkit-patch] Return meaningful results from single-result queries.
https://bugs.webkit.org/show_bug.cgi?id=85367

Reviewed by Dirk Pranke.

Sometimes a quicksearch returns a single result by just redirecting to the page for that single
bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
a result list consisting of that one bug.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries._fetch_bugs_from_advanced_query):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (116414 => 116415)


--- trunk/Tools/ChangeLog	2012-05-08 13:37:25 UTC (rev 116414)
+++ trunk/Tools/ChangeLog	2012-05-08 13:39:50 UTC (rev 116415)
@@ -1,5 +1,19 @@
 2012-05-08  Gavin Peters  <[email protected]>
 
+        [webkit-patch] Return meaningful results from single-result queries.
+        https://bugs.webkit.org/show_bug.cgi?id=85367
+
+        Reviewed by Dirk Pranke.
+
+        Sometimes a quicksearch returns a single result by just redirecting to the page for that single
+        bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
+        a result list consisting of that one bug.
+
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+        (BugzillaQueries._fetch_bugs_from_advanced_query):
+
+2012-05-08  Gavin Peters  <[email protected]>
+
         [webkit-patch] Add new chrome-channels command to track down current chrome release channels for a committed bug.
         https://bugs.webkit.org/show_bug.cgi?id=85368
 

Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (116414 => 116415)


--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2012-05-08 13:37:25 UTC (rev 116414)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2012-05-08 13:39:50 UTC (rev 116415)
@@ -152,6 +152,11 @@
 
     def _fetch_bugs_from_advanced_query(self, query):
         results_page = self._load_query(query)
+        # Some simple searches can return a single result.
+        results_url = results_page.geturl()
+        if results_url.find("/show_bug.cgi?id=") != -1:
+            bug_id = int(results_url.split("=")[-1])
+            return [self._fetch_bug(bug_id)]
         if not self._parse_result_count(results_page):
             return []
         # Bugzilla results pages have an "XML" submit button at the bottom
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to