Diff
Modified: trunk/LayoutTests/ChangeLog (116415 => 116416)
--- trunk/LayoutTests/ChangeLog 2012-05-08 13:39:50 UTC (rev 116415)
+++ trunk/LayoutTests/ChangeLog 2012-05-08 13:57:20 UTC (rev 116416)
@@ -1,3 +1,15 @@
+2012-05-08 Christophe Dumez <[email protected]>
+
+ [EFL][DRT] EFL's DRT does not fully support page visibility
+ https://bugs.webkit.org/show_bug.cgi?id=85032
+
+ Reviewed by Antonio Gomes.
+
+ Unskip remaining page visibility test cases now that the functionality
+ is fully implemented in EFL port.
+
+ * platform/efl/Skipped:
+
2012-05-08 Csaba Osztrogonác <[email protected]>
Unreviewed. Remove an accidentally committed file.
Modified: trunk/LayoutTests/platform/efl/Skipped (116415 => 116416)
--- trunk/LayoutTests/platform/efl/Skipped 2012-05-08 13:39:50 UTC (rev 116415)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-05-08 13:57:20 UTC (rev 116416)
@@ -1920,11 +1920,6 @@
http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
http/tests/xmlviewer/extensions-api.html
-# EFL DRT doesn't fully support page visibility feature yet.
-fast/events/page-visibility-iframe-move-test.html
-fast/events/page-visibility-iframe-delete-test.html
-fast/events/page-visibility-iframe-propagation-test.html
-
# These test -apple- and -khtml- prefixed CSS properties, which we don't support.
inspector/styles/vendor-prefixes.html
Modified: trunk/Tools/ChangeLog (116415 => 116416)
--- trunk/Tools/ChangeLog 2012-05-08 13:39:50 UTC (rev 116415)
+++ trunk/Tools/ChangeLog 2012-05-08 13:57:20 UTC (rev 116416)
@@ -1,3 +1,19 @@
+2012-05-08 Christophe Dumez <[email protected]>
+
+ [EFL][DRT] EFL's DRT does not fully support page visibility
+ https://bugs.webkit.org/show_bug.cgi?id=85032
+
+ Reviewed by Antonio Gomes.
+
+ * DumpRenderTree/LayoutTestController.cpp:
+ (resetPageVisibilityCallback): Fix incorrect argumentCount check.
+ * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+ (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Properly
+ reset page visibility setting between tests.
+ * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+ (LayoutTestController::setPageVisibility): Add support for "preview"
+ visibility state.
+
2012-05-08 Gavin Peters <[email protected]>
[webkit-patch] Return meaningful results from single-result queries.
Modified: trunk/Tools/DumpRenderTree/LayoutTestController.cpp (116415 => 116416)
--- trunk/Tools/DumpRenderTree/LayoutTestController.cpp 2012-05-08 13:39:50 UTC (rev 116415)
+++ trunk/Tools/DumpRenderTree/LayoutTestController.cpp 2012-05-08 13:57:20 UTC (rev 116416)
@@ -1717,10 +1717,6 @@
static JSValueRef resetPageVisibilityCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
{
- // Has mac & windows implementation
- if (argumentCount < 1)
- return JSValueMakeUndefined(context);
-
LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject));
controller->resetPageVisibility();
return JSValueMakeUndefined(context);
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (116415 => 116416)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-08 13:39:50 UTC (rev 116415)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-08 13:57:20 UTC (rev 116416)
@@ -241,6 +241,7 @@
ewk_view_zoom_set(mainView(), 1.0, 0, 0);
ewk_view_scale_set(mainView(), 1.0, 0, 0);
ewk_view_text_zoom_set(mainView(), 1.0);
+ ewk_view_visibility_state_set(mainView(), EWK_PAGE_VISIBILITY_STATE_VISIBLE, true);
ewk_history_clear(ewk_view_history_get(mainView()));
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (116415 => 116416)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-05-08 13:39:50 UTC (rev 116415)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-05-08 13:57:20 UTC (rev 116416)
@@ -856,4 +856,6 @@
ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_HIDDEN, false);
else if (newVisibility == "prerender")
ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_PRERENDER, false);
+ else if (newVisibility == "preview")
+ ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_PREVIEW, false);
}
