Diff
Modified: trunk/Source/WebCore/ChangeLog (118132 => 118133)
--- trunk/Source/WebCore/ChangeLog 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/ChangeLog 2012-05-23 07:06:11 UTC (rev 118133)
@@ -1,3 +1,70 @@
+2012-05-23 Kentaro Hara <[email protected]>
+
+ [V8] Pass Isolate to v8::Null() in custom bindings (Part 1)
+ https://bugs.webkit.org/show_bug.cgi?id=87207
+
+ Reviewed by Adam Barth.
+
+ The objective is to pass Isolate around in V8 bindings.
+ This patch passes Isolate to v8::Null() in custom bindings.
+
+ Also this patch makes V8DeviceMotionEventCustom::createAccelerationObject()
+ and V8DeviceMotionEventCustom::createRotationRateObject() static.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/custom/V8BlobCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8CSSRuleCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8CSSValueCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8ClipboardCustom.cpp:
+ (WebCore::V8Clipboard::typesAccessorGetter):
+ * bindings/v8/custom/V8CoordinatesCustom.cpp:
+ (WebCore::V8Coordinates::altitudeAccessorGetter):
+ (WebCore::V8Coordinates::altitudeAccuracyAccessorGetter):
+ (WebCore::V8Coordinates::headingAccessorGetter):
+ (WebCore::V8Coordinates::speedAccessorGetter):
+ * bindings/v8/custom/V8DOMStringMapCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DOMTokenListCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DataViewCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
+ (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter):
+ (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter):
+ (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter):
+ (WebCore::V8DeviceMotionEvent::intervalAccessorGetter):
+ * bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
+ (WebCore::V8DeviceOrientationEvent::alphaAccessorGetter):
+ (WebCore::V8DeviceOrientationEvent::betaAccessorGetter):
+ (WebCore::V8DeviceOrientationEvent::gammaAccessorGetter):
+ (WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
+ * bindings/v8/custom/V8DocumentCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8DocumentLocationCustom.cpp:
+ (WebCore::V8Document::locationAccessorGetter):
+ * bindings/v8/custom/V8EntryCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8EntrySyncCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8EventCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Float32ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Float64ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
+ (WebCore::V8HTMLCanvasElement::getContextCallback):
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+ (WebCore::toV8):
+
2012-05-22 MORITA Hajime <[email protected]>
[Refactoring] ElementShadow::m_needsRedistributing should be on ContentDistributor
Modified: trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -47,7 +47,7 @@
v8::Handle<v8::Value> toV8(Blob* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
if (impl->isFile())
return toV8(static_cast<File*>(impl), isolate);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8CSSRuleCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8CSSRuleCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CSSRuleCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -46,7 +46,7 @@
v8::Handle<v8::Value> toV8(CSSRule* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
switch (impl->type()) {
case CSSRule::UNKNOWN_RULE:
// CSSUnknownRule.idl is explicitly excluded as it doesn't add anything
Modified: trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleSheetCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleSheetCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleSheetCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -39,7 +39,7 @@
v8::Handle<v8::Value> toV8(CSSStyleSheet* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8CSSStyleSheet::wrap(impl, isolate);
// Add a hidden reference from stylesheet object to its owner node.
Node* ownerNode = impl->ownerNode();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8CSSValueCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8CSSValueCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CSSValueCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -45,7 +45,7 @@
v8::Handle<v8::Value> toV8(CSSValue* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
if (impl->isWebKitCSSTransformValue())
return toV8(static_cast<WebKitCSSTransformValue*>(impl), isolate);
if (impl->isValueList())
Modified: trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -51,7 +51,7 @@
HashSet<String> types = clipboard->types();
if (types.isEmpty())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
v8::Local<v8::Array> result = v8::Array::New(types.size());
HashSet<String>::const_iterator end = types.end();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8CoordinatesCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8CoordinatesCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CoordinatesCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -38,7 +38,7 @@
v8::Handle<v8::Object> holder = info.Holder();
Coordinates* imp = V8Coordinates::toNative(holder);
if (!imp->canProvideAltitude())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
return v8::Number::New(imp->altitude());
}
@@ -48,7 +48,7 @@
v8::Handle<v8::Object> holder = info.Holder();
Coordinates* imp = V8Coordinates::toNative(holder);
if (!imp->canProvideAltitudeAccuracy())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
return v8::Number::New(imp->altitudeAccuracy());
}
@@ -58,7 +58,7 @@
v8::Handle<v8::Object> holder = info.Holder();
Coordinates* imp = V8Coordinates::toNative(holder);
if (!imp->canProvideHeading())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
return v8::Number::New(imp->heading());
}
@@ -68,7 +68,7 @@
v8::Handle<v8::Object> holder = info.Holder();
Coordinates* imp = V8Coordinates::toNative(holder);
if (!imp->canProvideSpeed())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
return v8::Number::New(imp->speed());
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -87,7 +87,7 @@
v8::Handle<v8::Value> toV8(DOMStringMap* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8DOMStringMap::wrap(impl, isolate);
// Add a hidden reference from the element to the DOMStringMap.
Element* element = impl->element();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMTokenListCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMTokenListCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMTokenListCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -41,7 +41,7 @@
v8::Handle<v8::Value> toV8(DOMTokenList* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8DOMTokenList::wrap(impl, isolate);
// Add a hidden reference from the element to the DOMTokenList.
Element* element = impl->element();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -603,7 +603,7 @@
v8::Handle<v8::Value> toV8(DOMWindow* window, v8::Isolate* isolate)
{
if (!window)
- return v8::Null();
+ return v8::Null(isolate);
// Initializes environment of a frame, and return the global object
// of the frame.
Frame* frame = window->frame();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -60,7 +60,7 @@
v8::Handle<v8::Value> toV8(DataView* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
return V8DataView::wrap(impl, isolate);
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DeviceMotionEventCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8DeviceMotionEventCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DeviceMotionEventCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -39,21 +39,21 @@
namespace {
-v8::Handle<v8::Value> createAccelerationObject(const DeviceMotionData::Acceleration* acceleration)
+static v8::Handle<v8::Value> createAccelerationObject(const DeviceMotionData::Acceleration* acceleration, v8::Isolate* isolate)
{
v8::Local<v8::Object> object = v8::Object::New();
- object->Set(v8::String::New("x"), acceleration->canProvideX() ? v8::Number::New(acceleration->x()) : v8::Null());
- object->Set(v8::String::New("y"), acceleration->canProvideY() ? v8::Number::New(acceleration->y()) : v8::Null());
- object->Set(v8::String::New("z"), acceleration->canProvideZ() ? v8::Number::New(acceleration->z()) : v8::Null());
+ object->Set(v8::String::New("x"), acceleration->canProvideX() ? v8::Number::New(acceleration->x()) : v8::Null(isolate));
+ object->Set(v8::String::New("y"), acceleration->canProvideY() ? v8::Number::New(acceleration->y()) : v8::Null(isolate));
+ object->Set(v8::String::New("z"), acceleration->canProvideZ() ? v8::Number::New(acceleration->z()) : v8::Null(isolate));
return object;
}
-v8::Handle<v8::Value> createRotationRateObject(const DeviceMotionData::RotationRate* rotationRate)
+static v8::Handle<v8::Value> createRotationRateObject(const DeviceMotionData::RotationRate* rotationRate, v8::Isolate* isolate)
{
v8::Local<v8::Object> object = v8::Object::New();
- object->Set(v8::String::New("alpha"), rotationRate->canProvideAlpha() ? v8::Number::New(rotationRate->alpha()) : v8::Null());
- object->Set(v8::String::New("beta"), rotationRate->canProvideBeta() ? v8::Number::New(rotationRate->beta()) : v8::Null());
- object->Set(v8::String::New("gamma"), rotationRate->canProvideGamma() ? v8::Number::New(rotationRate->gamma()) : v8::Null());
+ object->Set(v8::String::New("alpha"), rotationRate->canProvideAlpha() ? v8::Number::New(rotationRate->alpha()) : v8::Null(isolate));
+ object->Set(v8::String::New("beta"), rotationRate->canProvideBeta() ? v8::Number::New(rotationRate->beta()) : v8::Null(isolate));
+ object->Set(v8::String::New("gamma"), rotationRate->canProvideGamma() ? v8::Number::New(rotationRate->gamma()) : v8::Null(isolate));
return object;
}
@@ -129,8 +129,8 @@
v8::Handle<v8::Object> holder = info.Holder();
DeviceMotionEvent* imp = V8DeviceMotionEvent::toNative(holder);
if (!imp->deviceMotionData()->acceleration())
- return v8::Null();
- return createAccelerationObject(imp->deviceMotionData()->acceleration());
+ return v8::Null(info.GetIsolate());
+ return createAccelerationObject(imp->deviceMotionData()->acceleration(), info.GetIsolate());
}
v8::Handle<v8::Value> V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
@@ -139,8 +139,8 @@
v8::Handle<v8::Object> holder = info.Holder();
DeviceMotionEvent* imp = V8DeviceMotionEvent::toNative(holder);
if (!imp->deviceMotionData()->accelerationIncludingGravity())
- return v8::Null();
- return createAccelerationObject(imp->deviceMotionData()->accelerationIncludingGravity());
+ return v8::Null(info.GetIsolate());
+ return createAccelerationObject(imp->deviceMotionData()->accelerationIncludingGravity(), info.GetIsolate());
}
v8::Handle<v8::Value> V8DeviceMotionEvent::rotationRateAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
@@ -149,8 +149,8 @@
v8::Handle<v8::Object> holder = info.Holder();
DeviceMotionEvent* imp = V8DeviceMotionEvent::toNative(holder);
if (!imp->deviceMotionData()->rotationRate())
- return v8::Null();
- return createRotationRateObject(imp->deviceMotionData()->rotationRate());
+ return v8::Null(info.GetIsolate());
+ return createRotationRateObject(imp->deviceMotionData()->rotationRate(), info.GetIsolate());
}
v8::Handle<v8::Value> V8DeviceMotionEvent::intervalAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
@@ -159,7 +159,7 @@
v8::Handle<v8::Object> holder = info.Holder();
DeviceMotionEvent* imp = V8DeviceMotionEvent::toNative(holder);
if (!imp->deviceMotionData()->canProvideInterval())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
return v8::Number::New(imp->deviceMotionData()->interval());
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -43,7 +43,7 @@
v8::Handle<v8::Object> holder = info.Holder();
DeviceOrientationEvent* imp = V8DeviceOrientationEvent::toNative(holder);
if (!imp->orientation()->canProvideAlpha())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
return v8::Number::New(imp->orientation()->alpha());
}
@@ -53,7 +53,7 @@
v8::Handle<v8::Object> holder = info.Holder();
DeviceOrientationEvent* imp = V8DeviceOrientationEvent::toNative(holder);
if (!imp->orientation()->canProvideBeta())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
return v8::Number::New(imp->orientation()->beta());
}
@@ -63,7 +63,7 @@
v8::Handle<v8::Object> holder = info.Holder();
DeviceOrientationEvent* imp = V8DeviceOrientationEvent::toNative(holder);
if (!imp->orientation()->canProvideGamma())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
return v8::Number::New(imp->orientation()->gamma());
}
@@ -73,7 +73,7 @@
v8::Handle<v8::Object> holder = info.Holder();
DeviceOrientationEvent* imp = V8DeviceOrientationEvent::toNative(holder);
if (!imp->orientation()->canProvideAbsolute())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
return v8::Boolean::New(imp->orientation()->absolute());
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -119,7 +119,7 @@
v8::Handle<v8::Value> toV8(Document* impl, v8::Isolate* isolate, bool forceNewObject)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
if (impl->isHTMLDocument())
return toV8(static_cast<HTMLDocument*>(impl), isolate, forceNewObject);
#if ENABLE(SVG)
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DocumentLocationCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8DocumentLocationCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DocumentLocationCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -38,7 +38,7 @@
{
Document* document = V8Document::toNative(info.Holder());
if (!document->frame())
- return v8::Null();
+ return v8::Null(info.GetIsolate());
DOMWindow* window = document->frame()->domWindow();
return toV8(window->location(), info.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EntryCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8EntryCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EntryCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -47,7 +47,7 @@
v8::Handle<v8::Value> toV8(Entry* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
if (impl->isFile())
return toV8(static_cast<FileEntry*>(impl), isolate);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EntrySyncCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8EntrySyncCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EntrySyncCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -47,7 +47,7 @@
v8::Handle<v8::Value> toV8(EntrySync* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
if (impl->isFile())
return toV8(static_cast<FileEntrySync*>(impl), isolate);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -76,7 +76,7 @@
v8::Handle<v8::Value> toV8(Event* event, v8::Isolate *isolate)
{
if (!event)
- return v8::Null();
+ return v8::Null(isolate);
String desiredInterface = event->interfaceName();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Float32ArrayCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8Float32ArrayCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Float32ArrayCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -57,7 +57,7 @@
v8::Handle<v8::Value> toV8(Float32Array* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8Float32Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalFloatArray, impl->length());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Float64ArrayCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8Float64ArrayCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Float64ArrayCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -52,7 +52,7 @@
v8::Handle<v8::Value> toV8(Float64Array* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8Float64Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalDoubleArray, impl->length());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -84,7 +84,7 @@
#endif
CanvasRenderingContext* result = imp->getContext(contextId, attrs.get());
if (!result)
- return v8::Null();
+ return v8::Null(args.GetIsolate());
if (result->is2d())
return toV8(static_cast<CanvasRenderingContext2D*>(result), args.GetIsolate());
#if ENABLE(WEBGL)
@@ -92,7 +92,7 @@
return toV8(static_cast<WebGLRenderingContext*>(result), args.GetIsolate());
#endif
ASSERT_NOT_REACHED();
- return v8::Null();
+ return v8::Null(args.GetIsolate());
}
v8::Handle<v8::Value> V8HTMLCanvasElement::toDataURLCallback(const v8::Arguments& args)
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp (118132 => 118133)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp 2012-05-23 06:59:28 UTC (rev 118132)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
@@ -187,7 +187,7 @@
v8::Handle<v8::Value> toV8(HTMLDocument* impl, v8::Isolate* isolate, bool forceNewObject)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8HTMLDocument::wrap(impl, isolate, forceNewObject);
if (wrapper.IsEmpty())
return wrapper;
