Diff
Modified: trunk/Source/WebCore/ChangeLog (118133 => 118134)
--- trunk/Source/WebCore/ChangeLog 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/ChangeLog 2012-05-23 07:11:23 UTC (rev 118134)
@@ -1,5 +1,79 @@
2012-05-23 Kentaro Hara <[email protected]>
+ [V8] Pass Isolate to v8::Null() in custom bindings (Part 2)
+ https://bugs.webkit.org/show_bug.cgi?id=87209
+
+ Reviewed by Adam Barth.
+
+ The objective is to pass Isolate around in V8 bindings.
+ This patch passes Isolate to v8::Null() in custom bindings.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/custom/V8HTMLElementCustom.cpp:
+ (WebCore::toV8Object):
+ (WebCore::toV8):
+ * bindings/v8/custom/V8HistoryCustom.cpp:
+ (WebCore::V8History::stateAccessorGetter):
+ * bindings/v8/custom/V8IDBAnyCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8IDBKeyCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8ImageDataCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Int16ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Int32ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Int8ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8LocationCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8MessageEventCustom.cpp:
+ (WebCore::V8MessageEvent::dataAccessorGetter):
+ * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8NodeCustom.cpp:
+ (WebCore::V8Node::insertBeforeCallback):
+ (WebCore::V8Node::replaceChildCallback):
+ (WebCore::V8Node::removeChildCallback):
+ (WebCore::V8Node::appendChildCallback):
+ (WebCore::toV8Slow):
+ * bindings/v8/custom/V8PopStateEventCustom.cpp:
+ (WebCore::V8PopStateEvent::stateAccessorGetter):
+ * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
+ (WebCore::V8SQLResultSetRowList::itemCallback):
+ * bindings/v8/custom/V8SVGDocumentCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8SVGElementCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8SVGPathSegCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8ScriptProfileCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8StyleSheetCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8TrackEventCustom.cpp:
+ (WebCore::V8TrackEvent::trackAccessorGetter):
+ * bindings/v8/custom/V8Uint16ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint32ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint8ArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
+ (WebCore::toV8):
+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
+ (WebCore::toV8Object):
+ (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
+ (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
+ * bindings/v8/custom/V8WorkerContextCustom.cpp:
+ (WebCore::toV8):
+
+2012-05-23 Kentaro Hara <[email protected]>
+
[V8] Pass Isolate to v8::Null() in custom bindings (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=87207
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -44,7 +44,7 @@
static v8::Handle<v8::Value> toV8Object(MicroDataItemValue* itemValue, v8::Isolate* isolate)
{
if (!itemValue)
- return v8::Null();
+ return v8::Null(isolate);
if (itemValue->isNode())
return toV8(itemValue->getNode(), isolate);
@@ -56,7 +56,7 @@
v8::Handle<v8::Value> toV8(HTMLElement* impl, v8::Isolate* isolate, bool forceNewObject)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
return createV8HTMLWrapper(impl, isolate, forceNewObject);
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -53,7 +53,7 @@
return value;
SerializedScriptValue* serialized = history->state();
- value = serialized ? serialized->deserialize(0, info.GetIsolate()) : v8::Handle<v8::Value>(v8::Null());
+ value = serialized ? serialized->deserialize(0, info.GetIsolate()) : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
info.Holder()->SetHiddenValue(V8HiddenPropertyName::state(), value);
return value;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -48,13 +48,13 @@
v8::Handle<v8::Value> toV8(IDBAny* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
switch (impl->type()) {
case IDBAny::UndefinedType:
return v8::Undefined();
case IDBAny::NullType:
- return v8::Null();
+ return v8::Null(isolate);
case IDBAny::DOMStringListType:
return toV8(impl->domStringList(), isolate);
case IDBAny::IDBCursorType:
Modified: trunk/Source/WebCore/bindings/v8/custom/V8IDBKeyCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8IDBKeyCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8IDBKeyCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -41,7 +41,7 @@
v8::Handle<v8::Value> toV8(IDBKey* key, v8::Isolate* isolate)
{
if (!key)
- return v8::Null();
+ return v8::Null(isolate);
switch (key->type()) {
case IDBKey::InvalidType:
Modified: trunk/Source/WebCore/bindings/v8/custom/V8ImageDataCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8ImageDataCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ImageDataCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -38,7 +38,7 @@
v8::Handle<v8::Value> toV8(ImageData* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8ImageData::wrap(impl, isolate);
if (!wrapper.IsEmpty()) {
// Create a V8 Uint8ClampedArray object.
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Int16ArrayCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8Int16ArrayCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Int16ArrayCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -56,7 +56,7 @@
v8::Handle<v8::Value> toV8(Int16Array* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8Int16Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalShortArray, impl->length());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Int32ArrayCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8Int32ArrayCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Int32ArrayCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -56,7 +56,7 @@
v8::Handle<v8::Value> toV8(Int32Array* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8Int32Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalIntArray, impl->length());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Int8ArrayCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8Int8ArrayCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Int8ArrayCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -56,7 +56,7 @@
v8::Handle<v8::Value> toV8(Int8Array* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8Int8Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalByteArray, impl->length());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -275,7 +275,7 @@
v8::Handle<v8::Value> toV8(Location* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = getDOMObjectMap().get(impl);
if (wrapper.IsEmpty()) {
wrapper = V8Location::wrap(impl, isolate);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -53,7 +53,7 @@
case MessageEvent::DataTypeScriptValue: {
ScriptValue scriptValue = event->dataAsScriptValue();
if (scriptValue.hasNoValue())
- result = v8::Null();
+ result = v8::Null(info.GetIsolate());
else
result = v8::Local<v8::Value>::New(scriptValue.v8Value());
break;
@@ -63,7 +63,7 @@
if (SerializedScriptValue* serializedValue = event->dataAsSerializedScriptValue())
result = serializedValue->deserialize(event->ports(), info.GetIsolate());
else
- result = v8::Null();
+ result = v8::Null(info.GetIsolate());
break;
case MessageEvent::DataTypeString: {
Modified: trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -74,7 +74,7 @@
v8::Handle<v8::Value> toV8(NamedNodeMap* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8NamedNodeMap::wrap(impl, isolate);
// Add a hidden reference from named node map to its owner node.
Element* element = impl->element();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -77,7 +77,7 @@
return V8Proxy::setDOMException(ec, args.GetIsolate());
if (success)
return args[0];
- return v8::Null();
+ return v8::Null(args.GetIsolate());
}
// This function is customized to take advantage of the optional 4th argument: shouldLazyAttach
@@ -94,7 +94,7 @@
return V8Proxy::setDOMException(ec, args.GetIsolate());
if (success)
return args[1];
- return v8::Null();
+ return v8::Null(args.GetIsolate());
}
v8::Handle<v8::Value> V8Node::removeChildCallback(const v8::Arguments& args)
@@ -109,7 +109,7 @@
return V8Proxy::setDOMException(ec, args.GetIsolate());
if (success)
return args[0];
- return v8::Null();
+ return v8::Null(args.GetIsolate());
}
// This function is customized to take advantage of the optional 4th argument: shouldLazyAttach
@@ -125,13 +125,13 @@
return V8Proxy::setDOMException(ec, args.GetIsolate());
if (success)
return args[0];
- return v8::Null();
+ return v8::Null(args.GetIsolate());
}
v8::Handle<v8::Value> toV8Slow(Node* impl, v8::Isolate* isolate, bool forceNewObject)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
if (!forceNewObject) {
v8::Handle<v8::Value> wrapper = V8DOMWrapper::getCachedWrapper(impl);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -62,7 +62,7 @@
History* history = event->history();
if (!history || !event->serializedState())
- return cacheState(info.Holder(), v8::Null());
+ return cacheState(info.Holder(), v8::Null(info.GetIsolate()));
// There's no cached value from a previous invocation, nor a state value was provided by the
// event, but there is a history object, so first we need to see if the state object has been
Modified: trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -67,7 +67,7 @@
value = v8String(sqlValue.string());
break;
case SQLValue::NullValue:
- value = v8::Null();
+ value = v8::Null(args.GetIsolate());
break;
case SQLValue::NumberValue:
value = v8::Number::New(sqlValue.number());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -41,7 +41,7 @@
v8::Handle<v8::Value> toV8(SVGDocument* impl, v8::Isolate* isolate, bool forceNewObject)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8SVGDocument::wrap(impl, isolate, forceNewObject);
if (wrapper.IsEmpty())
return wrapper;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8SVGElementCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8SVGElementCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SVGElementCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -40,7 +40,7 @@
v8::Handle<v8::Value> toV8(SVGElement* impl, v8::Isolate* isolate, bool forceNewObject)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
return createV8SVGWrapper(impl, isolate, forceNewObject);
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -60,7 +60,7 @@
v8::Handle<v8::Value> toV8(SVGPathSeg* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
switch (impl->pathSegType()) {
case SVGPathSeg::PATHSEG_CLOSEPATH:
return toV8(static_cast<SVGPathSegClosePath*>(impl), isolate);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -44,7 +44,7 @@
v8::Handle<v8::Value> toV8(ScriptProfile* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Local<v8::Function> function = V8ScriptProfile::GetTemplate()->GetFunction();
if (function.IsEmpty()) {
// Return if allocation failed.
Modified: trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -51,7 +51,7 @@
v8::Handle<v8::Value> toV8(ScriptProfileNode* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Local<v8::Function> function = V8ScriptProfileNode::GetTemplate()->GetFunction();
if (function.IsEmpty()) {
// Return if allocation failed.
Modified: trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -40,7 +40,7 @@
v8::Handle<v8::Value> toV8(StyleSheet* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
if (impl->isCSSStyleSheet())
return toV8(static_cast<CSSStyleSheet*>(impl), isolate);
v8::Handle<v8::Object> wrapper = V8StyleSheet::wrap(impl, isolate);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -48,7 +48,7 @@
TrackBase* track = trackEvent->track();
if (!track)
- return v8::Null();
+ return v8::Null(info.GetIsolate());
switch (track->type()) {
case TrackBase::BaseTrack:
@@ -67,7 +67,7 @@
break;
}
- return v8::Null();
+ return v8::Null(info.GetIsolate());
}
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Uint16ArrayCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8Uint16ArrayCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Uint16ArrayCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -56,7 +56,7 @@
v8::Handle<v8::Value> toV8(Uint16Array* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8Uint16Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalUnsignedShortArray, impl->length());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Uint32ArrayCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8Uint32ArrayCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Uint32ArrayCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -56,7 +56,7 @@
v8::Handle<v8::Value> toV8(Uint32Array* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8Uint32Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalUnsignedIntArray, impl->length());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Uint8ArrayCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8Uint8ArrayCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Uint8ArrayCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -56,7 +56,7 @@
v8::Handle<v8::Value> toV8(Uint8Array* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8Uint8Array::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalUnsignedByteArray, impl->length());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -53,7 +53,7 @@
v8::Handle<v8::Value> toV8(Uint8ClampedArray* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> wrapper = V8Uint8ClampedArray::wrap(impl, isolate);
if (!wrapper.IsEmpty())
wrapper->SetIndexedPropertiesToExternalArrayData(impl->baseAddress(), v8::kExternalPixelArray, impl->length());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -132,7 +132,7 @@
case WebGLGetInfo::kTypeInt:
return v8::Integer::New(info.getInt());
case WebGLGetInfo::kTypeNull:
- return v8::Null();
+ return v8::Null(isolate);
case WebGLGetInfo::kTypeString:
return v8::String::New(fromWebCoreString(info.getString()), info.getString().length());
case WebGLGetInfo::kTypeUnsignedInt:
@@ -168,7 +168,7 @@
static v8::Handle<v8::Value> toV8Object(WebGLExtension* extension, v8::Handle<v8::Object> contextObject, v8::Isolate* isolate)
{
if (!extension)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Value> extensionObject;
const char* referenceName = 0;
switch (extension->getName()) {
@@ -278,10 +278,10 @@
bool succeed = context->getAttachedShaders(program, shaders, ec);
if (ec) {
V8Proxy::setDOMException(ec, args.GetIsolate());
- return v8::Null();
+ return v8::Null(args.GetIsolate());
}
if (!succeed)
- return v8::Null();
+ return v8::Null(args.GetIsolate());
v8::Local<v8::Array> array = v8::Array::New(shaders.size());
for (size_t ii = 0; ii < shaders.size(); ++ii)
array->Set(v8::Integer::New(ii), toV8(shaders[ii].get(), args.GetIsolate()));
@@ -388,7 +388,7 @@
INC_STATS("DOM.WebGLRenderingContext.getSupportedExtensionsCallback()");
WebGLRenderingContext* imp = V8WebGLRenderingContext::toNative(args.Holder());
if (imp->isContextLost())
- return v8::Null();
+ return v8::Null(args.GetIsolate());
Vector<String> value = imp->getSupportedExtensions();
v8::Local<v8::Array> array = v8::Array::New(value.size());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp (118133 => 118134)
--- trunk/Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp 2012-05-23 07:06:11 UTC (rev 118133)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp 2012-05-23 07:11:23 UTC (rev 118134)
@@ -127,11 +127,11 @@
v8::Handle<v8::Value> toV8(WorkerContext* impl, v8::Isolate* isolate)
{
if (!impl)
- return v8::Null();
+ return v8::Null(isolate);
WorkerContextExecutionProxy* proxy = impl->script()->proxy();
if (!proxy)
- return v8::Null();
+ return v8::Null(isolate);
v8::Handle<v8::Object> global = proxy->context()->Global();
ASSERT(!global.IsEmpty());
