Title: [119238] trunk/Source/WebKit/efl
- Revision
- 119238
- Author
- [email protected]
- Date
- 2012-06-01 08:56:22 -0700 (Fri, 01 Jun 2012)
Log Message
[EFL] ewk_intent_data_get() is not needed and can be removed
https://bugs.webkit.org/show_bug.cgi?id=88072
Patch by Christophe Dumez <[email protected]> on 2012-06-01
Reviewed by Adam Barth.
Remove ewk_intent_data_get() method from Ewk_Intent. Intent data is
serialized and does not need to be publicly exposed. The browser only
needs action and type to match with services.
* ewk/ewk_intent.cpp:
(_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_free):
* ewk/ewk_intent.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (119237 => 119238)
--- trunk/Source/WebKit/efl/ChangeLog 2012-06-01 15:49:03 UTC (rev 119237)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-06-01 15:56:22 UTC (rev 119238)
@@ -1,5 +1,24 @@
2012-06-01 Christophe Dumez <[email protected]>
+ [EFL] ewk_intent_data_get() is not needed and can be removed
+ https://bugs.webkit.org/show_bug.cgi?id=88072
+
+ Reviewed by Adam Barth.
+
+ Remove ewk_intent_data_get() method from Ewk_Intent. Intent data is
+ serialized and does not need to be publicly exposed. The browser only
+ needs action and type to match with services.
+
+ * ewk/ewk_intent.cpp:
+ (_Ewk_Intent):
+ (ewk_intent_action_get):
+ (ewk_intent_type_get):
+ (ewk_intent_service_get):
+ (ewk_intent_free):
+ * ewk/ewk_intent.h:
+
+2012-06-01 Christophe Dumez <[email protected]>
+
[EFL] EFL's LayoutTestController needs to implement deliverWebIntent
https://bugs.webkit.org/show_bug.cgi?id=86865
Modified: trunk/Source/WebKit/efl/ewk/ewk_intent.cpp (119237 => 119238)
--- trunk/Source/WebKit/efl/ewk/ewk_intent.cpp 2012-06-01 15:49:03 UTC (rev 119237)
+++ trunk/Source/WebKit/efl/ewk/ewk_intent.cpp 2012-06-01 15:56:22 UTC (rev 119238)
@@ -22,7 +22,6 @@
#include "Intent.h"
#include "NotImplemented.h"
-#include "SerializedScriptValue.h"
#include "ewk_intent_private.h"
#include "ewk_private.h"
#include <KURL.h>
@@ -40,7 +39,6 @@
#endif
const char* action;
const char* type;
- const char* data;
const char* service;
};
@@ -60,7 +58,7 @@
#if ENABLE(WEB_INTENTS)
EWK_INTENT_CORE_GET_OR_RETURN(intent, core, 0);
- // hide the following optimzation from outside
+ // hide the following optimization from outside
Ewk_Intent* ewkIntent = const_cast<Ewk_Intent*>(intent);
eina_stringshare_replace(&ewkIntent->action,
core->action().utf8().data());
@@ -75,7 +73,7 @@
#if ENABLE(WEB_INTENTS)
EWK_INTENT_CORE_GET_OR_RETURN(intent, core, 0);
- // hide the following optimzation from outside
+ // hide the following optimization from outside
Ewk_Intent* ewkIntent = const_cast<Ewk_Intent*>(intent);
eina_stringshare_replace(&ewkIntent->type,
core->type().utf8().data());
@@ -85,22 +83,12 @@
#endif
}
-const char* ewk_intent_data_get(const Ewk_Intent* intent)
-{
-#if ENABLE(WEB_INTENTS)
- notImplemented();
- return 0;
-#else
- return 0;
-#endif
-}
-
const char* ewk_intent_service_get(const Ewk_Intent* intent)
{
#if ENABLE(WEB_INTENTS)
EWK_INTENT_CORE_GET_OR_RETURN(intent, core, 0);
- // hide the following optimzation from outside
+ // hide the following optimization from outside
Ewk_Intent* ewkIntent = const_cast<Ewk_Intent*>(intent);
eina_stringshare_replace(&ewkIntent->service,
core->service().string().utf8().data());
@@ -184,7 +172,6 @@
eina_stringshare_del(intent->action);
eina_stringshare_del(intent->type);
- eina_stringshare_del(intent->data);
eina_stringshare_del(intent->service);
delete intent;
}
Modified: trunk/Source/WebKit/efl/ewk/ewk_intent.h (119237 => 119238)
--- trunk/Source/WebKit/efl/ewk/ewk_intent.h 2012-06-01 15:49:03 UTC (rev 119237)
+++ trunk/Source/WebKit/efl/ewk/ewk_intent.h 2012-06-01 15:56:22 UTC (rev 119238)
@@ -56,19 +56,6 @@
EAPI const char *ewk_intent_type_get(const Ewk_Intent *intent);
/**
- * Query data for this intent.
- *
- * @param intent intent item to query.
- *
- * @return the data pointer, that may be @c NULL. This pointer is
- * guaranteed to be eina_stringshare, so whenever possible
- * save yourself some cpu cycles and use
- * eina_stringshare_ref() instead of eina_stringshare_add() or
- * strdup().
- */
-EAPI const char *ewk_intent_data_get(const Ewk_Intent *intent);
-
-/**
* Query service for this intent.
*
* @param intent intent item to query.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
