Title: [119239] trunk/Source/WebKit/blackberry
- Revision
- 119239
- Author
- [email protected]
- Date
- 2012-06-01 09:00:19 -0700 (Fri, 01 Jun 2012)
Log Message
[BlackBerry] Add end editing handling into AutofillManager
https://bugs.webkit.org/show_bug.cgi?id=88071
Patch by Jonathan Dong <[email protected]> on 2012-06-01
Reviewed by Rob Buis.
RIM PR: 160857
Implemented EditorClientBlackBerry::textFieldDidEndEditing
to notify AutofillManager to send the dismissing autofill
dialog notification to webpage client.
No new tests since there is no behavior changes.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyDismissAutofillDialog):
(WebKit):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/AutofillManager.cpp:
(WebCore::AutofillManager::textFieldDidEndEditing):
(WebCore):
* WebCoreSupport/AutofillManager.h:
(AutofillManager):
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (119238 => 119239)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-06-01 15:56:22 UTC (rev 119238)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-06-01 16:00:19 UTC (rev 119239)
@@ -2181,6 +2181,11 @@
m_client->notifyPopupAutofillDialog(textItems, screenRect);
}
+void WebPagePrivate::notifyDismissAutofillDialog()
+{
+ m_client->notifyDismissAutofillDialog();
+}
+
bool WebPagePrivate::useFixedLayout() const
{
return true;
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (119238 => 119239)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-06-01 15:56:22 UTC (rev 119238)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-06-01 16:00:19 UTC (rev 119239)
@@ -210,6 +210,7 @@
virtual bool authenticationChallenge(const unsigned short* realm, unsigned int realmLength, WebString& username, WebString& password) = 0;
virtual SaveCredentialType notifyShouldSaveCredential(bool isNew) = 0;
virtual void notifyPopupAutofillDialog(const std::vector<std::string>&, const Platform::IntRect&) = 0;
+ virtual void notifyDismissAutofillDialog() = 0;
virtual bool shouldPluginEnterFullScreen() = 0;
virtual void didPluginEnterFullScreen() = 0;
Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (119238 => 119239)
--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-06-01 15:56:22 UTC (rev 119238)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-06-01 16:00:19 UTC (rev 119239)
@@ -202,6 +202,7 @@
void layoutFinished();
void setNeedTouchEvents(bool);
void notifyPopupAutofillDialog(const Vector<String>&, const WebCore::IntRect&);
+ void notifyDismissAutofillDialog();
// Called according to our heuristic or from setLoadState depending on whether we have a virtual viewport.
void zoomToInitialScaleOnLoad();
Modified: trunk/Source/WebKit/blackberry/ChangeLog (119238 => 119239)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-01 15:56:22 UTC (rev 119238)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-01 16:00:19 UTC (rev 119239)
@@ -1,3 +1,31 @@
+2012-06-01 Jonathan Dong <[email protected]>
+
+ [BlackBerry] Add end editing handling into AutofillManager
+ https://bugs.webkit.org/show_bug.cgi?id=88071
+
+ Reviewed by Rob Buis.
+
+ RIM PR: 160857
+ Implemented EditorClientBlackBerry::textFieldDidEndEditing
+ to notify AutofillManager to send the dismissing autofill
+ dialog notification to webpage client.
+
+ No new tests since there is no behavior changes.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::notifyDismissAutofillDialog):
+ (WebKit):
+ * Api/WebPageClient.h:
+ * Api/WebPage_p.h:
+ (WebPagePrivate):
+ * WebCoreSupport/AutofillManager.cpp:
+ (WebCore::AutofillManager::textFieldDidEndEditing):
+ (WebCore):
+ * WebCoreSupport/AutofillManager.h:
+ (AutofillManager):
+ * WebCoreSupport/EditorClientBlackBerry.cpp:
+ (WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
+
2012-05-31 Jacky Jiang <[email protected]>
[BlackBerry] Bridge Apps - Apps do not redraw correctly after orientation change
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp (119238 => 119239)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp 2012-06-01 15:56:22 UTC (rev 119238)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/AutofillManager.cpp 2012-06-01 16:00:19 UTC (rev 119239)
@@ -51,6 +51,11 @@
m_webPagePrivate->notifyPopupAutofillDialog(candidates, element->screenRect());
}
+void AutofillManager::textFieldDidEndEditing(HTMLInputElement*)
+{
+ m_webPagePrivate->notifyDismissAutofillDialog();
+}
+
void AutofillManager::autofillTextField(const String& value)
{
if (!m_element)
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h (119238 => 119239)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h 2012-06-01 15:56:22 UTC (rev 119238)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h 2012-06-01 16:00:19 UTC (rev 119239)
@@ -41,6 +41,7 @@
static PassRefPtr<AutofillManager> create(BlackBerry::WebKit::WebPagePrivate*);
void didChangeInTextField(HTMLInputElement*);
+ void textFieldDidEndEditing(HTMLInputElement*);
void autofillTextField(const WTF::String&);
void saveTextFields(HTMLFormElement*);
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp (119238 => 119239)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp 2012-06-01 15:56:22 UTC (rev 119238)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp 2012-06-01 16:00:19 UTC (rev 119239)
@@ -507,9 +507,10 @@
notImplemented();
}
-void EditorClientBlackBerry::textFieldDidEndEditing(Element*)
+void EditorClientBlackBerry::textFieldDidEndEditing(Element* element)
{
- notImplemented();
+ if (HTMLInputElement* inputElement = element->toInputElement())
+ m_webPagePrivate->m_autofillManager->textFieldDidEndEditing(inputElement);
}
void EditorClientBlackBerry::textDidChangeInTextField(Element* element)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
