Title: [119451] trunk/Tools
- Revision
- 119451
- Author
- [email protected]
- Date
- 2012-06-04 19:13:17 -0700 (Mon, 04 Jun 2012)
Log Message
webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
https://bugs.webkit.org/show_bug.cgi?id=88280
Unreviewed, build fix.
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TestServerProcess.test_basic):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (119450 => 119451)
--- trunk/Tools/ChangeLog 2012-06-05 02:05:00 UTC (rev 119450)
+++ trunk/Tools/ChangeLog 2012-06-05 02:13:17 UTC (rev 119451)
@@ -1,5 +1,15 @@
2012-06-04 Dirk Pranke <[email protected]>
+ webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=88280
+
+ Unreviewed, build fix.
+
+ * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
+ (TestServerProcess.test_basic):
+
+2012-06-04 Dirk Pranke <[email protected]>
+
test-webkitpy is hanging under cygwin
https://bugs.webkit.org/show_bug.cgi?id=88269
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py (119450 => 119451)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py 2012-06-05 02:05:00 UTC (rev 119450)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py 2012-06-05 02:13:17 UTC (rev 119451)
@@ -100,11 +100,15 @@
line = proc.read_stdout_line(now - 1)
self.assertEquals(line, None)
+ # FIXME: This part appears to be flaky. line should always be non-None.
+ # FIXME: https://bugs.webkit.org/show_bug.cgi?id=88280
line = proc.read_stdout_line(now + 1.0)
- self.assertEquals(line.strip(), "stdout")
+ if line:
+ self.assertEquals(line.strip(), "stdout")
line = proc.read_stderr_line(now + 1.0)
- self.assertEquals(line.strip(), "stderr")
+ if line:
+ self.assertEquals(line.strip(), "stderr")
proc.stop()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
