Title: [119452] trunk
Revision
119452
Author
[email protected]
Date
2012-06-04 20:01:18 -0700 (Mon, 04 Jun 2012)

Log Message

Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
https://bugs.webkit.org/show_bug.cgi?id=88243

Patch by Hugo Parente Lima <[email protected]> on 2012-06-04
Reviewed by Adam Barth.

.:

* Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

No new tests needed, this just rename a compiler flag.

* dom/Document.cpp:
(WebCore::Document::setDocType):
* dom/ViewportArguments.h:
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::process):

Tools:

* qmake/mkspecs/features/features.prf:

Modified Paths

Diff

Modified: trunk/ChangeLog (119451 => 119452)


--- trunk/ChangeLog	2012-06-05 02:13:17 UTC (rev 119451)
+++ trunk/ChangeLog	2012-06-05 03:01:18 UTC (rev 119452)
@@ -1,3 +1,12 @@
+2012-06-04  Hugo Parente Lima  <[email protected]>
+
+        Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
+        https://bugs.webkit.org/show_bug.cgi?id=88243
+
+        Reviewed by Adam Barth.
+
+        * Source/cmake/WebKitFeatures.cmake:
+
 2012-06-04  Sadrul Habib Chowdhury  <[email protected]>
 
         [chromium] Fix software rendering for device-scale-factor > 1

Modified: trunk/Source/WebCore/ChangeLog (119451 => 119452)


--- trunk/Source/WebCore/ChangeLog	2012-06-05 02:13:17 UTC (rev 119451)
+++ trunk/Source/WebCore/ChangeLog	2012-06-05 03:01:18 UTC (rev 119452)
@@ -1,3 +1,18 @@
+2012-06-04  Hugo Parente Lima  <[email protected]>
+
+        Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
+        https://bugs.webkit.org/show_bug.cgi?id=88243
+
+        Reviewed by Adam Barth.
+
+        No new tests needed, this just rename a compiler flag.
+
+        * dom/Document.cpp:
+        (WebCore::Document::setDocType):
+        * dom/ViewportArguments.h:
+        * html/HTMLMetaElement.cpp:
+        (WebCore::HTMLMetaElement::process):
+
 2012-06-04  Dana Jansens  <[email protected]>
 
         [chromium] Remove redundant setNeedsCommit when prepareToDraw fails

Modified: trunk/Source/WebCore/dom/Document.cpp (119451 => 119452)


--- trunk/Source/WebCore/dom/Document.cpp	2012-06-05 02:13:17 UTC (rev 119451)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-06-05 03:01:18 UTC (rev 119452)
@@ -788,7 +788,7 @@
     m_docType = docType;
     if (m_docType) {
         this->adoptIfNeeded(m_docType.get());
-#if USE(LEGACY_VIEWPORT_ADAPTION)
+#if ENABLE(LEGACY_VIEWPORT_ADAPTION)
         ASSERT(m_viewportArguments.type == ViewportArguments::Implicit);
         if (m_docType->publicId().startsWith("-//wapforum//dtd xhtml mobile 1.", /* caseSensitive */ false))
             processViewport("width=device-width, height=device-height", ViewportArguments::XHTMLMobileProfile);

Modified: trunk/Source/WebCore/dom/ViewportArguments.h (119451 => 119452)


--- trunk/Source/WebCore/dom/ViewportArguments.h	2012-06-05 02:13:17 UTC (rev 119451)
+++ trunk/Source/WebCore/dom/ViewportArguments.h	2012-06-05 03:01:18 UTC (rev 119452)
@@ -59,7 +59,7 @@
     enum Type {
         // These are ordered in increasing importance.
         Implicit,
-#if USE(LEGACY_VIEWPORT_ADAPTION)
+#if ENABLE(LEGACY_VIEWPORT_ADAPTION)
         XHTMLMobileProfile,
         HandheldFriendlyMeta,
         MobileOptimizedMeta,

Modified: trunk/Source/WebCore/html/HTMLMetaElement.cpp (119451 => 119452)


--- trunk/Source/WebCore/html/HTMLMetaElement.cpp	2012-06-05 02:13:17 UTC (rev 119451)
+++ trunk/Source/WebCore/html/HTMLMetaElement.cpp	2012-06-05 03:01:18 UTC (rev 119452)
@@ -75,7 +75,7 @@
         document()->processViewport(contentValue, ViewportArguments::ViewportMeta);
     else if (equalIgnoringCase(name(), "referrer"))
         document()->processReferrerPolicy(contentValue);
-#if USE(LEGACY_VIEWPORT_ADAPTION)
+#if ENABLE(LEGACY_VIEWPORT_ADAPTION)
     else if (equalIgnoringCase(name(), "handheldfriendly") && equalIgnoringCase(contentValue, "true"))
         document()->processViewport("width=device-width", ViewportArguments::HandheldFriendlyMeta);
     else if (equalIgnoringCase(name(), "mobileoptimized"))

Modified: trunk/Source/cmake/WebKitFeatures.cmake (119451 => 119452)


--- trunk/Source/cmake/WebKitFeatures.cmake	2012-06-05 02:13:17 UTC (rev 119451)
+++ trunk/Source/cmake/WebKitFeatures.cmake	2012-06-05 03:01:18 UTC (rev 119452)
@@ -56,6 +56,7 @@
     WEBKIT_OPTION_DEFINE(ENABLE_JAVASCRIPT_DEBUGGER "Toggle _javascript_ Debugger/Profiler support" ON)
     WEBKIT_OPTION_DEFINE(ENABLE_JIT "Enable JustInTime _javascript_ support" ON)
     WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_NOTIFICATIONS "Toggle Legacy Desktop Notifications Support" OFF)
+    WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_WEBKIT_BLOB_BUILDER "Toggle Legacy WebKit Blob Builder Support" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_LINK_PREFETCH "Toggle pre fetching support" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_MATHML "Toggle MathML support" ON)
@@ -100,7 +101,6 @@
     WEBKIT_OPTION_DEFINE(ENABLE_XSLT "Toggle XSLT support" ON)
     WEBKIT_OPTION_DEFINE(USE_SYSTEM_MALLOC "Toggle system allocator instead of TCmalloc" OFF)
     WEBKIT_OPTION_DEFINE(USE_TILED_BACKING_STORE "Toggle Tiled Backing Store support" OFF)
-    WEBKIT_OPTION_DEFINE(USE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF)
     WEBKIT_OPTION_DEFINE(USE_WTFURL "Toogle the use of WTFURL for URL parsing" OFF)
 ENDMACRO ()
 

Modified: trunk/Tools/ChangeLog (119451 => 119452)


--- trunk/Tools/ChangeLog	2012-06-05 02:13:17 UTC (rev 119451)
+++ trunk/Tools/ChangeLog	2012-06-05 03:01:18 UTC (rev 119452)
@@ -1,3 +1,12 @@
+2012-06-04  Hugo Parente Lima  <[email protected]>
+
+        Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
+        https://bugs.webkit.org/show_bug.cgi?id=88243
+
+        Reviewed by Adam Barth.
+
+        * qmake/mkspecs/features/features.prf:
+
 2012-06-04  Dirk Pranke  <[email protected]>
 
         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky

Modified: trunk/Tools/qmake/mkspecs/features/features.prf (119451 => 119452)


--- trunk/Tools/qmake/mkspecs/features/features.prf	2012-06-05 02:13:17 UTC (rev 119451)
+++ trunk/Tools/qmake/mkspecs/features/features.prf	2012-06-05 03:01:18 UTC (rev 119452)
@@ -79,7 +79,7 @@
 !contains(DEFINES, WTF_USE_TILED_BACKING_STORE=.): DEFINES += WTF_USE_TILED_BACKING_STORE=1
 
 # Turn on legacy viewport adaption
-!contains(DEFINES, WTF_USE_LEGACY_VIEWPORT_ADAPTION=.): DEFINES += WTF_USE_LEGACY_VIEWPORT_ADAPTION=1
+!contains(DEFINES, ENABLE_LEGACY_VIEWPORT_ADAPTION=.): DEFINES += ENABLE_LEGACY_VIEWPORT_ADAPTION=1
 
 # Nescape plugins support (NPAPI)
 !contains(DEFINES, ENABLE_NETSCAPE_PLUGIN_API=.) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to