Title: [119603] trunk
- Revision
- 119603
- Author
- [email protected]
- Date
- 2012-06-06 12:00:04 -0700 (Wed, 06 Jun 2012)
Log Message
IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
https://bugs.webkit.org/show_bug.cgi?id=86874
Reviewed by Ojan Vafai.
Source/WebCore:
The function is non-standard, and should be prefixed.
Test: storage/indexeddb/factory-basics.html
* Modules/indexeddb/IDBFactory.idl:
LayoutTests:
* storage/indexeddb/factory-basics-expected.txt:
* storage/indexeddb/resources/factory-basics.js:
(test):
(openSuccess):
(deleteDatabaseSuccess):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (119602 => 119603)
--- trunk/LayoutTests/ChangeLog 2012-06-06 18:59:35 UTC (rev 119602)
+++ trunk/LayoutTests/ChangeLog 2012-06-06 19:00:04 UTC (rev 119603)
@@ -1,3 +1,16 @@
+2012-06-06 Joshua Bell <[email protected]>
+
+ IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
+ https://bugs.webkit.org/show_bug.cgi?id=86874
+
+ Reviewed by Ojan Vafai.
+
+ * storage/indexeddb/factory-basics-expected.txt:
+ * storage/indexeddb/resources/factory-basics.js:
+ (test):
+ (openSuccess):
+ (deleteDatabaseSuccess):
+
2012-06-06 Ryosuke Niwa <[email protected]>
Chromium rebaseline after r119591 because it was failing with missing results.
Modified: trunk/LayoutTests/storage/indexeddb/factory-basics-expected.txt (119602 => 119603)
--- trunk/LayoutTests/storage/indexeddb/factory-basics-expected.txt 2012-06-06 18:59:35 UTC (rev 119602)
+++ trunk/LayoutTests/storage/indexeddb/factory-basics-expected.txt 2012-06-06 19:00:04 UTC (rev 119603)
@@ -7,20 +7,21 @@
PASS typeof indexedDB.open is "function"
PASS typeof indexedDB.cmp is "function"
-PASS typeof indexedDB.getDatabaseNames is "function"
PASS typeof indexedDB.deleteDatabase is "function"
-indexedDB.getDatabaseNames()
+PASS typeof indexedDB.webkitGetDatabaseNames is "function"
+PASS typeof indexedDB.getDatabaseNames is "undefined"
+indexedDB.webkitGetDatabaseNames()
databaseNames = event.target.result
PASS databaseNames.contains('storage/indexeddb/factory-basics') is false
PASS databaseNames.contains('DATABASE THAT DOES NOT EXIST') is false
indexedDB.open(name)
event.target.result.close()
-indexedDB.getDatabaseNames()
+indexedDB.webkitGetDatabaseNames()
databaseNames = event.target.result
PASS databaseNames.contains('storage/indexeddb/factory-basics') is true
PASS databaseNames.contains('DATABASE THAT DOES NOT EXIST') is false
indexedDB.deleteDatabase('storage/indexeddb/factory-basics')
-indexedDB.getDatabaseNames()
+indexedDB.webkitGetDatabaseNames()
databaseNames = event.target.result
PASS databaseNames.contains('storage/indexeddb/factory-basics') is false
PASS databaseNames.contains('DATABASE THAT DOES NOT EXIST') is false
Modified: trunk/LayoutTests/storage/indexeddb/resources/factory-basics.js (119602 => 119603)
--- trunk/LayoutTests/storage/indexeddb/resources/factory-basics.js 2012-06-06 18:59:35 UTC (rev 119602)
+++ trunk/LayoutTests/storage/indexeddb/resources/factory-basics.js 2012-06-06 19:00:04 UTC (rev 119603)
@@ -11,13 +11,16 @@
shouldBeEqualToString("typeof indexedDB.open", "function");
shouldBeEqualToString("typeof indexedDB.cmp", "function");
- shouldBeEqualToString("typeof indexedDB.getDatabaseNames", "function");
-
shouldBeEqualToString("typeof indexedDB.deleteDatabase", "function");
+ // Non-standard, must be prefixed
+ shouldBeEqualToString("typeof indexedDB.webkitGetDatabaseNames", "function");
+ shouldBeEqualToString("typeof indexedDB.getDatabaseNames", "undefined");
+
+
name = 'storage/indexeddb/factory-basics';
- request = evalAndLog("indexedDB.getDatabaseNames()");
+ request = evalAndLog("indexedDB.webkitGetDatabaseNames()");
request._onsuccess_ = getDatabaseNamesSuccess1;
request._onerror_ = unexpectedErrorCallback;
}
@@ -37,7 +40,7 @@
function openSuccess()
{
evalAndLog("event.target.result.close()");
- request = evalAndLog("indexedDB.getDatabaseNames()");
+ request = evalAndLog("indexedDB.webkitGetDatabaseNames()");
request._onsuccess_ = getDatabaseNamesSuccess2;
request._onerror_ = unexpectedErrorCallback;
}
@@ -56,7 +59,7 @@
function deleteDatabaseSuccess()
{
- request = evalAndLog("indexedDB.getDatabaseNames()");
+ request = evalAndLog("indexedDB.webkitGetDatabaseNames()");
request._onsuccess_ = getDatabaseNamesSuccess3;
request._onerror_ = unexpectedErrorCallback;
}
@@ -78,4 +81,4 @@
finishJSTest();
}
-test();
\ No newline at end of file
+test();
Modified: trunk/Source/WebCore/ChangeLog (119602 => 119603)
--- trunk/Source/WebCore/ChangeLog 2012-06-06 18:59:35 UTC (rev 119602)
+++ trunk/Source/WebCore/ChangeLog 2012-06-06 19:00:04 UTC (rev 119603)
@@ -1,3 +1,16 @@
+2012-06-06 Joshua Bell <[email protected]>
+
+ IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
+ https://bugs.webkit.org/show_bug.cgi?id=86874
+
+ Reviewed by Ojan Vafai.
+
+ The function is non-standard, and should be prefixed.
+
+ Test: storage/indexeddb/factory-basics.html
+
+ * Modules/indexeddb/IDBFactory.idl:
+
2012-06-06 Julien Chaffraix <[email protected]>
Add support for direction on table row group with collapsing borders
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBFactory.idl (119602 => 119603)
--- trunk/Source/WebCore/Modules/indexeddb/IDBFactory.idl 2012-06-06 18:59:35 UTC (rev 119602)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBFactory.idl 2012-06-06 19:00:04 UTC (rev 119603)
@@ -28,7 +28,7 @@
interface [
Conditional=INDEXED_DATABASE
] IDBFactory {
- [CallWith=ScriptExecutionContext] IDBRequest getDatabaseNames();
+ [CallWith=ScriptExecutionContext, ImplementedAs=getDatabaseNames] IDBRequest webkitGetDatabaseNames();
[CallWith=ScriptExecutionContext] IDBRequest open(in DOMString name)
raises (IDBDatabaseException);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
