Title: [119604] trunk/Tools
- Revision
- 119604
- Author
- [email protected]
- Date
- 2012-06-06 12:57:26 -0700 (Wed, 06 Jun 2012)
Log Message
webkitpy: perf tests unit tests fail on chromium win
https://bugs.webkit.org/show_bug.cgi?id=88279
Reviewed by Ryosuke Niwa.
I'm seeing weird failures running the unit tests in my win32
checkout, and we don't really expect webpagereplay to work on
win32 anyway, so I'm skipping the import of that module for now
and adding a warning.
* Scripts/run-perf-tests:
* Scripts/webkitpy/performance_tests/perftest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (119603 => 119604)
--- trunk/Tools/ChangeLog 2012-06-06 19:00:04 UTC (rev 119603)
+++ trunk/Tools/ChangeLog 2012-06-06 19:57:26 UTC (rev 119604)
@@ -1,3 +1,18 @@
+2012-06-06 Dirk Pranke <[email protected]>
+
+ webkitpy: perf tests unit tests fail on chromium win
+ https://bugs.webkit.org/show_bug.cgi?id=88279
+
+ Reviewed by Ryosuke Niwa.
+
+ I'm seeing weird failures running the unit tests in my win32
+ checkout, and we don't really expect webpagereplay to work on
+ win32 anyway, so I'm skipping the import of that module for now
+ and adding a warning.
+
+ * Scripts/run-perf-tests:
+ * Scripts/webkitpy/performance_tests/perftest.py:
+
2012-06-06 Yong Li <[email protected]>
Unreviewed. Update my email address in committers.py.
Modified: trunk/Tools/Scripts/run-perf-tests (119603 => 119604)
--- trunk/Tools/Scripts/run-perf-tests 2012-06-06 19:00:04 UTC (rev 119603)
+++ trunk/Tools/Scripts/run-perf-tests 2012-06-06 19:57:26 UTC (rev 119604)
@@ -36,4 +36,8 @@
if '__main__' == __name__:
logging.basicConfig(level=logging.INFO, format="%(message)s")
+
+ if sys.platform == 'win32':
+ _log.error("run-perf-tests doesn't work on win32; needs webpagereplay support.")
+ sys.exit(1)
sys.exit(PerfTestsRunner().run())
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (119603 => 119604)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py 2012-06-06 19:00:04 UTC (rev 119603)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py 2012-06-06 19:57:26 UTC (rev 119604)
@@ -36,10 +36,13 @@
import signal
import socket
import subprocess
+import sys
import time
# Import for auto-install
-import webkitpy.thirdparty.autoinstalled.webpagereplay.replay
+if sys.platform != 'win32':
+ # FIXME: webpagereplay doesn't work on win32. See https://bugs.webkit.org/show_bug.cgi?id=88279.
+ import webkitpy.thirdparty.autoinstalled.webpagereplay.replay
from webkitpy.layout_tests.controllers.test_result_writer import TestResultWriter
from webkitpy.layout_tests.port.driver import DriverInput
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
