Title: [120007] trunk/Tools
- Revision
- 120007
- Author
- [email protected]
- Date
- 2012-06-11 14:17:58 -0700 (Mon, 11 Jun 2012)
Log Message
nrwt exits early too frequently
https://bugs.webkit.org/show_bug.cgi?id=73843
Reviewed by Ryosuke Niwa.
Change the defaults for new-run-webkit-tests for both
--exit-after-n-failures and --exit-after-n-crashes-or-timeouts
to zero (i.e., we will never exit early by default).
If people want their buildbots to exit early it is their
responsibility to update their buildbot configs appropriately.
Note that we have tests that ensure that these flags work for
non-zero numbers, but we don't have tests that either test the
default or ensure that zero means "run all of the tests". I
think that's okay but can add tests if others disagree.
Also note that it looks like no changes on the build.webkit.org
master.cfg are necessary; all of the bots seem to be using the
RunWebKitTests wrapper which is already setting the flags. There
is a NewRunWebKitTests wrapper, but that looks to be unused; I
will delete that in a separate patch.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (120006 => 120007)
--- trunk/Tools/ChangeLog 2012-06-11 21:01:22 UTC (rev 120006)
+++ trunk/Tools/ChangeLog 2012-06-11 21:17:58 UTC (rev 120007)
@@ -1,3 +1,31 @@
+2012-06-11 Dirk Pranke <[email protected]>
+
+ nrwt exits early too frequently
+ https://bugs.webkit.org/show_bug.cgi?id=73843
+
+ Reviewed by Ryosuke Niwa.
+
+ Change the defaults for new-run-webkit-tests for both
+ --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
+ to zero (i.e., we will never exit early by default).
+
+ If people want their buildbots to exit early it is their
+ responsibility to update their buildbot configs appropriately.
+
+ Note that we have tests that ensure that these flags work for
+ non-zero numbers, but we don't have tests that either test the
+ default or ensure that zero means "run all of the tests". I
+ think that's okay but can add tests if others disagree.
+
+ Also note that it looks like no changes on the build.webkit.org
+ master.cfg are necessary; all of the bots seem to be using the
+ RunWebKitTests wrapper which is already setting the flags. There
+ is a NewRunWebKitTests wrapper, but that looks to be unused; I
+ will delete that in a separate patch.
+
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+ (parse_args):
+
2012-06-11 Sudarsana Nagineni <[email protected]>
[EFL] [DRT] Reset CacheModel before running each test
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (120006 => 120007)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-06-11 21:01:22 UTC (rev 120006)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2012-06-11 21:17:58 UTC (rev 120007)
@@ -383,11 +383,11 @@
# FIXME: Display default number of child processes that will run.
optparse.make_option("-f", "--fully-parallel", action=""
help="run all tests in parallel"),
- optparse.make_option("--exit-after-n-failures", type="int", default=500,
+ optparse.make_option("--exit-after-n-failures", type="int", default=None,
help="Exit after the first N failures instead of running all "
"tests"),
optparse.make_option("--exit-after-n-crashes-or-timeouts", type="int",
- default=20, help="Exit after the first N crashes instead of "
+ default=None, help="Exit after the first N crashes instead of "
"running all tests"),
optparse.make_option("--iterations", type="int", help="Number of times to run the set of tests (e.g. ABCABCABC)"),
optparse.make_option("--repeat-each", type="int", help="Number of times to run each test (e.g. AAABBBCCC)"),
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
