Title: [120009] trunk/Source/WebKit/blackberry
- Revision
- 120009
- Author
- [email protected]
- Date
- 2012-06-11 15:03:55 -0700 (Mon, 11 Jun 2012)
Log Message
browser video player fullscreen mode (portrait) does not play well with viewport metatag - Controls are off screen so cannot exit fullscreen https://bugs.webkit.org/show_bug.cgi?id=88719 PR #164026
Reviewed by Rob Buis.
Patch by Antonio Gomes <[email protected]>
Instead of using WebPage's viewport size, which suffers from
dealing with transformed coordinates, viewport metatag changes,
etc, lets use WebCore::FrameView's visibleContentRect::Size::Width,
which abstract all these variations.
It fixes an overscale issue we were having when video player entered
fullscreen, and webpage had viewport metatag set.
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (120008 => 120009)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-11 21:37:44 UTC (rev 120008)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-11 22:03:55 UTC (rev 120009)
@@ -1,3 +1,22 @@
+2012-06-09 Antonio Gomes <[email protected]>
+
+ [BlackBerry] browser video player fullscreen mode (portrait) does not play well with viewport metatag - Controls are off screen so cannot exit fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=88719
+ PR #164026
+
+ Reviewed by Rob Buis.
+
+ Instead of using WebPage's viewport size, which suffers from
+ dealing with transformed coordinates, viewport metatag changes,
+ etc, lets use WebCore::FrameView's visibleContentRect::Size::Width,
+ which abstract all these variations.
+
+ It fixes an overscale issue we were having when video player entered
+ fullscreen, and webpage had viewport metatag set.
+
+ * WebCoreSupport/ChromeClientBlackBerry.cpp:
+ (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
+
2012-06-11 Sam Weinig <[email protected]>
Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (120008 => 120009)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-06-11 21:37:44 UTC (rev 120008)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-06-11 22:03:55 UTC (rev 120009)
@@ -739,7 +739,8 @@
// FIXME: Since we are setting an absolute width value here, it won't work for cases
// where we change the viewport size as we go. For example, rotate the device while
// in fullscreen mode.
- fullScreenRenderer->style()->setWidth(Length(m_webPagePrivate->viewportSize().width(), Fixed));
+ int width = m_webPagePrivate->m_mainFrame->view()->visibleContentRect().size().width();
+ fullScreenRenderer->style()->setWidth(Length(width, Fixed));
}
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
