Title: [122372] trunk
- Revision
- 122372
- Author
- [email protected]
- Date
- 2012-07-11 14:20:50 -0700 (Wed, 11 Jul 2012)
Log Message
ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
https://bugs.webkit.org/show_bug.cgi?id=77298
Reviewed by Anders Carlsson.
Source/WebCore:
* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
LayoutTests:
* platform/mac/accessibility/aria-spinbutton-expected.txt:
* platform/mac/accessibility/aria-spinbutton.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (122371 => 122372)
--- trunk/LayoutTests/ChangeLog 2012-07-11 21:14:25 UTC (rev 122371)
+++ trunk/LayoutTests/ChangeLog 2012-07-11 21:20:50 UTC (rev 122372)
@@ -1,3 +1,13 @@
+2012-07-11 Chris Fleizach <[email protected]>
+
+ ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
+ https://bugs.webkit.org/show_bug.cgi?id=77298
+
+ Reviewed by Anders Carlsson.
+
+ * platform/mac/accessibility/aria-spinbutton-expected.txt:
+ * platform/mac/accessibility/aria-spinbutton.html:
+
2012-07-11 Zan Dobersek <[email protected]>
Unreviewed GTK gardening, adding an expectation for a test failing on the
Modified: trunk/LayoutTests/platform/mac/accessibility/aria-spinbutton-expected.txt (122371 => 122372)
--- trunk/LayoutTests/platform/mac/accessibility/aria-spinbutton-expected.txt 2012-07-11 21:14:25 UTC (rev 122371)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-spinbutton-expected.txt 2012-07-11 21:20:50 UTC (rev 122372)
@@ -1,5 +1,5 @@
-In accessibility, the following should be a progress indicator:
+In accessibility, the following should be an incrementor:
X
-This test PASSES in DumpRenderTree. The role is AXRole: AXProgressIndicator
+This test PASSES in DumpRenderTree. The role is AXRole: AXIncrementor
Modified: trunk/LayoutTests/platform/mac/accessibility/aria-spinbutton.html (122371 => 122372)
--- trunk/LayoutTests/platform/mac/accessibility/aria-spinbutton.html 2012-07-11 21:14:25 UTC (rev 122371)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-spinbutton.html 2012-07-11 21:20:50 UTC (rev 122372)
@@ -13,15 +13,15 @@
var ariaRole = accessibilityController.focusedElement.role;
var result = document.getElementById("result");
- if (ariaRole == "AXRole: AXProgressIndicator")
+ if (ariaRole == "AXRole: AXIncrementor")
result.innerText = "This test PASSES in DumpRenderTree. The role is " + ariaRole;
else
- result.innerText = "This test FAILS in DumpRenderTree. The ARIA role is " + ariaRole + ", but should be AXProgressIndicator";
+ result.innerText = "This test FAILS in DumpRenderTree. The ARIA role is " + ariaRole + ", but should be AXIncrementor";
}
</script>
<div>
- <p>In accessibility, the following should be a progress indicator:</p>
+ <p>In accessibility, the following should be an incrementor:</p>
<p><span tabindex="0" role="spinbutton" id="spinbutton" aria-valuenow=5 aria-valuemin=0 aria-valuemax=10>X</span></p>
<span id="result"></span>
<script>
Modified: trunk/Source/WebCore/ChangeLog (122371 => 122372)
--- trunk/Source/WebCore/ChangeLog 2012-07-11 21:14:25 UTC (rev 122371)
+++ trunk/Source/WebCore/ChangeLog 2012-07-11 21:20:50 UTC (rev 122372)
@@ -1,3 +1,13 @@
+2012-07-11 Chris Fleizach <[email protected]>
+
+ ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
+ https://bugs.webkit.org/show_bug.cgi?id=77298
+
+ Reviewed by Anders Carlsson.
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::createARIARoleMap):
+
2012-07-11 Huang Dongsung <[email protected]>
BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is not initialized.
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (122371 => 122372)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2012-07-11 21:14:25 UTC (rev 122371)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2012-07-11 21:20:50 UTC (rev 122372)
@@ -1399,7 +1399,7 @@
{ "search", LandmarkSearchRole },
{ "separator", SplitterRole },
{ "slider", SliderRole },
- { "spinbutton", ProgressIndicatorRole },
+ { "spinbutton", SpinButtonRole },
{ "status", ApplicationStatusRole },
{ "tab", TabRole },
{ "tablist", TabListRole },
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes