Title: [122374] trunk/LayoutTests
Revision
122374
Author
[email protected]
Date
2012-07-11 14:52:22 -0700 (Wed, 11 Jul 2012)

Log Message

Simplify css3/flexbox/repaint-rtl-column.html
https://bugs.webkit.org/show_bug.cgi?id=91011

Reviewed by Tony Chang.

This test was doing something simple in a complicated way. Also, removing
the text should make it so that more ports can fallback to the same png.

* css3/flexbox/repaint-rtl-column-expected.txt:
* css3/flexbox/repaint-rtl-column.html:
* platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (122373 => 122374)


--- trunk/LayoutTests/ChangeLog	2012-07-11 21:38:43 UTC (rev 122373)
+++ trunk/LayoutTests/ChangeLog	2012-07-11 21:52:22 UTC (rev 122374)
@@ -1,3 +1,17 @@
+2012-07-11  Ojan Vafai  <[email protected]>
+
+        Simplify css3/flexbox/repaint-rtl-column.html
+        https://bugs.webkit.org/show_bug.cgi?id=91011
+
+        Reviewed by Tony Chang.
+
+        This test was doing something simple in a complicated way. Also, removing
+        the text should make it so that more ports can fallback to the same png.
+
+        * css3/flexbox/repaint-rtl-column-expected.txt:
+        * css3/flexbox/repaint-rtl-column.html:
+        * platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
+
 2012-07-11  Chris Fleizach  <[email protected]>
 
         ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole

Modified: trunk/LayoutTests/css3/flexbox/repaint-rtl-column-expected.txt (122373 => 122374)


--- trunk/LayoutTests/css3/flexbox/repaint-rtl-column-expected.txt	2012-07-11 21:38:43 UTC (rev 122373)
+++ trunk/LayoutTests/css3/flexbox/repaint-rtl-column-expected.txt	2012-07-11 21:52:22 UTC (rev 122374)
@@ -1,4 +1 @@
 
-
-
-Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean laoreet dolor id urna eleifend aliquet. Nulla vel dolor ipsum. Aliquam ut turpis nisl, in vulputate sapien. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Sed congue magna vitae dolor feugiat vehicula. Sed volutpat, tellus vel varius vestibulum, purus quam mollis sapien, in condimentum leo neque sed nulla. Nunc quis porta elit. Pellentesque erat lectus, ultricies a lobortis id, faucibus id quam.

Modified: trunk/LayoutTests/css3/flexbox/repaint-rtl-column.html (122373 => 122374)


--- trunk/LayoutTests/css3/flexbox/repaint-rtl-column.html	2012-07-11 21:38:43 UTC (rev 122373)
+++ trunk/LayoutTests/css3/flexbox/repaint-rtl-column.html	2012-07-11 21:52:22 UTC (rev 122374)
@@ -1,49 +1,34 @@
 <!DOCTYPE html>
-<html>
-<head>
 <style>
 #flexbox {
-  display: -webkit-flex;
-  -webkit-flex-flow: column;
-  height: 300px;
-  width: 200px;
+    display: -webkit-flex;
+    -webkit-flex-flow: column;
+    height: 300px;
+    width: 200px;
 }
-
 #left {
-  -webkit-flex: 1;
-  background-color: yellow;
-  width: 100%;
+    -webkit-flex: 1;
+    background-color: yellow;
 }
-
 #content {
-  -webkit-flex: 1;
-  background-color: grey;
-  width: 100%;
+    -webkit-flex: 1;
+    border: 5px solid blue;
 }
+#content > div {
+    height: 350px;
+    background-color: orange;
+}
 </style>
 <script>
 // This test makes sure that we repaint the right region of a flexbox when
 // changing the flex values. Only the middle of the test page should be
 // repainted. If the top of the test page (above the flexbox) is repainted,
 // this test fails.
-
-function setFlex(id, animationPercentage, start, end) {
-  var flexValue = start + ((end - start) * animationPercentage);
-  document.getElementById(id).style.webkitFlex = flexValue + " 0 0px";
+function setFlex(value)
+{
+    document.getElementById("content").style.webkitFlex = value;
 }
 
-function step(count) {
-    var animationPercentage = count ? 1 : .9;
-    setFlex("content", animationPercentage, 1, 5);
-
-    if (!count)
-        setTimeout(step.bind(null, 1));
-    else {
-        if (window.testRunner)
-            testRunner.notifyDone();
-    }
-}
-
 window._onload_ = function() {
     if (window.testRunner) {
         testRunner.dumpAsText(true);
@@ -51,18 +36,17 @@
         testRunner.display();
         testRunner.waitUntilDone();
     }
-    window.startTime = Date.now();
-
-    setTimeout(step.bind(null, 0), 0);
+    setTimeout(function() {
+        setFlex(4.6);
+        setTimeout(function() {
+            setFlex(5);
+            if (window.testRunner)
+                testRunner.notifyDone();
+        })
+    })
 };
 </script>
-</head>
-<body>
-<br><br><br>
+<div style="height: 60px"></div>
 <div id="flexbox" dir="rtl">
 <div id="left"></div>
-<div id="content">
-<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean laoreet dolor id urna eleifend aliquet. Nulla vel dolor ipsum. Aliquam ut turpis nisl, in vulputate sapien. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Sed congue magna vitae dolor feugiat vehicula. Sed volutpat, tellus vel varius vestibulum, purus quam mollis sapien, in condimentum leo neque sed nulla. Nunc quis porta elit. Pellentesque erat lectus, ultricies a lobortis id, faucibus id quam.</p>
-</div>
-</body>
-</html>
+<div id="content"><div></div></div>

Modified: trunk/LayoutTests/platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png


(Binary files differ)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to