Title: [124893] trunk/Source/WebCore
- Revision
- 124893
- Author
- [email protected]
- Date
- 2012-08-07 08:40:14 -0700 (Tue, 07 Aug 2012)
Log Message
Web Inspector: Typing backslash in Console traverses the panel history when using German keyboard layout
https://bugs.webkit.org/show_bug.cgi?id=93357
Reviewed by Vsevolod Vlasov.
For some reason, in the German keyboard layout keyIdentifier for '\' is the same as that for '['
in the ordinary English-US layout.
Remove a too-safe-side check and never switch panels on key combinations that result in "keypress" events.
* inspector/front-end/InspectorView.js:
(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype._keyPress):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (124892 => 124893)
--- trunk/Source/WebCore/ChangeLog 2012-08-07 15:28:57 UTC (rev 124892)
+++ trunk/Source/WebCore/ChangeLog 2012-08-07 15:40:14 UTC (rev 124893)
@@ -1,3 +1,18 @@
+2012-08-07 Alexander Pavlov <[email protected]>
+
+ Web Inspector: Typing backslash in Console traverses the panel history when using German keyboard layout
+ https://bugs.webkit.org/show_bug.cgi?id=93357
+
+ Reviewed by Vsevolod Vlasov.
+
+ For some reason, in the German keyboard layout keyIdentifier for '\' is the same as that for '['
+ in the ordinary English-US layout.
+ Remove a too-safe-side check and never switch panels on key combinations that result in "keypress" events.
+
+ * inspector/front-end/InspectorView.js:
+ (WebInspector.InspectorView):
+ (WebInspector.InspectorView.prototype._keyPress):
+
2012-08-07 Robin Cao <[email protected]>
[BlackBerry] GL scissor test is accidentally turned off
Modified: trunk/Source/WebCore/inspector/front-end/InspectorView.js (124892 => 124893)
--- trunk/Source/WebCore/inspector/front-end/InspectorView.js 2012-08-07 15:28:57 UTC (rev 124892)
+++ trunk/Source/WebCore/inspector/front-end/InspectorView.js 2012-08-07 15:40:14 UTC (rev 124893)
@@ -44,13 +44,9 @@
document.addEventListener("keypress", this._keyPress.bind(this), false);
this._panelOrder = [];
- // Windows and Mac have two different definitions of '[', so accept both.
+ // Windows and Mac have two different definitions of '[' and ']', so accept both of each.
this._openBracketIdentifiers = ["U+005B", "U+00DB"].keySet();
- this._openBracketCharCode = "[".charCodeAt(0);
-
- // Windows and Mac have two different definitions of ']', so accept both.
this._closeBracketIdentifiers = ["U+005D", "U+00DD"].keySet();
- this._closeBracketCharCode = "]".charCodeAt(0);
this._footerElementContainer = this.element.createChild("div", "inspector-footer status-bar hidden");
this._panelsElement = this.element.createChild("div", "fill");
}
@@ -98,13 +94,8 @@
_keyPress: function(event)
{
- if (!this._keyDownTimer)
- return;
-
- if (event.charCode === this._openBracketCharCode || event.charCode === this._closeBracketCharCode) {
- clearTimeout(this._keyDownTimer);
- delete this._keyDownTimer;
- }
+ clearTimeout(this._keyDownTimer);
+ delete this._keyDownTimer;
},
_keyDown: function(event)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
