Title: [124894] trunk/Source/WebCore
Revision
124894
Author
[email protected]
Date
2012-08-07 08:58:54 -0700 (Tue, 07 Aug 2012)

Log Message

[BlackBerry] We should fail the HTTP auth silently for non-main loads
in the non-viewer process.
https://bugs.webkit.org/show_bug.cgi?id=93230

Reviewed by Rob Buis.

No way to test this in WebKit.

* platform/network/blackberry/NetworkJob.cpp: Add early return.
(WebCore::NetworkJob::sendRequestWithCredentials):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (124893 => 124894)


--- trunk/Source/WebCore/ChangeLog	2012-08-07 15:40:14 UTC (rev 124893)
+++ trunk/Source/WebCore/ChangeLog	2012-08-07 15:58:54 UTC (rev 124894)
@@ -1,3 +1,16 @@
+2012-08-07  George Staikos  <[email protected]>
+
+        [BlackBerry] We should fail the HTTP auth silently for non-main loads
+        in the non-viewer process.
+        https://bugs.webkit.org/show_bug.cgi?id=93230
+
+        Reviewed by Rob Buis.
+
+        No way to test this in WebKit.
+
+        * platform/network/blackberry/NetworkJob.cpp: Add early return.
+        (WebCore::NetworkJob::sendRequestWithCredentials):
+
 2012-08-07  Alexander Pavlov  <[email protected]>
 
         Web Inspector: Typing backslash in Console traverses the panel history when using German keyboard layout

Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (124893 => 124894)


--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-08-07 15:40:14 UTC (rev 124893)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-08-07 15:58:54 UTC (rev 124894)
@@ -759,6 +759,8 @@
                 m_handle->getInternal()->m_user = "";
                 m_handle->getInternal()->m_pass = "";
             } else {
+                if (m_handle->firstRequest().targetType() != ResourceRequest::TargetIsMainFrame && BlackBerry::Platform::Client::isChromeProcess())
+                    return false;
                 Credential inputCredential;
                 if (!m_frame->page()->chrome()->client()->platformPageClient()->authenticationChallenge(newURL, protectionSpace, inputCredential))
                     return false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to