Diff
Modified: trunk/Source/WebKit/ChangeLog (124904 => 124905)
--- trunk/Source/WebKit/ChangeLog 2012-08-07 19:03:58 UTC (rev 124904)
+++ trunk/Source/WebKit/ChangeLog 2012-08-07 19:09:34 UTC (rev 124905)
@@ -1,3 +1,14 @@
+2012-08-07 Konrad Piascik <[email protected]>
+
+ [BlackBerry] InspectorOverlay class duplicated in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=93124
+
+ Reviewed by Rob Buis.
+
+ Updated InspectorOverlay build path.
+
+ * PlatformBlackBerry.cmake:
+
2012-08-07 No'am Rosenthal <[email protected]>
[Qt] Make it possible to build without QtQuick
Modified: trunk/Source/WebKit/PlatformBlackBerry.cmake (124904 => 124905)
--- trunk/Source/WebKit/PlatformBlackBerry.cmake 2012-08-07 19:03:58 UTC (rev 124904)
+++ trunk/Source/WebKit/PlatformBlackBerry.cmake 2012-08-07 19:09:34 UTC (rev 124905)
@@ -84,7 +84,6 @@
blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp
blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp
blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp
- blackberry/WebCoreSupport/InspectorOverlay.cpp
blackberry/WebCoreSupport/_javascript_DebuggerBlackBerry.cpp
blackberry/WebCoreSupport/NotificationPresenterImpl.cpp
blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp
@@ -102,6 +101,7 @@
blackberry/WebKitSupport/InputHandler.cpp
blackberry/WebKitSupport/InRegionScrollableArea.cpp
blackberry/WebKitSupport/InRegionScroller.cpp
+ blackberry/WebKitSupport/InspectorOverlay.cpp
blackberry/WebKitSupport/RenderQueue.cpp
blackberry/WebKitSupport/SelectionHandler.cpp
blackberry/WebKitSupport/SelectionOverlay.cpp
Modified: trunk/Source/WebKit/blackberry/ChangeLog (124904 => 124905)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-08-07 19:03:58 UTC (rev 124904)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-08-07 19:09:34 UTC (rev 124905)
@@ -1,3 +1,31 @@
+2012-08-07 Konrad Piascik <[email protected]>
+
+ [BlackBerry] InspectorOverlay class duplicated in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=93124
+
+ Reviewed by Rob Buis.
+
+ Moved files to better align with namespace names.
+
+ * WebKitSupport/InspectorOverlay.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp.
+ (WebKit):
+ (BlackBerry::WebKit::InspectorOverlay::create):
+ (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
+ (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
+ (BlackBerry::WebKit::InspectorOverlay::paintContents):
+ (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
+ (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
+ (BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
+ (BlackBerry::WebKit::InspectorOverlay::clear):
+ (BlackBerry::WebKit::InspectorOverlay::update):
+ * WebKitSupport/InspectorOverlay.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h.
+ (WebCore):
+ (WebKit):
+ (InspectorOverlay):
+ (InspectorOverlayClient):
+ (BlackBerry::WebKit::InspectorOverlay::setClient):
+ (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
+
2012-08-07 Mike Fenton <[email protected]>
[BlackBerry] Update API for spell checking suggestions.
Deleted: trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp (124904 => 124905)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp 2012-08-07 19:03:58 UTC (rev 124904)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp 2012-08-07 19:09:34 UTC (rev 124905)
@@ -1,99 +0,0 @@
-/*
- * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-#include "config.h"
-
-#include "InspectorOverlay.h"
-
-#include "Frame.h"
-#include "FrameView.h"
-#include "GraphicsContext.h"
-#include "GraphicsLayer.h"
-#include "WebPage_p.h"
-
-
-namespace BlackBerry {
-namespace WebKit {
-
-PassOwnPtr<InspectorOverlay> InspectorOverlay::create(WebPagePrivate* page, InspectorOverlayClient* client)
-{
- return adoptPtr(new InspectorOverlay(page, client));
-}
-
-InspectorOverlay::InspectorOverlay(WebPagePrivate* page, InspectorOverlayClient* client)
- : m_webPage(page)
- , m_client(client)
-{
-}
-
-#if USE(ACCELERATED_COMPOSITING)
-void InspectorOverlay::notifySyncRequired(const WebCore::GraphicsLayer* layer)
-{
- m_webPage->notifySyncRequired(layer);
-}
-
-void InspectorOverlay::paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext& context, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip)
-{
- context.save();
- WebCore::IntPoint scrollPosition = m_webPage->focusedOrMainFrame()->view()->scrollPosition();
- context.translate(scrollPosition.x(), scrollPosition.y());
- m_client->paintInspectorOverlay(context);
- context.restore();
-}
-
-bool InspectorOverlay::showDebugBorders(const WebCore::GraphicsLayer* layer) const
-{
- return m_webPage->showDebugBorders(layer);
-}
-
-bool InspectorOverlay::showRepaintCounter(const WebCore::GraphicsLayer* layer) const
-{
- return m_webPage->showRepaintCounter(layer);
-}
-#endif
-
-InspectorOverlay::~InspectorOverlay() { }
-
-void InspectorOverlay::clear()
-{
-#if USE(ACCELERATED_COMPOSITING)
- if (m_overlay) {
- m_overlay->removeFromParent();
- m_overlay = nullptr;
- }
-#endif
-}
-
-void InspectorOverlay::update()
-{
-#if USE(ACCELERATED_COMPOSITING)
- if (!m_overlay) {
- m_overlay = adoptPtr(new WebOverlay(this));
- const WebCore::IntSize size = m_webPage->contentsSize();
- m_overlay->setSize(WebCore::FloatSize(size.width(), size.height()));
- m_webPage->m_webPage->addOverlay(m_overlay.get());
- }
-
- m_overlay->setDrawsContent(true);
- m_overlay->setOpacity(1.0);
- m_overlay->invalidate();
-#endif
-}
-
-}
-}
Deleted: trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h (124904 => 124905)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h 2012-08-07 19:03:58 UTC (rev 124904)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h 2012-08-07 19:09:34 UTC (rev 124905)
@@ -1,73 +0,0 @@
-/*
- * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-#ifndef InspectorOverlay_h
-#define InspectorOverlay_h
-
-#include "WebOverlay.h"
-#include <GraphicsLayerClient.h>
-#include <wtf/OwnPtr.h>
-#include <wtf/PassOwnPtr.h>
-
-namespace WebCore {
-class GraphicsContext;
-class GraphicsLayer;
-}
-
-namespace BlackBerry {
-namespace WebKit {
-class WebPagePrivate;
-
-class InspectorOverlay : public WebCore::GraphicsLayerClient {
-public:
- class InspectorOverlayClient {
- public:
- virtual void paintInspectorOverlay(WebCore::GraphicsContext&) = 0;
- };
-
- static PassOwnPtr<InspectorOverlay> create(WebPagePrivate*, InspectorOverlayClient*);
-
- ~InspectorOverlay();
-
- void setClient(InspectorOverlayClient* client) { m_client = client; }
-
- void clear();
- void update();
- void paintWebFrame(WebCore::GraphicsContext&);
-
-#if USE(ACCELERATED_COMPOSITING)
- virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
- virtual void notifySyncRequired(const WebCore::GraphicsLayer*);
- virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
- virtual bool showDebugBorders(const WebCore::GraphicsLayer*) const;
- virtual bool showRepaintCounter(const WebCore::GraphicsLayer*) const;
-#endif
-
-private:
- InspectorOverlay(WebPagePrivate*, InspectorOverlayClient*);
- void invalidateWebFrame();
-
- WebPagePrivate* m_webPage;
- InspectorOverlayClient* m_client;
- OwnPtr<WebOverlay> m_overlay;
-};
-
-} // namespace WebKit
-} // namespace BlackBerry
-
-#endif /* InspectorOverlay_h */
Copied: trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp (from rev 124904, trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp) (0 => 124905)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp (rev 0)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp 2012-08-07 19:09:34 UTC (rev 124905)
@@ -0,0 +1,99 @@
+/*
+ * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include "config.h"
+
+#include "InspectorOverlay.h"
+
+#include "Frame.h"
+#include "FrameView.h"
+#include "GraphicsContext.h"
+#include "GraphicsLayer.h"
+#include "WebPage_p.h"
+
+
+namespace BlackBerry {
+namespace WebKit {
+
+PassOwnPtr<InspectorOverlay> InspectorOverlay::create(WebPagePrivate* page, InspectorOverlayClient* client)
+{
+ return adoptPtr(new InspectorOverlay(page, client));
+}
+
+InspectorOverlay::InspectorOverlay(WebPagePrivate* page, InspectorOverlayClient* client)
+ : m_webPage(page)
+ , m_client(client)
+{
+}
+
+#if USE(ACCELERATED_COMPOSITING)
+void InspectorOverlay::notifySyncRequired(const WebCore::GraphicsLayer* layer)
+{
+ m_webPage->notifySyncRequired(layer);
+}
+
+void InspectorOverlay::paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext& context, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip)
+{
+ context.save();
+ WebCore::IntPoint scrollPosition = m_webPage->focusedOrMainFrame()->view()->scrollPosition();
+ context.translate(scrollPosition.x(), scrollPosition.y());
+ m_client->paintInspectorOverlay(context);
+ context.restore();
+}
+
+bool InspectorOverlay::showDebugBorders(const WebCore::GraphicsLayer* layer) const
+{
+ return m_webPage->showDebugBorders(layer);
+}
+
+bool InspectorOverlay::showRepaintCounter(const WebCore::GraphicsLayer* layer) const
+{
+ return m_webPage->showRepaintCounter(layer);
+}
+#endif
+
+InspectorOverlay::~InspectorOverlay() { }
+
+void InspectorOverlay::clear()
+{
+#if USE(ACCELERATED_COMPOSITING)
+ if (m_overlay) {
+ m_overlay->removeFromParent();
+ m_overlay = nullptr;
+ }
+#endif
+}
+
+void InspectorOverlay::update()
+{
+#if USE(ACCELERATED_COMPOSITING)
+ if (!m_overlay) {
+ m_overlay = adoptPtr(new WebOverlay(this));
+ const WebCore::IntSize size = m_webPage->contentsSize();
+ m_overlay->setSize(WebCore::FloatSize(size.width(), size.height()));
+ m_webPage->m_webPage->addOverlay(m_overlay.get());
+ }
+
+ m_overlay->setDrawsContent(true);
+ m_overlay->setOpacity(1.0);
+ m_overlay->invalidate();
+#endif
+}
+
+}
+}
Copied: trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h (from rev 124904, trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h) (0 => 124905)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h (rev 0)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h 2012-08-07 19:09:34 UTC (rev 124905)
@@ -0,0 +1,73 @@
+/*
+ * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#ifndef InspectorOverlay_h
+#define InspectorOverlay_h
+
+#include "WebOverlay.h"
+#include <GraphicsLayerClient.h>
+#include <wtf/OwnPtr.h>
+#include <wtf/PassOwnPtr.h>
+
+namespace WebCore {
+class GraphicsContext;
+class GraphicsLayer;
+}
+
+namespace BlackBerry {
+namespace WebKit {
+class WebPagePrivate;
+
+class InspectorOverlay : public WebCore::GraphicsLayerClient {
+public:
+ class InspectorOverlayClient {
+ public:
+ virtual void paintInspectorOverlay(WebCore::GraphicsContext&) = 0;
+ };
+
+ static PassOwnPtr<InspectorOverlay> create(WebPagePrivate*, InspectorOverlayClient*);
+
+ ~InspectorOverlay();
+
+ void setClient(InspectorOverlayClient* client) { m_client = client; }
+
+ void clear();
+ void update();
+ void paintWebFrame(WebCore::GraphicsContext&);
+
+#if USE(ACCELERATED_COMPOSITING)
+ virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { }
+ virtual void notifySyncRequired(const WebCore::GraphicsLayer*);
+ virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
+ virtual bool showDebugBorders(const WebCore::GraphicsLayer*) const;
+ virtual bool showRepaintCounter(const WebCore::GraphicsLayer*) const;
+#endif
+
+private:
+ InspectorOverlay(WebPagePrivate*, InspectorOverlayClient*);
+ void invalidateWebFrame();
+
+ WebPagePrivate* m_webPage;
+ InspectorOverlayClient* m_client;
+ OwnPtr<WebOverlay> m_overlay;
+};
+
+} // namespace WebKit
+} // namespace BlackBerry
+
+#endif /* InspectorOverlay_h */
