- Revision
- 124906
- Author
- [email protected]
- Date
- 2012-08-07 12:25:55 -0700 (Tue, 07 Aug 2012)
Log Message
[chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
https://bugs.webkit.org/show_bug.cgi?id=93286
Reviewed by James Robinson.
Tools:
Adds support to generate GestureTapDown events from EventSender, to facilitate
link highlighting layout tests.
Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.
* DumpRenderTree/chromium/TestRunner/EventSender.cpp:
(EventSender::EventSender):
(EventSender::gestureTapDown):
(EventSender::gestureEvent):
* DumpRenderTree/chromium/TestRunner/EventSender.h:
(EventSender):
LayoutTests:
Adds support to generate GestureTapDown events from EventSender, to facilitate
link highlighting layout tests.
Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.
* platform/chromium/plugins/gesture-events-expected.txt:
* platform/chromium/plugins/gesture-events.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (124905 => 124906)
--- trunk/LayoutTests/ChangeLog 2012-08-07 19:09:34 UTC (rev 124905)
+++ trunk/LayoutTests/ChangeLog 2012-08-07 19:25:55 UTC (rev 124906)
@@ -1,3 +1,18 @@
+2012-08-07 W. James MacLean <[email protected]>
+
+ [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
+ https://bugs.webkit.org/show_bug.cgi?id=93286
+
+ Reviewed by James Robinson.
+
+ Adds support to generate GestureTapDown events from EventSender, to facilitate
+ link highlighting layout tests.
+
+ Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.
+
+ * platform/chromium/plugins/gesture-events-expected.txt:
+ * platform/chromium/plugins/gesture-events.html:
+
2012-08-07 Marcelo Lira <[email protected]>
[Qt] Add support for the Gamepad API
Modified: trunk/LayoutTests/platform/chromium/plugins/gesture-events-expected.txt (124905 => 124906)
--- trunk/LayoutTests/platform/chromium/plugins/gesture-events-expected.txt 2012-08-07 19:09:34 UTC (rev 124905)
+++ trunk/LayoutTests/platform/chromium/plugins/gesture-events-expected.txt 2012-08-07 19:25:55 UTC (rev 124906)
@@ -3,6 +3,7 @@
Plugin received event: MouseMove
Plugin received event: MouseDown
Plugin received event: MouseUp
+Plugin received event: GestureTapDown
Plugin received event: GestureScrollBegin
Plugin received event: GestureScrollUpdate
Plugin received event: MouseWheel
Modified: trunk/LayoutTests/platform/chromium/plugins/gesture-events.html (124905 => 124906)
--- trunk/LayoutTests/platform/chromium/plugins/gesture-events.html 2012-08-07 19:09:34 UTC (rev 124905)
+++ trunk/LayoutTests/platform/chromium/plugins/gesture-events.html 2012-08-07 19:25:55 UTC (rev 124906)
@@ -21,6 +21,7 @@
var positionX = plugin.offsetLeft + 10;
var positionY = plugin.offsetTop + 10;
eventSender.gestureTap(positionX, positionY);
+ eventSender.gestureTapDown(positionX, positionY);
eventSender.gestureScrollBegin(positionX, positionY);
eventSender.gestureScrollUpdate(30, 0);
eventSender.gestureScrollEnd(0, 0);
Modified: trunk/Tools/ChangeLog (124905 => 124906)
--- trunk/Tools/ChangeLog 2012-08-07 19:09:34 UTC (rev 124905)
+++ trunk/Tools/ChangeLog 2012-08-07 19:25:55 UTC (rev 124906)
@@ -1,3 +1,22 @@
+2012-08-07 W. James MacLean <[email protected]>
+
+ [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
+ https://bugs.webkit.org/show_bug.cgi?id=93286
+
+ Reviewed by James Robinson.
+
+ Adds support to generate GestureTapDown events from EventSender, to facilitate
+ link highlighting layout tests.
+
+ Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.
+
+ * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
+ (EventSender::EventSender):
+ (EventSender::gestureTapDown):
+ (EventSender::gestureEvent):
+ * DumpRenderTree/chromium/TestRunner/EventSender.h:
+ (EventSender):
+
2012-08-07 Marcelo Lira <[email protected]>
[Qt] Add support for the Gamepad API
Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp (124905 => 124906)
--- trunk/Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp 2012-08-07 19:09:34 UTC (rev 124905)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp 2012-08-07 19:25:55 UTC (rev 124906)
@@ -286,6 +286,7 @@
bindMethod("gestureScrollFirstPoint", &EventSender::gestureScrollFirstPoint);
bindMethod("gestureScrollUpdate", &EventSender::gestureScrollUpdate);
bindMethod("gestureTap", &EventSender::gestureTap);
+ bindMethod("gestureTapDown", &EventSender::gestureTapDown);
bindMethod("gestureLongPress", &EventSender::gestureLongPress);
bindMethod("gestureTwoFingerTap", &EventSender::gestureTwoFingerTap);
bindMethod("zoomPageIn", &EventSender::zoomPageIn);
@@ -1112,6 +1113,12 @@
gestureEvent(WebInputEvent::GestureTap, arguments);
}
+void EventSender::gestureTapDown(const CppArgumentList& arguments, CppVariant* result)
+{
+ result->setNull();
+ gestureEvent(WebInputEvent::GestureTapDown, arguments);
+}
+
void EventSender::gestureLongPress(const CppArgumentList& arguments, CppVariant* result)
{
result->setNull();
@@ -1173,6 +1180,10 @@
event.x = point.x;
event.y = point.y;
break;
+ case WebInputEvent::GestureTapDown:
+ event.x = point.x;
+ event.y = point.y;
+ break;
case WebInputEvent::GestureLongPress:
event.x = point.x;
event.y = point.y;
Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/EventSender.h (124905 => 124906)
--- trunk/Tools/DumpRenderTree/chromium/TestRunner/EventSender.h 2012-08-07 19:09:34 UTC (rev 124905)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/EventSender.h 2012-08-07 19:25:55 UTC (rev 124906)
@@ -105,6 +105,7 @@
void gestureScrollFirstPoint(const CppArgumentList&, CppVariant*);
void gestureScrollUpdate(const CppArgumentList&, CppVariant*);
void gestureTap(const CppArgumentList&, CppVariant*);
+ void gestureTapDown(const CppArgumentList&, CppVariant*);
void gestureLongPress(const CppArgumentList&, CppVariant*);
void gestureTwoFingerTap(const CppArgumentList&, CppVariant*);
void gestureEvent(WebKit::WebInputEvent::Type, const CppArgumentList&);
