Title: [125672] trunk/Source/WebCore
- Revision
- 125672
- Author
- [email protected]
- Date
- 2012-08-15 06:53:53 -0700 (Wed, 15 Aug 2012)
Log Message
Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.
https://bugs.webkit.org/show_bug.cgi?id=94098
Reviewed by Pavel Feldman.
SourceFrame listeners and _currentFile field are now cleared only when currently open tab is closed.
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (125671 => 125672)
--- trunk/Source/WebCore/ChangeLog 2012-08-15 13:50:14 UTC (rev 125671)
+++ trunk/Source/WebCore/ChangeLog 2012-08-15 13:53:53 UTC (rev 125672)
@@ -1,5 +1,17 @@
2012-08-15 Vsevolod Vlasov <[email protected]>
+ Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.
+ https://bugs.webkit.org/show_bug.cgi?id=94098
+
+ Reviewed by Pavel Feldman.
+
+ SourceFrame listeners and _currentFile field are now cleared only when currently open tab is closed.
+
+ * inspector/front-end/TabbedEditorContainer.js:
+ (WebInspector.TabbedEditorContainer.prototype._tabClosed):
+
+2012-08-15 Vsevolod Vlasov <[email protected]>
+
Web Inspector: [REGRESSION] "save as" of edited source in developer mode fails to update saved file
https://bugs.webkit.org/show_bug.cgi?id=94074
Modified: trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js (125671 => 125672)
--- trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js 2012-08-15 13:50:14 UTC (rev 125671)
+++ trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js 2012-08-15 13:53:53 UTC (rev 125672)
@@ -292,11 +292,13 @@
var tabId = /** @type {string} */ event.data.tabId;
var userGesture = /** @type {boolean} */ event.data.isUserGesture;
- this._removeScrollAndSelectionListeners();
var uiSourceCode = this._files[tabId];
+ if (this._currentFile === uiSourceCode) {
+ this._removeScrollAndSelectionListeners();
+ delete this._currentFile;
+ }
this._tabIds.remove(uiSourceCode);
delete this._files[tabId];
- delete this._currentFile;
uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.TitleChanged, this._uiSourceCodeTitleChanged, this);
uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.WorkingCopyChanged, this._uiSourceCodeWorkingCopyChanged, this);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
