[webkit-changes] [125673] trunk/Source/WebCore

Wed, 15 Aug 2012 06:58:14 -0700

Title: [125673] trunk/Source/WebCore
Revision
125673
Author
[email protected]
Date
2012-08-15 06:58:40 -0700 (Wed, 15 Aug 2012)

Log Message

Web Inspector: TabbedEditorContainer Doens't show '*' near modified file name sometimes.
https://bugs.webkit.org/show_bug.cgi?id=94095

Reviewed by Pavel Feldman.

TabbedEditorContainer now correctly updates event listeners on UISourceCodeReplaced event.

* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._addUISourceCodeListeners):
(WebInspector.TabbedEditorContainer.prototype._removeUISourceCodeListeners):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (125672 => 125673)


--- trunk/Source/WebCore/ChangeLog	2012-08-15 13:53:53 UTC (rev 125672)
+++ trunk/Source/WebCore/ChangeLog	2012-08-15 13:58:40 UTC (rev 125673)
@@ -1,5 +1,20 @@
 2012-08-15  Vsevolod Vlasov  <[email protected]>
 
+        Web Inspector: TabbedEditorContainer Doens't show '*' near modified file name sometimes.
+        https://bugs.webkit.org/show_bug.cgi?id=94095
+
+        Reviewed by Pavel Feldman.
+
+        TabbedEditorContainer now correctly updates event listeners on UISourceCodeReplaced event.
+
+        * inspector/front-end/TabbedEditorContainer.js:
+        (WebInspector.TabbedEditorContainer.prototype._appendFileTab):
+        (WebInspector.TabbedEditorContainer.prototype._tabClosed):
+        (WebInspector.TabbedEditorContainer.prototype._addUISourceCodeListeners):
+        (WebInspector.TabbedEditorContainer.prototype._removeUISourceCodeListeners):
+
+2012-08-15  Vsevolod Vlasov  <[email protected]>
+
         Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.
         https://bugs.webkit.org/show_bug.cgi?id=94098

Modified: trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js (125672 => 125673)


--- trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js	2012-08-15 13:53:53 UTC (rev 125672)
+++ trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js	2012-08-15 13:58:40 UTC (rev 125673)
@@ -278,9 +278,7 @@
 
         this._tabbedPane.appendTab(tabId, title, view, tooltip, userGesture);
 
-        uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.TitleChanged, this._uiSourceCodeTitleChanged, this);
-        uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.WorkingCopyChanged, this._uiSourceCodeWorkingCopyChanged, this);
-        uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.ContentChanged, this._uiSourceCodeContentChanged, this);
+        this._addUISourceCodeListeners(uiSourceCode);
         return tabId;
     },
 
@@ -300,9 +298,7 @@
         this._tabIds.remove(uiSourceCode);
         delete this._files[tabId];
 
-        uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.TitleChanged, this._uiSourceCodeTitleChanged, this);
-        uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.WorkingCopyChanged, this._uiSourceCodeWorkingCopyChanged, this);
-        uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.ContentChanged, this._uiSourceCodeContentChanged, this);
+        this._removeUISourceCodeListeners(uiSourceCode);
 
         this.dispatchEventToListeners(WebInspector.TabbedEditorContainer.Events.EditorClosed, uiSourceCode);
 
@@ -341,11 +337,34 @@
         this._tabbedPane.changeTabTitle(tabId, this._titleForFile(uiSourceCode));
         this._tabbedPane.changeTabView(tabId, this._delegate.viewForFile(uiSourceCode));
         this._tabbedPane.changeTabTooltip(tabId, this._tooltipForFile(uiSourceCode));
+
+        this._removeUISourceCodeListeners(oldUISourceCode);
+        this._addUISourceCodeListeners(uiSourceCode);
     },
 
     /**
      * @param {WebInspector.UISourceCode} uiSourceCode
      */
+    _addUISourceCodeListeners: function(uiSourceCode)
+    {
+        uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.TitleChanged, this._uiSourceCodeTitleChanged, this);
+        uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.WorkingCopyChanged, this._uiSourceCodeWorkingCopyChanged, this);
+        uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.ContentChanged, this._uiSourceCodeContentChanged, this);
+    },
+
+    /**
+     * @param {WebInspector.UISourceCode} uiSourceCode
+     */
+    _removeUISourceCodeListeners: function(uiSourceCode)
+    {
+        uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.TitleChanged, this._uiSourceCodeTitleChanged, this);
+        uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.WorkingCopyChanged, this._uiSourceCodeWorkingCopyChanged, this);
+        uiSourceCode.removeEventListener(WebInspector.UISourceCode.Events.ContentChanged, this._uiSourceCodeContentChanged, this);
+    },
+
+    /**
+     * @param {WebInspector.UISourceCode} uiSourceCode
+     */
     _updateFileTitle: function(uiSourceCode)
     {
         var tabId = this._tabIds.get(uiSourceCode);

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to