Title: [126722] trunk/Source/_javascript_Core
- Revision
- 126722
- Author
- [email protected]
- Date
- 2012-08-26 21:12:11 -0700 (Sun, 26 Aug 2012)
Log Message
Don't allocate space for arguments and call frame if arguments aren't captured
https://bugs.webkit.org/show_bug.cgi?id=95024
Reviewed by Phil Pizlo.
27% on v8-real-earley.
* runtime/JSActivation.h:
(JSC::JSActivation::registerOffset): The offset is zero if we're skipping
the arguments and call frame because "offset" means space reserved for
those things.
(JSC::JSActivation::tearOff): Don't copy the scope chain and callee. We
don't need them for anything, and we're no longer guaranteed to have
space for them.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (126721 => 126722)
--- trunk/Source/_javascript_Core/ChangeLog 2012-08-27 03:57:02 UTC (rev 126721)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-08-27 04:12:11 UTC (rev 126722)
@@ -1,5 +1,23 @@
2012-08-26 Geoffrey Garen <[email protected]>
+ Don't allocate space for arguments and call frame if arguments aren't captured
+ https://bugs.webkit.org/show_bug.cgi?id=95024
+
+ Reviewed by Phil Pizlo.
+
+ 27% on v8-real-earley.
+
+ * runtime/JSActivation.h:
+ (JSC::JSActivation::registerOffset): The offset is zero if we're skipping
+ the arguments and call frame because "offset" means space reserved for
+ those things.
+
+ (JSC::JSActivation::tearOff): Don't copy the scope chain and callee. We
+ don't need them for anything, and we're no longer guaranteed to have
+ space for them.
+
+2012-08-26 Geoffrey Garen <[email protected]>
+
Removed the NULL checks from visitChildren functions
https://bugs.webkit.org/show_bug.cgi?id=95021
Modified: trunk/Source/_javascript_Core/runtime/JSActivation.h (126721 => 126722)
--- trunk/Source/_javascript_Core/runtime/JSActivation.h 2012-08-27 03:57:02 UTC (rev 126721)
+++ trunk/Source/_javascript_Core/runtime/JSActivation.h 2012-08-27 04:12:11 UTC (rev 126722)
@@ -124,6 +124,9 @@
inline size_t JSActivation::registerOffset()
{
+ if (!m_numCapturedArgs)
+ return 0;
+
size_t capturedArgumentCountIncludingThis = m_numCapturedArgs + 1;
return CallFrame::offsetFor(capturedArgumentCountIncludingThis);
}
@@ -155,10 +158,6 @@
for (int i = from; i < to; ++i)
registers[i].set(globalData, this, m_registers[i].get());
- // CallFrame
- registers[RegisterFile::ScopeChain].set(globalData, this, m_registers[RegisterFile::ScopeChain].get());
- registers[RegisterFile::Callee].set(globalData, this, m_registers[RegisterFile::Callee].get());
-
// vars
from = 0;
to = m_numCapturedVars;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
