Title: [126723] trunk/Source/_javascript_Core
- Revision
- 126723
- Author
- [email protected]
- Date
- 2012-08-26 21:23:14 -0700 (Sun, 26 Aug 2012)
Log Message
Unreviewed, fix for builds without VALUE_PROFILING. I had forgotten that shouldEmitProfiling()
is designed to return true if DFG_JIT is disabled. I should be using canBeOptimized() instead.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (126722 => 126723)
--- trunk/Source/_javascript_Core/ChangeLog 2012-08-27 04:12:11 UTC (rev 126722)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-08-27 04:23:14 UTC (rev 126723)
@@ -1,3 +1,13 @@
+2012-08-26 Filip Pizlo <[email protected]>
+
+ Unreviewed, fix for builds without VALUE_PROFILING. I had forgotten that shouldEmitProfiling()
+ is designed to return true if DFG_JIT is disabled. I should be using canBeOptimized() instead.
+
+ * jit/JITCall.cpp:
+ (JSC::JIT::compileOpCall):
+ * jit/JITCall32_64.cpp:
+ (JSC::JIT::compileOpCall):
+
2012-08-26 Geoffrey Garen <[email protected]>
Don't allocate space for arguments and call frame if arguments aren't captured
Modified: trunk/Source/_javascript_Core/jit/JITCall.cpp (126722 => 126723)
--- trunk/Source/_javascript_Core/jit/JITCall.cpp 2012-08-27 04:12:11 UTC (rev 126722)
+++ trunk/Source/_javascript_Core/jit/JITCall.cpp 2012-08-27 04:23:14 UTC (rev 126723)
@@ -160,7 +160,7 @@
int argCount = instruction[2].u.operand;
int registerOffset = instruction[3].u.operand;
- if (opcodeID == op_call && shouldEmitProfiling()) {
+ if (opcodeID == op_call && canBeOptimized()) {
emitGetVirtualRegister(registerOffset + CallFrame::argumentOffsetIncludingThis(0), regT0);
Jump done = emitJumpIfNotJSCell(regT0);
loadPtr(Address(regT0, JSCell::structureOffset()), regT0);
Modified: trunk/Source/_javascript_Core/jit/JITCall32_64.cpp (126722 => 126723)
--- trunk/Source/_javascript_Core/jit/JITCall32_64.cpp 2012-08-27 04:12:11 UTC (rev 126722)
+++ trunk/Source/_javascript_Core/jit/JITCall32_64.cpp 2012-08-27 04:23:14 UTC (rev 126723)
@@ -237,7 +237,7 @@
int argCount = instruction[2].u.operand;
int registerOffset = instruction[3].u.operand;
- if (opcodeID == op_call && shouldEmitProfiling()) {
+ if (opcodeID == op_call && canBeOptimized()) {
emitLoad(registerOffset + CallFrame::argumentOffsetIncludingThis(0), regT0, regT1);
Jump done = branch32(NotEqual, regT0, TrustedImm32(JSValue::CellTag));
loadPtr(Address(regT1, JSCell::structureOffset()), regT1);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
