Title: [127137] trunk
- Revision
- 127137
- Author
- [email protected]
- Date
- 2012-08-30 07:42:53 -0700 (Thu, 30 Aug 2012)
Log Message
[WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
https://bugs.webkit.org/show_bug.cgi?id=95454
Patch by Mikhail Pozdnyakov <[email protected]> on 2012-08-30
Reviewed by Kenneth Rohde Christiansen.
Tools:
Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
LayoutTests:
Unskipped http/tests/loading/307-after-303-after-post.html.
Output for http/tests/loading/redirect-methods.html is improved.
* platform/wk2/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (127136 => 127137)
--- trunk/LayoutTests/ChangeLog 2012-08-30 14:40:20 UTC (rev 127136)
+++ trunk/LayoutTests/ChangeLog 2012-08-30 14:42:53 UTC (rev 127137)
@@ -1,3 +1,15 @@
+2012-08-30 Mikhail Pozdnyakov <[email protected]>
+
+ [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
+ https://bugs.webkit.org/show_bug.cgi?id=95454
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskipped http/tests/loading/307-after-303-after-post.html.
+ Output for http/tests/loading/redirect-methods.html is improved.
+
+ * platform/wk2/Skipped:
+
2012-08-30 Andrey Kosyakov <[email protected]>
REGRESSION(r127039): It broke inspector/timeline/timeline-load.html fails on many platforms
Modified: trunk/LayoutTests/platform/wk2/Skipped (127136 => 127137)
--- trunk/LayoutTests/platform/wk2/Skipped 2012-08-30 14:40:20 UTC (rev 127136)
+++ trunk/LayoutTests/platform/wk2/Skipped 2012-08-30 14:42:53 UTC (rev 127137)
@@ -677,10 +677,6 @@
# WebKitTestRunner needs layoutTestController.setWillSendRequestReturnNullOnRedirect
http/tests/misc/will-send-request-returns-null-on-redirect.html
-# WebKitTestRunner needs ReceiveServerRedirectForProvisionalLoadForFrame logging
-http/tests/loading/307-after-303-after-post.html
-http/tests/loading/redirect-methods.html
-
# WebKitTestrunner needs layoutTestController.dumpSourceAsWebArchive
webarchive/doctype.html
webarchive/archive-empty-frame-source.html
@@ -926,6 +922,9 @@
# https://bugs.webkit.org/show_bug.cgi?id=85558
http/tests/security/contentSecurityPolicy/1.1
+# Unexpected redirection happens.
+http/tests/loading/redirect-methods.html
+
# Should pass now but need to be checked first.
platform/mac/fast/loader/file-url-mimetypes-2.html
platform/mac/fast/loader/file-url-mimetypes-3.html
Modified: trunk/Tools/ChangeLog (127136 => 127137)
--- trunk/Tools/ChangeLog 2012-08-30 14:40:20 UTC (rev 127136)
+++ trunk/Tools/ChangeLog 2012-08-30 14:42:53 UTC (rev 127137)
@@ -1,3 +1,15 @@
+2012-08-30 Mikhail Pozdnyakov <[email protected]>
+
+ [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
+ https://bugs.webkit.org/show_bug.cgi?id=95454
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
+
+ * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+ (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
+
2012-08-30 Leo Yang <[email protected]>
Update my email address.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (127136 => 127137)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2012-08-30 14:40:20 UTC (rev 127136)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2012-08-30 14:42:53 UTC (rev 127137)
@@ -723,6 +723,14 @@
void InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame(WKBundleFrameRef frame)
{
+ if (!InjectedBundle::shared().isTestRunning())
+ return;
+
+ if (!InjectedBundle::shared().testRunner()->shouldDumpFrameLoadCallbacks())
+ return;
+
+ dumpFrameDescriptionSuitableForTestResult(frame);
+ InjectedBundle::shared().stringBuilder()->append(" - didReceiveServerRedirectForProvisionalLoadForFrame\n");
}
void InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame(WKBundleFrameRef frame, WKErrorRef error)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes