Title: [127138] trunk/Source/WebCore
- Revision
- 127138
- Author
- [email protected]
- Date
- 2012-08-30 07:45:28 -0700 (Thu, 30 Aug 2012)
Log Message
Web Inspector: [regression] ui: selectors in heap profiler view have no arrows at the right side of the text.
https://bugs.webkit.org/show_bug.cgi?id=95455
Reviewed by Yury Semikhatsky.
In console we use a span which wraps selectors and have necessary background.
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.get statusBarItems.appendArrowImage):
(WebInspector.HeapSnapshotView.prototype.get statusBarItems):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (127137 => 127138)
--- trunk/Source/WebCore/ChangeLog 2012-08-30 14:42:53 UTC (rev 127137)
+++ trunk/Source/WebCore/ChangeLog 2012-08-30 14:45:28 UTC (rev 127138)
@@ -1,3 +1,16 @@
+2012-08-30 Ilya Tikhonovsky <[email protected]>
+
+ Web Inspector: [regression] ui: selectors in heap profiler view have no arrows at the right side of the text.
+ https://bugs.webkit.org/show_bug.cgi?id=95455
+
+ Reviewed by Yury Semikhatsky.
+
+ In console we use a span which wraps selectors and have necessary background.
+
+ * inspector/front-end/HeapSnapshotView.js:
+ (WebInspector.HeapSnapshotView.prototype.get statusBarItems.appendArrowImage):
+ (WebInspector.HeapSnapshotView.prototype.get statusBarItems):
+
2012-08-30 Andrew Lo <[email protected]>
[BlackBerry] LayerTiler needs to respect new setting for prefill rect.
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js (127137 => 127138)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js 2012-08-30 14:42:53 UTC (rev 127137)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js 2012-08-30 14:45:28 UTC (rev 127138)
@@ -122,7 +122,7 @@
this._profileUid = profile.uid;
this.baseSelectElement = document.createElement("select");
- this.baseSelectElement.className = "status-bar-item hidden";
+ this.baseSelectElement.className = "status-bar-item";
this.baseSelectElement.addEventListener("change", this._changeBase.bind(this), false);
this._updateBaseOptions();
@@ -172,7 +172,14 @@
get statusBarItems()
{
- return [this.viewSelectElement, this.baseSelectElement, this.filterSelectElement, this.helpButton.element];
+ function appendArrowImage(element, hidden)
+ {
+ var span = document.createElement("span");
+ span.className = "status-bar-select-container" + (hidden ? " hidden" : "");
+ span.appendChild(element);
+ return span;
+ }
+ return [appendArrowImage(this.viewSelectElement), appendArrowImage(this.baseSelectElement, true), appendArrowImage(this.filterSelectElement), this.helpButton.element];
},
get profile()
@@ -520,6 +527,19 @@
this._changeView(event.target.selectedIndex);
},
+ _updateSelectorsVisibility: function()
+ {
+ if (this.currentView === this.diffView)
+ this.baseSelectElement.parentElement.removeStyleClass("hidden");
+ else
+ this.baseSelectElement.parentElement.addStyleClass("hidden");
+
+ if (this.currentView === this.constructorsView)
+ this.filterSelectElement.parentElement.removeStyleClass("hidden");
+ else
+ this.filterSelectElement.parentElement.addStyleClass("hidden");
+ },
+
_changeView: function(selectedIndex)
{
if (selectedIndex === this.views.current)
@@ -534,18 +554,10 @@
this.refreshVisibleData();
this.dataGrid.updateWidths();
- if (this.currentView === this.diffView)
- this.baseSelectElement.removeStyleClass("hidden");
- else
- this.baseSelectElement.addStyleClass("hidden");
+ this._updateSelectorsVisibility();
this._updateDataSourceAndView();
- if (this.currentView === this.constructorsView)
- this.filterSelectElement.removeStyleClass("hidden");
- else
- this.filterSelectElement.addStyleClass("hidden");
-
if (!this.currentQuery || !this._searchFinishedCallback || !this._searchResults)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
