Title: [127139] trunk/Source/WebCore
- Revision
- 127139
- Author
- [email protected]
- Date
- 2012-08-30 07:48:22 -0700 (Thu, 30 Aug 2012)
Log Message
Remove the now-unneeded invalidations in RenderTable::removeCaption
https://bugs.webkit.org/show_bug.cgi?id=94889
Reviewed by Abhishek Arya.
Following bug 94842 and 95090, the invalidation code was pushed down to
RenderTableCaption. This made apparent that we did some invalidations that
were not needed.
Refactoring covered by existing tests.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::removeCaption):
Removed setNeedsRecalcStyle() as it's unneeded now. It was probably needed back when
we didn't support multiple captions (see bug 58249) but the need was never documented
so you could wonder if it was really needed in the first place.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (127138 => 127139)
--- trunk/Source/WebCore/ChangeLog 2012-08-30 14:45:28 UTC (rev 127138)
+++ trunk/Source/WebCore/ChangeLog 2012-08-30 14:48:22 UTC (rev 127139)
@@ -1,3 +1,22 @@
+2012-08-30 Julien Chaffraix <[email protected]>
+
+ Remove the now-unneeded invalidations in RenderTable::removeCaption
+ https://bugs.webkit.org/show_bug.cgi?id=94889
+
+ Reviewed by Abhishek Arya.
+
+ Following bug 94842 and 95090, the invalidation code was pushed down to
+ RenderTableCaption. This made apparent that we did some invalidations that
+ were not needed.
+
+ Refactoring covered by existing tests.
+
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::removeCaption):
+ Removed setNeedsRecalcStyle() as it's unneeded now. It was probably needed back when
+ we didn't support multiple captions (see bug 58249) but the need was never documented
+ so you could wonder if it was really needed in the first place.
+
2012-08-30 Ilya Tikhonovsky <[email protected]>
Web Inspector: [regression] ui: selectors in heap profiler view have no arrows at the right side of the text.
Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (127138 => 127139)
--- trunk/Source/WebCore/rendering/RenderTable.cpp 2012-08-30 14:45:28 UTC (rev 127138)
+++ trunk/Source/WebCore/rendering/RenderTable.cpp 2012-08-30 14:48:22 UTC (rev 127139)
@@ -210,11 +210,6 @@
return;
m_captions.remove(index);
-
- // FIXME: The rest of this function is probably not needed since we have
- // implemented proper multiple captions support (see bug 58249).
- if (node())
- node()->setNeedsStyleRecalc();
}
void RenderTable::computeLogicalWidth()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
