Title: [127180] trunk/Tools
- Revision
- 127180
- Author
- [email protected]
- Date
- 2012-08-30 13:22:29 -0700 (Thu, 30 Aug 2012)
Log Message
decide what (and how) we should set the tolerance for ref test pixel compares and test for that
https://bugs.webkit.org/show_bug.cgi?id=94746
Reviewed by Ojan Vafai.
Add an assertion to diff_image() to check that we are passing
tolerance=0 explicitly when diffing ref test results.
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.diff_image):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (127179 => 127180)
--- trunk/Tools/ChangeLog 2012-08-30 20:17:51 UTC (rev 127179)
+++ trunk/Tools/ChangeLog 2012-08-30 20:22:29 UTC (rev 127180)
@@ -1,5 +1,18 @@
2012-08-30 Dirk Pranke <[email protected]>
+ decide what (and how) we should set the tolerance for ref test pixel compares and test for that
+ https://bugs.webkit.org/show_bug.cgi?id=94746
+
+ Reviewed by Ojan Vafai.
+
+ Add an assertion to diff_image() to check that we are passing
+ tolerance=0 explicitly when diffing ref test results.
+
+ * Scripts/webkitpy/layout_tests/port/test.py:
+ (TestPort.diff_image):
+
+2012-08-30 Dirk Pranke <[email protected]>
+
NRWT should look in mac-wk2 for a TestExpecations file
https://bugs.webkit.org/show_bug.cgi?id=95370
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py (127179 => 127180)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py 2012-08-30 20:17:51 UTC (rev 127179)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py 2012-08-30 20:22:29 UTC (rev 127180)
@@ -405,6 +405,8 @@
def diff_image(self, expected_contents, actual_contents, tolerance=None):
diffed = actual_contents != expected_contents
+ if 'ref' in expected_contents:
+ assert tolerance == 0
if diffed:
return ("< %s\n---\n> %s\n" % (expected_contents, actual_contents), 1, None)
return (None, 0, None)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
