Title: [127181] trunk/Tools
- Revision
- 127181
- Author
- [email protected]
- Date
- 2012-08-30 13:24:45 -0700 (Thu, 30 Aug 2012)
Log Message
executive.run_in_parallel() hangs if given nothing to do
https://bugs.webkit.org/show_bug.cgi?id=95387
Reviewed by Ojan Vafai.
Check to make sure that Executive.run_in_parallel() requires
a non-empty list of commands to execute; passing an empty list
seems surely like a programming error.
* Scripts/webkitpy/common/system/executive.py:
(Executive.run_in_parallel):
* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_run_in_parallel_assert_nonempty):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (127180 => 127181)
--- trunk/Tools/ChangeLog 2012-08-30 20:22:29 UTC (rev 127180)
+++ trunk/Tools/ChangeLog 2012-08-30 20:24:45 UTC (rev 127181)
@@ -1,5 +1,21 @@
2012-08-30 Dirk Pranke <[email protected]>
+ executive.run_in_parallel() hangs if given nothing to do
+ https://bugs.webkit.org/show_bug.cgi?id=95387
+
+ Reviewed by Ojan Vafai.
+
+ Check to make sure that Executive.run_in_parallel() requires
+ a non-empty list of commands to execute; passing an empty list
+ seems surely like a programming error.
+
+ * Scripts/webkitpy/common/system/executive.py:
+ (Executive.run_in_parallel):
+ * Scripts/webkitpy/common/system/executive_unittest.py:
+ (ExecutiveTest.test_run_in_parallel_assert_nonempty):
+
+2012-08-30 Dirk Pranke <[email protected]>
+
decide what (and how) we should set the tolerance for ref test pixel compares and test for that
https://bugs.webkit.org/show_bug.cgi?id=94746
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (127180 => 127181)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-08-30 20:22:29 UTC (rev 127180)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2012-08-30 20:24:45 UTC (rev 127181)
@@ -459,6 +459,8 @@
def run_in_parallel(self, command_lines_and_cwds, processes=None):
"""Runs a list of (cmd_line list, cwd string) tuples in parallel and returns a list of (retcode, stdout, stderr) tuples."""
+ assert len(command_lines_and_cwds)
+
if sys.platform in ('cygwin', 'win32'):
return map(_run_command_thunk, command_lines_and_cwds)
pool = multiprocessing.Pool(processes=processes)
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py (127180 => 127181)
--- trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2012-08-30 20:22:29 UTC (rev 127180)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2012-08-30 20:24:45 UTC (rev 127181)
@@ -235,7 +235,10 @@
self.assertEquals([output[1] for output in command_outputs], ["hello\n"] * NUM_PROCESSES)
self.assertEquals([], multiprocessing.active_children())
+ def test_run_in_parallel_assert_nonempty(self):
+ self.assertRaises(AssertionError, Executive().run_in_parallel, [])
+
def main(platform, stdin, stdout, cmd, args):
if platform == 'win32' and hasattr(stdout, 'fileno'):
import msvcrt
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
