Title: [127467] trunk/Source/WebCore
- Revision
- 127467
- Author
- [email protected]
- Date
- 2012-09-04 06:48:51 -0700 (Tue, 04 Sep 2012)
Log Message
Fix IDL dependency generation correctly
https://bugs.webkit.org/show_bug.cgi?id=95730
Patch by Jonathan Liu <[email protected]> on 2012-09-04
Reviewed by Csaba Osztrogonác.
IDL dependency generation is still not working after
https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
added after the filename in an echo command end up being added to the
file which isn't handled correctly by preprocess-idls.pl. The problem
is fixed by removing the space after the filename.
* DerivedSources.pri:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (127466 => 127467)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 13:36:10 UTC (rev 127466)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 13:48:51 UTC (rev 127467)
@@ -1,3 +1,18 @@
+2012-09-04 Jonathan Liu <[email protected]>
+
+ Fix IDL dependency generation correctly
+ https://bugs.webkit.org/show_bug.cgi?id=95730
+
+ Reviewed by Csaba Osztrogonác.
+
+ IDL dependency generation is still not working after
+ https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
+ added after the filename in an echo command end up being added to the
+ file which isn't handled correctly by preprocess-idls.pl. The problem
+ is fixed by removing the space after the filename.
+
+ * DerivedSources.pri:
+
2012-09-04 Mario Sanchez Prada <[email protected]>
[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
Modified: trunk/Source/WebCore/DerivedSources.pri (127466 => 127467)
--- trunk/Source/WebCore/DerivedSources.pri 2012-09-04 13:36:10 UTC (rev 127466)
+++ trunk/Source/WebCore/DerivedSources.pri 2012-09-04 13:48:51 UTC (rev 127467)
@@ -705,7 +705,8 @@
else: preprocessIdls.commands = cat /dev/null > $$IDL_FILES_TMP $$EOC
for(binding, IDL_BINDINGS) {
# We need "$$binding" instead of "$$binding ", because Windows' echo writes trailing whitespaces. (http://wkb.ug/88304)
- preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP $$EOC
+ # A space is omitted between "$$IDL_FILES_TMP" and "$$EOC" to also avoid writing trailing whitespace. (http://wkb.ug/95730)
+ preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP$$EOC
}
preprocessIdls.commands += perl -I$$PWD/bindings/scripts $$preprocessIdls.script \
--defines \"$${FEATURE_DEFINES_JAVASCRIPT}\" \
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
