Title: [127469] trunk/Source/WebCore
- Revision
- 127469
- Author
- [email protected]
- Date
- 2012-09-04 08:45:38 -0700 (Tue, 04 Sep 2012)
Log Message
[GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
https://bugs.webkit.org/show_bug.cgi?id=95751
Reviewed by Martin Robinson.
In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
gst_message_new_duration was renamed to
gst_message_new_duration_changed.
However the only place where we used this is in the HTTP source
element and only if appsrc < 0.10.27 is used at runtime. In the
case of GStreamer 1.0 this condition will be always false so we
can disable this code at build time.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveResponse):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (127468 => 127469)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 15:32:27 UTC (rev 127468)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 15:45:38 UTC (rev 127469)
@@ -1,3 +1,22 @@
+2012-09-04 Philippe Normand <[email protected]>
+
+ [GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
+ https://bugs.webkit.org/show_bug.cgi?id=95751
+
+ Reviewed by Martin Robinson.
+
+ In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
+ gst_message_new_duration was renamed to
+ gst_message_new_duration_changed.
+
+ However the only place where we used this is in the HTTP source
+ element and only if appsrc < 0.10.27 is used at runtime. In the
+ case of GStreamer 1.0 this condition will be always false so we
+ can disable this code at build time.
+
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+ (StreamingClient::didReceiveResponse):
+
2012-09-04 Andrei Poenaru <[email protected]>
Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (127468 => 127469)
--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2012-09-04 15:32:27 UTC (rev 127468)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2012-09-04 15:45:38 UTC (rev 127469)
@@ -782,18 +782,15 @@
if (length > 0) {
length += priv->requestedOffset;
gst_app_src_set_size(priv->appsrc, length);
+
+#ifndef GST_API_VERSION_1
if (!priv->haveAppSrc27) {
-#ifdef GST_API_VERSION_1
- GstSegment* segment = &GST_BASE_SRC(priv->appsrc)->segment;
- segment->duration = length;
- segment->format = GST_FORMAT_BYTES;
-#else
gst_segment_set_duration(&GST_BASE_SRC(priv->appsrc)->segment, GST_FORMAT_BYTES, length);
-#endif
gst_element_post_message(GST_ELEMENT(priv->appsrc),
gst_message_new_duration(GST_OBJECT(priv->appsrc),
GST_FORMAT_BYTES, length));
}
+#endif
}
priv->size = length >= 0 ? length : 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
