Title: [131673] trunk/Source/WebCore
- Revision
- 131673
- Author
- [email protected]
- Date
- 2012-10-17 17:03:57 -0700 (Wed, 17 Oct 2012)
Log Message
[V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation
https://bugs.webkit.org/show_bug.cgi?id=99653
Reviewed by Eric Seidel.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131672 => 131673)
--- trunk/Source/WebCore/ChangeLog 2012-10-18 00:02:25 UTC (rev 131672)
+++ trunk/Source/WebCore/ChangeLog 2012-10-18 00:03:57 UTC (rev 131673)
@@ -1,3 +1,13 @@
+2012-10-17 Adam Barth <[email protected]>
+
+ [V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation
+ https://bugs.webkit.org/show_bug.cgi?id=99653
+
+ Reviewed by Eric Seidel.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+
2012-10-17 David Grogan <[email protected]>
IndexedDB: Destroy leveldb directory if unknown schema is detected
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (131672 => 131673)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-10-18 00:02:25 UTC (rev 131672)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-10-18 00:03:57 UTC (rev 131673)
@@ -382,9 +382,13 @@
}
inline static v8::Handle<v8::Object> wrap(${nativeType}*, v8::Handle<v8::Object> creationContext = v8::Handle<v8::Object>(), v8::Isolate* = 0);
static void derefObject(void*);
- static void visitDOMWrapper(DOMDataStore*, void*, v8::Persistent<v8::Object>);
static WrapperTypeInfo info;
END
+
+ if (NeedsToVisitDOMWrapper($dataNode)) {
+ push(@headerContent, " static void visitDOMWrapper(DOMDataStore*, void*, v8::Persistent<v8::Object>);\n");
+ }
+
if ($dataNode->extendedAttributes->{"ActiveDOMObject"}) {
push(@headerContent, " static ActiveDOMObject* toActiveDOMObject(v8::Handle<v8::Object>);\n");
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
