Title: [131675] trunk/Source
- Revision
- 131675
- Author
- [email protected]
- Date
- 2012-10-17 17:08:29 -0700 (Wed, 17 Oct 2012)
Log Message
[WebKit2] Add removeChild: to WKDOMNode and make WKDOMText.data read/write
https://bugs.webkit.org/show_bug.cgi?id=99662
Reviewed by Sam Weinig.
Source/WebCore:
Export needed symbols.
* WebCore.exp.in:
Source/WebKit2:
* WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
* WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
(-[WKDOMNode removeChild:]):
* WebProcess/InjectedBundle/API/mac/WKDOMText.h:
* WebProcess/InjectedBundle/API/mac/WKDOMText.mm:
(-[WKDOMText setData:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131674 => 131675)
--- trunk/Source/WebCore/ChangeLog 2012-10-18 00:07:08 UTC (rev 131674)
+++ trunk/Source/WebCore/ChangeLog 2012-10-18 00:08:29 UTC (rev 131675)
@@ -1,3 +1,14 @@
+2012-10-17 Andy Estes <[email protected]>
+
+ [WebKit2] Add removeChild: to WKDOMNode and make WKDOMText.data read/write
+ https://bugs.webkit.org/show_bug.cgi?id=99662
+
+ Reviewed by Sam Weinig.
+
+ Export needed symbols.
+
+ * WebCore.exp.in:
+
2012-10-17 Adam Barth <[email protected]>
[V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation
Modified: trunk/Source/WebCore/WebCore.exp.in (131674 => 131675)
--- trunk/Source/WebCore/WebCore.exp.in 2012-10-18 00:07:08 UTC (rev 131674)
+++ trunk/Source/WebCore/WebCore.exp.in 2012-10-18 00:08:29 UTC (rev 131675)
@@ -213,6 +213,7 @@
__ZN7WebCore13AXObjectCache21gAccessibilityEnabledE
__ZN7WebCore13AXObjectCache23focusedUIElementForPageEPKNS_4PageE
__ZN7WebCore13AXObjectCache42gAccessibilityEnhancedUserInterfaceEnabledE
+__ZN7WebCore13CharacterData7setDataERKN3WTF6StringERi
__ZN7WebCore13HTTPHeaderMapC1Ev
__ZN7WebCore13HTTPHeaderMapD1Ev
__ZN7WebCore13HitTestResultC1ERKS0_
@@ -672,6 +673,7 @@
__ZN7WebCore4KURLC1ERKS0_RKN3WTF6StringE
__ZN7WebCore4Node10renderRectEPb
__ZN7WebCore4Node11appendChildEN3WTF10PassRefPtrIS0_EERib
+__ZN7WebCore4Node11removeChildEPS0_Ri
__ZN7WebCore4Node14removedLastRefEv
__ZN7WebCore4Node17stopIgnoringLeaksEv
__ZN7WebCore4Node18startIgnoringLeaksEv
Modified: trunk/Source/WebKit2/ChangeLog (131674 => 131675)
--- trunk/Source/WebKit2/ChangeLog 2012-10-18 00:07:08 UTC (rev 131674)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-18 00:08:29 UTC (rev 131675)
@@ -1,3 +1,17 @@
+2012-10-17 Andy Estes <[email protected]>
+
+ [WebKit2] Add removeChild: to WKDOMNode and make WKDOMText.data read/write
+ https://bugs.webkit.org/show_bug.cgi?id=99662
+
+ Reviewed by Sam Weinig.
+
+ * WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
+ * WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
+ (-[WKDOMNode removeChild:]):
+ * WebProcess/InjectedBundle/API/mac/WKDOMText.h:
+ * WebProcess/InjectedBundle/API/mac/WKDOMText.mm:
+ (-[WKDOMText setData:]):
+
2012-10-17 Christophe Dumez <[email protected]>
[EFL][WK2] Memory leak in ewk_download_job_response_set()
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNode.h (131674 => 131675)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNode.h 2012-10-18 00:07:08 UTC (rev 131674)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNode.h 2012-10-18 00:08:29 UTC (rev 131675)
@@ -35,6 +35,7 @@
- (void)insertNode:(WKDOMNode *)node before:(WKDOMNode *)refNode;
- (void)appendChild:(WKDOMNode *)node;
+- (void)removeChild:(WKDOMNode *)node;
@property(readonly) WKDOMDocument *document;
@property(readonly) WKDOMNode *parentNode;
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm (131674 => 131675)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm 2012-10-18 00:07:08 UTC (rev 131674)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm 2012-10-18 00:08:29 UTC (rev 131675)
@@ -65,6 +65,13 @@
_impl->appendChild(WebKit::toWebCoreNode(node), ec);
}
+- (void)removeChild:(WKDOMNode *)node
+{
+ // FIXME: Do something about the exception.
+ WebCore::ExceptionCode ec;
+ _impl->removeChild(WebKit::toWebCoreNode(node), ec);
+}
+
- (WKDOMDocument *)document
{
return WebKit::toWKDOMDocument(_impl->document());
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMText.h (131674 => 131675)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMText.h 2012-10-18 00:07:08 UTC (rev 131674)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMText.h 2012-10-18 00:08:29 UTC (rev 131675)
@@ -30,7 +30,7 @@
WK_EXPORT
@interface WKDOMText : WKDOMNode
-@property(readonly) NSString *data;
+@property(nonatomic, copy) NSString *data;
@end
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMText.mm (131674 => 131675)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMText.mm 2012-10-18 00:07:08 UTC (rev 131674)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMText.mm 2012-10-18 00:08:29 UTC (rev 131675)
@@ -38,6 +38,13 @@
return WebCore::toText(_impl.get())->data();
}
+- (void)setData:(NSString *)data
+{
+ // FIXME: Do something about the exception.
+ WebCore::ExceptionCode ec;
+ WebCore::toText(_impl.get())->setData(data, ec);
+}
+
@end
#endif // defined(__LP64__) && defined(__clang__)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
