Log Message
[V8] Enter an Isolate before initializing PerIsolateData https://bugs.webkit.org/show_bug.cgi?id=103949
Reviewed by Adam Barth. Currently we initialize PerIsolateData before entering an Isolate, which prevents us from using an Isolate in the PerIsolateData constructor. We should enter an Isolate first and then initialize PerIsolateData. No tests. No change in behavior. * bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136478 => 136479)
--- trunk/Source/WebCore/ChangeLog 2012-12-04 07:37:12 UTC (rev 136478)
+++ trunk/Source/WebCore/ChangeLog 2012-12-04 07:41:41 UTC (rev 136479)
@@ -1,3 +1,20 @@
+2012-12-03 Kentaro Hara <[email protected]>
+
+ [V8] Enter an Isolate before initializing PerIsolateData
+ https://bugs.webkit.org/show_bug.cgi?id=103949
+
+ Reviewed by Adam Barth.
+
+ Currently we initialize PerIsolateData before entering an Isolate,
+ which prevents us from using an Isolate in the PerIsolateData
+ constructor. We should enter an Isolate first and then initialize
+ PerIsolateData.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/WorkerScriptController.cpp:
+ (WebCore::WorkerScriptController::WorkerScriptController):
+
2012-12-03 Sergio Villar Senin <[email protected]>
[GTK] Add WebKitDOMShadowRoot.h to the list of public API headers after r135693
Modified: trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp (136478 => 136479)
--- trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp 2012-12-04 07:37:12 UTC (rev 136478)
+++ trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp 2012-12-04 07:41:41 UTC (rev 136479)
@@ -61,8 +61,8 @@
, m_executionForbidden(false)
, m_executionScheduledToTerminate(false)
{
+ m_isolate->Enter();
V8PerIsolateData* data = ""
- m_isolate->Enter();
m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::Worker));
data->setDOMDataStore(m_domDataStore.get());
_______________________________________________ webkit-changes mailing list [email protected] http://lists.webkit.org/mailman/listinfo/webkit-changes
