Title: [136480] trunk/Source/WebCore
- Revision
- 136480
- Author
- [email protected]
- Date
- 2012-12-03 23:48:41 -0800 (Mon, 03 Dec 2012)
Log Message
Unreviewed build fix after r136467
The template element patch added asserts in parserAppendChild and parserInsertBefore which should be valid, but DOMImplementation::createDocument() calls parserAppendChild with docType without regard to its owner. This patch removes the assert and adds a FIXME.
Patch by Rafael Weinstein <[email protected]> on 2012-12-03
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAppendChild):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136479 => 136480)
--- trunk/Source/WebCore/ChangeLog 2012-12-04 07:41:41 UTC (rev 136479)
+++ trunk/Source/WebCore/ChangeLog 2012-12-04 07:48:41 UTC (rev 136480)
@@ -1,3 +1,13 @@
+2012-12-03 Rafael Weinstein <[email protected]>
+
+ Unreviewed build fix after r136467
+
+ The template element patch added asserts in parserAppendChild and parserInsertBefore which should be valid, but DOMImplementation::createDocument() calls parserAppendChild with docType without regard to its owner. This patch removes the assert and adds a FIXME.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::parserInsertBefore):
+ (WebCore::ContainerNode::parserAppendChild):
+
2012-12-03 Kentaro Hara <[email protected]>
[V8] Enter an Isolate before initializing PerIsolateData
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (136479 => 136480)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2012-12-04 07:41:41 UTC (rev 136479)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2012-12-04 07:48:41 UTC (rev 136480)
@@ -696,7 +696,9 @@
{
ASSERT(newChild);
ASSERT(!newChild->parentNode()); // Use appendChild if you need to handle reparenting (and want DOM mutation events).
- ASSERT(document() == newChild->document());
+ // FIXME: This assert should be valid, but DOMImplementation::createDocument()
+ // blindly calls paserAppendChild on the docType its passed.
+ // ASSERT(document() == newChild->document());
Node* last = m_lastChild;
{
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
