Title: [137088] trunk/LayoutTests
Revision
137088
Author
[email protected]
Date
2012-12-09 10:55:30 -0800 (Sun, 09 Dec 2012)

Log Message

[GTK] accessibility/canvas-fallback-content.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98362

Patch by Joanmarie Diggs <[email protected]> on 2012-12-09
Reviewed by Martin Robinson.

The failure was due to platform-specific expectations of the accessible
role reported for comboboxes. The solution was conditionalizing the test.

* accessibility/canvas-fallback-content.html: Base expected role on platform.
* platform/gtk/TestExpectations: Unskipped the test.
* platform/gtk/accessibility/canvas-fallback-content-expected.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (137087 => 137088)


--- trunk/LayoutTests/ChangeLog	2012-12-09 18:40:06 UTC (rev 137087)
+++ trunk/LayoutTests/ChangeLog	2012-12-09 18:55:30 UTC (rev 137088)
@@ -1,3 +1,17 @@
+2012-12-09  Joanmarie Diggs  <[email protected]>
+
+        [GTK] accessibility/canvas-fallback-content.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=98362
+
+        Reviewed by Martin Robinson.
+
+        The failure was due to platform-specific expectations of the accessible
+        role reported for comboboxes. The solution was conditionalizing the test.
+
+        * accessibility/canvas-fallback-content.html: Base expected role on platform.
+        * platform/gtk/TestExpectations: Unskipped the test.
+        * platform/gtk/accessibility/canvas-fallback-content-expected.txt: Added.
+
 2012-12-09  Stephen White  <[email protected]>
 
         [Chromium] Unreviewed gardening.

Modified: trunk/LayoutTests/accessibility/canvas-fallback-content.html (137087 => 137088)


--- trunk/LayoutTests/accessibility/canvas-fallback-content.html	2012-12-09 18:40:06 UTC (rev 137087)
+++ trunk/LayoutTests/accessibility/canvas-fallback-content.html	2012-12-09 18:55:30 UTC (rev 137088)
@@ -52,6 +52,8 @@
         debug("");
     }
 
+    var comboBoxRole = (testRunner.platformName == "gtk") ? "AXRole: AXComboBox" : "AXRole: AXPopUpButton";
+
     // Check rendered controls.
     check("link1", "AXRole: AXLink");
     check("button1", "AXRole: AXButton");
@@ -59,7 +61,7 @@
     check("checkbox1", "AXRole: AXCheckBox");
     check("radio1", "AXRole: AXRadioButton");
     check("submit1", "AXRole: AXButton");
-    check("combobox1", "AXRole: AXPopUpButton");
+    check("combobox1", comboBoxRole);
     check("focusable1", "AXRole: AXGroup");
     check("aria-button1", "AXRole: AXButton");
     check("aria-link1", "AXRole: AXLink");
@@ -71,7 +73,7 @@
     check("checkbox2", "AXRole: AXCheckBox");
     check("radio2", "AXRole: AXRadioButton");
     check("submit2", "AXRole: AXButton");
-    check("combobox2", "AXRole: AXPopUpButton");
+    check("combobox2", comboBoxRole);
     check("focusable2", "AXRole: AXGroup");
     check("aria-button2", "AXRole: AXButton");
     check("aria-link2", "AXRole: AXLink");

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (137087 => 137088)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-12-09 18:40:06 UTC (rev 137087)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-12-09 18:55:30 UTC (rev 137088)
@@ -743,7 +743,6 @@
 webkit.org/b/98359 accessibility/aria-text-role.html [ Failure ]
 webkit.org/b/98360 accessibility/aria-used-on-image-maps.html [ Failure ]
 webkit.org/b/98361 accessibility/button-press-action.html [ Failure ]
-webkit.org/b/98362 accessibility/canvas-fallback-content.html [ Failure ]
 webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
 webkit.org/b/98364 accessibility/editable-webarea-context-menu-point.html [ Failure ]
 webkit.org/b/98365 accessibility/ellipsis-text.html [ Failure ]

Added: trunk/LayoutTests/platform/gtk/accessibility/canvas-fallback-content-expected.txt (0 => 137088)


--- trunk/LayoutTests/platform/gtk/accessibility/canvas-fallback-content-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/canvas-fallback-content-expected.txt	2012-12-09 18:55:30 UTC (rev 137088)
@@ -0,0 +1,101 @@
+Link  Button          
+Focusable
+ARIA button
+ARIA link
+This test makes sure that focusable elements in canvas fallback content are accessible.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+link1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXLink"
+
+button1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+text1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXTextField"
+
+checkbox1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXCheckBox"
+
+radio1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXRadioButton"
+
+submit1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+combobox1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXComboBox"
+
+focusable1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXGroup"
+
+aria-button1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+aria-link1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXLink"
+
+link2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXLink"
+
+button2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+text2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXTextField"
+
+checkbox2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXCheckBox"
+
+radio2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXRadioButton"
+
+submit2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+combobox2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXComboBox"
+
+focusable2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXGroup"
+
+aria-button2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+aria-link2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXLink"
+
+focusable1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+focusable2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to